Re: [Intel-xe] [PATCH 03/10] drm/xe/oa: Add registers and GPU commands used by OA

["Dixit, Ashutosh" <ashutosh.dixit@intel.com>]

On Tue, 22 Aug 2023 08:44:23 -0700, Nerlige Ramappa, Umesh wrote:
>

Hi Umesh,

> On Mon, Aug 07, 2023 at 06:31:52PM -0700, Ashutosh Dixit wrote:
> >Add registers and GPU commands used by OA in subsequent patches. The xe oa
> >code programs OA units which generate performance data. The code also
> >submits command buffers to change hardware engine context images and
> >implement waits.
> >
> >Signed-off-by: Ashutosh Dixit <ashutosh.dixit@intel.com>
> >---
> > drivers/gpu/drm/xe/regs/xe_engine_regs.h  |   5 +
> > drivers/gpu/drm/xe/regs/xe_gpu_commands.h |  27 ++++
> > drivers/gpu/drm/xe/regs/xe_oa_regs.h      | 173 ++++++++++++++++++++++
> > 3 files changed, 205 insertions(+)
> > create mode 100644 drivers/gpu/drm/xe/regs/xe_oa_regs.h
> >
> >diff --git a/drivers/gpu/drm/xe/regs/xe_engine_regs.h b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> >index 79873bf64e8dd..044a4920f1568 100644
> >--- a/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> >+++ b/drivers/gpu/drm/xe/regs/xe_engine_regs.h
> >@@ -84,6 +84,9 @@
> >
> > #define RING_CTX_TIMESTAMP(base)		XE_REG((base) + 0x3a8)
> >
> >+#define MI_PREDICATE_RESULT_2(base)		XE_REG((base) + 0x3bc)
> >+#define MI_PREDICATE_RESULT_1(base)		XE_REG((base) + 0x41c)
> >+
>
> We can drop these changes until we decide to implement the noa wait.

Done, in patch v2.

Thanks.
--
Ashutosh