Re: [Intel-xe] [PATCH 07/15] drm/xe/xe2: AuxCCS is no longer used

[Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>]

On 11.08.2023 09:06, Lucas De Marchi wrote:
> From: Matt Roper <matthew.d.roper@intel.com>
> 
> Starting with Xe2, all platforms (including igpu platforms) use FlatCCS
> compression rather than AuxCCS.  Similar to PVC, any future platforms
> that don't support FlatCCS should not attempt to fall back to AuxCCS
> programming.
> 
> Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_ring_ops.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>

Regards,
Bala
> 
> diff --git a/drivers/gpu/drm/xe/xe_ring_ops.c b/drivers/gpu/drm/xe/xe_ring_ops.c
> index 4a474ab04f96a..8c50ab4fdc6a0 100644
> --- a/drivers/gpu/drm/xe/xe_ring_ops.c
> +++ b/drivers/gpu/drm/xe/xe_ring_ops.c
> @@ -242,9 +242,11 @@ static bool has_aux_ccs(struct xe_device *xe)
>  {
>  	/*
>  	 * PVC is a special case that has no compression of either type
> -	 * (FlatCCS or AuxCCS).
> +	 * (FlatCCS or AuxCCS).  Also, AuxCCS is no longer used from Xe2
> +	 * onward, so any future platforms with no FlatCCS will not have
> +	 * AuxCCS either.
>  	 */
> -	if (xe->info.platform == XE_PVC)
> +	if (GRAPHICS_VER(xe) >= 20 || xe->info.platform == XE_PVC)
>  		return false;
>  
>  	return !xe->info.has_flat_ccs;
> -- 
> 2.40.1
>