Intel-XE Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 00/14] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM
@ 2026-02-23 13:44 Ankit Nautiyal
  2026-02-23 13:44 ` [PATCH 01/14] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
                   ` (16 more replies)
  0 siblings, 17 replies; 37+ messages in thread
From: Ankit Nautiyal @ 2026-02-23 13:44 UTC (permalink / raw)
  To: intel-gfx, intel-xe
  Cc: ville.syrjala, jouni.hogander, animesh.manna, Ankit Nautiyal

Enable Adaptive Sync SDP for Panel replay + auxless ALPM.
First few patches are fixes in existing AS SDP enablement.
Later patches add the support to send AS SDP for Panel replay with Link
ON and with auxless ALPM (Link-Off). 

This series is in continuation from discussions in [1] [2] and more
recent [3]:

Apart from few patches from [3] new changes include:
- Add AS SDP version and PR and VRR specific bits in drm_dp.h.
- Modify AS SDP compute config to accomodate PR with Link On and Link
  Off.
- Program Downspread Ctrl DPCD bits.
- Make way for T1 and T2 AS SDP transmission timing/position.

Note:
Currently I have enabled AS SDP for either VRR or Panel Replay. However
in view of the optimized guardband, perhaps we should always enable AS
SDP whenever supported. That way we will always take the AS SDP constraints
into account while computing the optimized guardband.

[1] https://lore.kernel.org/all/1b8c6c6de1e5fe0db83e6ae942dfee7e6f950767.camel@intel.com/
[2] https://lore.kernel.org/all/aPtqdAxDwiuQZbrn@intel.com/
[3] https://lore.kernel.org/intel-gfx/7c2d6f4e-69e6-452a-89cc-5fd4254430bd@intel.com/T/#m6e8beab2cc3b6ff9d61f740f107d83a2f4e08114

Ankit Nautiyal (14):
  drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP
  drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink
  drm/i915/dp: Add a helper to decide if AS SDP is needed
  drm/i915/dp: Update the helper intel_dp_needs_as_sdp() for CMRR
  include/drm/display/dp: Add field for storing AS SDP version
  drm/i915/dp: Use version field of AS SDP data structure
  drm/i915/dp: Compute AS SDP after PSR and LOBF
  drm/i915/dp: Add AS SDP support for PR with link ON
  drm/i915/psr: Add helper to check if PR is with link OFF
  drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless
    ALPM
  drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off
  include/drm/display/dp: Add DPCD registers for configuring Panel
    Replay + VRR
  drm/i915/display: Add member to store AS SDP transmission time
  drm/i915/dp: Account for AS_SDP guardband only when enabled

 drivers/gpu/drm/display/drm_dp_helper.c       |  1 +
 drivers/gpu/drm/i915/display/intel_alpm.c     | 21 +++++++-
 drivers/gpu/drm/i915/display/intel_display.c  |  3 +-
 .../drm/i915/display/intel_display_types.h    |  1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 48 ++++++++++++++-----
 .../drm/i915/display/intel_dp_link_training.c | 10 +++-
 .../drm/i915/display/intel_dp_link_training.h |  3 +-
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |  2 +-
 drivers/gpu/drm/i915/display/intel_psr.c      | 13 +++++
 drivers/gpu/drm/i915/display/intel_psr.h      |  1 +
 drivers/gpu/drm/i915/display/intel_vrr.c      | 10 ++++
 include/drm/display/drm_dp.h                  |  9 ++++
 include/drm/display/drm_dp_helper.h           |  1 +
 13 files changed, 105 insertions(+), 18 deletions(-)

-- 
2.45.2


^ permalink raw reply	[flat|nested] 37+ messages in thread
* [PATCH 2/4] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink
@ 2025-11-11  9:30 Ankit Nautiyal
  2026-02-23 13:14 ` [PATCH 00/14] Fix Adaptive Sync SDP for Panel Replay Ankit Nautiyal
  0 siblings, 1 reply; 37+ messages in thread
From: Ankit Nautiyal @ 2025-11-11  9:30 UTC (permalink / raw)
  To: intel-gfx, intel-xe; +Cc: jouni.hogander, ville.syrjala, Ankit Nautiyal

Currently we do not support VRR with HDMI so skip vrr compute
config step for DP PCON with HDMI sink.

Signed-off-by: Ankit Nautiyal <ankit.k.nautiyal@intel.com>
---
 drivers/gpu/drm/i915/display/intel_vrr.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_vrr.c b/drivers/gpu/drm/i915/display/intel_vrr.c
index 00cbc126fb36..7a58e1f8acea 100644
--- a/drivers/gpu/drm/i915/display/intel_vrr.c
+++ b/drivers/gpu/drm/i915/display/intel_vrr.c
@@ -42,7 +42,14 @@ bool intel_vrr_is_capable(struct intel_connector *connector)
 	case DRM_MODE_CONNECTOR_DisplayPort:
 		if (connector->mst.dp)
 			return false;
+
 		intel_dp = intel_attached_dp(connector);
+		/*
+		 * VRR via PCON is currently unsupported.
+		 * TODO: Add support for VRR for DP HDMI2.1 PCON.
+		 */
+		if (intel_dp_has_hdmi_sink(intel_dp))
+			return false;
 
 		if (!drm_dp_sink_can_do_video_without_timing_msa(intel_dp->dpcd))
 			return false;
-- 
2.45.2


^ permalink raw reply related	[flat|nested] 37+ messages in thread

end of thread, other threads:[~2026-02-27 12:22 UTC | newest]

Thread overview: 37+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-02-23 13:44 [PATCH 00/14] Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 01/14] drm/i915/dp: Fix readback for target_rr in Adaptive Sync SDP Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 02/14] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-02-26 15:22   ` Ville Syrjälä
2026-02-23 13:44 ` [PATCH 03/14] drm/i915/dp: Add a helper to decide if AS SDP is needed Ankit Nautiyal
2026-02-26 15:29   ` Ville Syrjälä
2026-02-26 16:01     ` Ville Syrjälä
2026-02-27 11:08       ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 04/14] drm/i915/dp: Update the helper intel_dp_needs_as_sdp() for CMRR Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 05/14] include/drm/display/dp: Add field for storing AS SDP version Ankit Nautiyal
2026-02-26 15:34   ` Ville Syrjälä
2026-02-27 11:13     ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 06/14] drm/i915/dp: Use version field of AS SDP data structure Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 07/14] drm/i915/dp: Compute AS SDP after PSR and LOBF Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 08/14] drm/i915/dp: Add AS SDP support for PR with link ON Ankit Nautiyal
2026-02-26 16:10   ` Ville Syrjälä
2026-02-27  4:37     ` Ville Syrjälä
2026-02-27  5:46       ` Hogander, Jouni
2026-02-27  5:49       ` Ville Syrjälä
2026-02-27 10:57         ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 09/14] drm/i915/psr: Add helper to check if PR is with link OFF Ankit Nautiyal
2026-02-26 16:12   ` Ville Syrjälä
2026-02-27 11:23     ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 10/14] drm/i915/dp: Set relevant Downspread Ctrl DPCD bits for PR + Auxless ALPM Ankit Nautiyal
2026-02-23 13:44 ` [PATCH 11/14] drm/i915/dp: Program AS SDP DB[1:0] for PR with Link off Ankit Nautiyal
2026-02-26 16:14   ` Ville Syrjälä
2026-02-27 11:25     ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 12/14] include/drm/display/dp: Add DPCD registers for configuring Panel Replay + VRR Ankit Nautiyal
2026-02-26 16:44   ` Ville Syrjälä
2026-02-23 13:44 ` [PATCH 13/14] drm/i915/display: Add member to store AS SDP transmission time Ankit Nautiyal
2026-02-26 17:00   ` Ville Syrjälä
2026-02-27 12:22     ` Nautiyal, Ankit K
2026-02-23 13:44 ` [PATCH 14/14] drm/i915/dp: Account for AS_SDP guardband only when enabled Ankit Nautiyal
2026-02-23 14:26 ` ✓ CI.KUnit: success for Fix Adaptive Sync SDP for PR with Link ON + Auxless ALPM Patchwork
2026-02-23 15:08 ` ✓ Xe.CI.BAT: " Patchwork
2026-02-24  8:12 ` ✗ Xe.CI.FULL: failure " Patchwork
  -- strict thread matches above, loose matches on Subject: below --
2025-11-11  9:30 [PATCH 2/4] drm/i915/vrr: Avoid vrr for PCON with HDMI2.1 sink Ankit Nautiyal
2026-02-23 13:14 ` [PATCH 00/14] Fix Adaptive Sync SDP for Panel Replay Ankit Nautiyal
2026-02-23 13:14   ` [PATCH 08/14] drm/i915/dp: Add AS SDP support for PR with link ON Ankit Nautiyal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox