Re: [PATCH v1 1/2] drm/xe/xe_ras: Add structures and commands for RAS GPU health indicator

[Andi Shyti <andi.shyti@linux.intel.com>]

Hi Soham,

On Thu, Apr 16, 2026 at 03:06:09PM +0530, Soham Purkait wrote:
> Add the sysctrl commands and response structures for GPU health
> indicator supported by RAS.

Can you please describe better the structures you are adding?

> Signed-off-by: Soham Purkait <soham.purkait@intel.com>

...

> +/**
> + * typedef xe_ras_health_status_t - Device health status values (8-bit)
> + *
> + * Three-state health indicator value reported by system controller commands.
> + *
> + * The expected values are:
> + * - 0: ok  - The device is healthy and operating within normal parameters.
> + * - 1: warning  - The device is experiencing minor issues but is still operational.
> + * - 2: critical  - The device is in a critical state and may not be operational.
> + */
> +typedef u8 xe_ras_health_status_t;

Please, don't add another definition of u8. Keep it u8. If you
expect only those three values (or at least a limited number of
values), you can define an enum.

Andi