Re: [PATCH v6 22/24] drm/xe: Enter ULLS for migration jobs upon page fault or SVM prefetch

["Ghimiray, Himal Prasad" <himal.prasad.ghimiray@intel.com>]

On 05-09-2026 02:46, Matthew Brost wrote:
> Call xe_migration_ulls_enter upon page fault or SVM prefetch in an

commit fix: xe_migrate_ulls_enter

> effort speed up these critical paths.
> 
> Signed-off-by: Matthew Brost <matthew.brost@intel.com>
> Link: https://patch.msgid.link/20260228013501.106680-25-matthew.brost@intel.com
> Signed-off-by: Maarten Lankhorst <dev@lankhorst.se>
> ---
>   drivers/gpu/drm/xe/xe_pagefault.c | 3 +++
>   drivers/gpu/drm/xe/xe_vm.c        | 4 +++-
>   2 files changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_pagefault.c b/drivers/gpu/drm/xe/xe_pagefault.c
> index e81ca24df37f..ecf2530f0284 100644
> --- a/drivers/gpu/drm/xe/xe_pagefault.c
> +++ b/drivers/gpu/drm/xe/xe_pagefault.c
> @@ -15,6 +15,7 @@
>   #include "xe_gt_stats.h"
>   #include "xe_hw_engine.h"
>   #include "xe_log.h"
> +#include "xe_migrate.h"
>   #include "xe_pagefault.h"
>   #include "xe_pagefault_types.h"
>   #include "xe_svm.h"
> @@ -262,6 +263,8 @@ static int xe_pagefault_service(struct xe_pagefault *pf)
>   	if (IS_ERR(vm))
>   		return PTR_ERR(vm);
>   
> +	xe_migrate_ulls_enter(gt_to_tile(gt)->migrate);
> +
>   	down_read(&vm->lock);
>   
>   	if (xe_vm_is_closed(vm)) {
> diff --git a/drivers/gpu/drm/xe/xe_vm.c b/drivers/gpu/drm/xe/xe_vm.c
> index ee4d149b7453..c68d3baf1988 100644
> --- a/drivers/gpu/drm/xe/xe_vm.c
> +++ b/drivers/gpu/drm/xe/xe_vm.c
> @@ -2526,8 +2526,10 @@ vm_bind_ioctl_ops_create(struct xe_vm *vm, struct xe_vma_ops *vops,
>   			ctx.devmem_possible = IS_DGFX(vm->xe) &&
>   					      IS_ENABLED(CONFIG_DRM_XE_PAGEMAP);
>   
> -			for_each_tile(tile, vm->xe, id)
> +			for_each_tile(tile, vm->xe, id) {
> +				xe_migrate_ulls_enter(tile->migrate);
>   				tile_mask |= 0x1 << id;
> +			}

Reviewed-by: Himal Prasad Ghimiray <himal.prasad.ghimiray@intel.com>

>   
>   			if (prefetch_region == DRM_XE_CONSULT_MEM_ADVISE_PREF_LOC) {
>   				dpagemap = xe_vma_resolve_pagemap(vma,