Re: [PATCH 07/22] KVM: arm64: nv: Set dirty state at stage-2

[Oliver Upton <oupton@kernel.org>]

On Mon, Jul 06, 2026 at 05:50:14PM +0100, Wei-Lin Chang wrote:
> Hi Oliver,
> 
> On Tue, Jun 23, 2026 at 11:41:46AM -0700, Oliver Upton wrote:
> > Set the dirty state on descriptors at stage-2 for write accesses when
> > DBM is set.
> > 
> > Signed-off-by: Oliver Upton <oupton@kernel.org>
> > ---
> >  arch/arm64/kvm/nested.c | 43 +++++++++++++++++++++++++++++++----------
> >  1 file changed, 33 insertions(+), 10 deletions(-)
> > 
> > diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
> > index a70af3b3f05d..e5a407fc0880 100644
> > --- a/arch/arm64/kvm/nested.c
> > +++ b/arch/arm64/kvm/nested.c
> > @@ -132,6 +132,7 @@ struct s2_walk_info {
> >  	unsigned int	t0sz;
> >  	bool		be;
> >  	bool		ha;
> > +	bool		hd;
> >  };
> >  
> >  struct s2_walk_step {
> > @@ -227,6 +228,20 @@ static int read_guest_s2_desc(struct kvm_vcpu *vcpu, struct s2_walk_step *ws,
> >  	return 0;
> >  }
> >  
> > +static bool should_set_dirty_state(struct s2_walk_info *wi, struct s2_walk_step *ws,
> > +				   struct kvm_s2_trans *out, struct kvm_walk_access *access)
> > +{
> > +	switch (access->type) {
> > +	/* R_RKMHW */
> 
> Just saying that I found that R_RKMHW is not about this behavior anymore
> in the latest M.c Arm ARM. This is covered by R_ZYGHJ now.

Thanks for the callout! What good are the rules if the citations change
over revisions :-/ Although in this case the language was indeed
updated.

Will fix it in v2.

Thanks,
Oliver