* [PATCH] arm64: smp: Fix missing IPI statistics
@ 2024-06-07 7:47 Jinjie Ruan
2024-06-07 16:02 ` Doug Anderson
2024-06-19 13:32 ` Will Deacon
0 siblings, 2 replies; 7+ messages in thread
From: Jinjie Ruan @ 2024-06-07 7:47 UTC (permalink / raw)
To: catalin.marinas, will, mark.rutland, dianders, swboyd, sumit.garg,
frederic, scott, misono.tomohiro, linux-arm-kernel, linux-kernel
Cc: ruanjinjie
commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
/proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
is missing in display.
Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
---
arch/arm64/kernel/smp.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 31c8b3094dd7..7f9a5cf0f3b8 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -1039,7 +1039,8 @@ void __init set_smp_ipi_range(int ipi_base, int n)
}
ipi_desc[i] = irq_to_desc(ipi_base + i);
- irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
+ if (i < NR_IPI)
+ irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
}
ipi_irq_base = ipi_base;
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: smp: Fix missing IPI statistics
2024-06-07 7:47 [PATCH] arm64: smp: Fix missing IPI statistics Jinjie Ruan
@ 2024-06-07 16:02 ` Doug Anderson
2024-06-14 2:48 ` Jinjie Ruan
2024-06-19 13:32 ` Will Deacon
1 sibling, 1 reply; 7+ messages in thread
From: Doug Anderson @ 2024-06-07 16:02 UTC (permalink / raw)
To: Jinjie Ruan
Cc: catalin.marinas, will, mark.rutland, swboyd, sumit.garg, frederic,
scott, misono.tomohiro, linux-arm-kernel, linux-kernel
Hi,
On Fri, Jun 7, 2024 at 12:45 AM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>
> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
> is missing in display.
>
> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> arch/arm64/kernel/smp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
While I won't object to your patch if everyone agrees that we want it,
fully excluding "cpu backtrace" and "kgdb roundup" from
/proc/interrupts was more of a design decision than a bug. Those two
IPIs are really special cases and not something that I'd expect anyone
to care about knowing the count of. Keeping them out of
"/proc/interrupts" just avoids noise. I'd also note that I believe
arm32 makes the same design choice for "cpu backtrace".
In any case, if we truly think people want the count of these IPIs
then it feels like we should report them in arch_show_interrupts()
where we can give them a nice string.
-Doug
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: smp: Fix missing IPI statistics
2024-06-07 16:02 ` Doug Anderson
@ 2024-06-14 2:48 ` Jinjie Ruan
0 siblings, 0 replies; 7+ messages in thread
From: Jinjie Ruan @ 2024-06-14 2:48 UTC (permalink / raw)
To: Doug Anderson
Cc: catalin.marinas, will, mark.rutland, swboyd, sumit.garg, frederic,
scott, misono.tomohiro, linux-arm-kernel, linux-kernel
On 2024/6/8 0:02, Doug Anderson wrote:
> Hi,
>
> On Fri, Jun 7, 2024 at 12:45 AM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>>
>> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
>> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
>> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
>> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
>> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
>> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
>> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
>> is missing in display.
>>
>> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> arch/arm64/kernel/smp.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> While I won't object to your patch if everyone agrees that we want it,
Hello, What's everyone's opinion?
> fully excluding "cpu backtrace" and "kgdb roundup" from
> /proc/interrupts was more of a design decision than a bug. Those two
> IPIs are really special cases and not something that I'd expect anyone
> to care about knowing the count of. Keeping them out of
> "/proc/interrupts" just avoids noise. I'd also note that I believe
> arm32 makes the same design choice for "cpu backtrace".
Yes, arm32 is same as arm64.
>
> In any case, if we truly think people want the count of these IPIs
> then it feels like we should report them in arch_show_interrupts()
> where we can give them a nice string.
That's a good idea.
>
> -Doug
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: smp: Fix missing IPI statistics
2024-06-07 7:47 [PATCH] arm64: smp: Fix missing IPI statistics Jinjie Ruan
2024-06-07 16:02 ` Doug Anderson
@ 2024-06-19 13:32 ` Will Deacon
2024-06-20 3:52 ` Jinjie Ruan
1 sibling, 1 reply; 7+ messages in thread
From: Will Deacon @ 2024-06-19 13:32 UTC (permalink / raw)
To: Jinjie Ruan
Cc: catalin.marinas, mark.rutland, dianders, swboyd, sumit.garg,
frederic, scott, misono.tomohiro, linux-arm-kernel, linux-kernel
On Fri, Jun 07, 2024 at 03:47:16PM +0800, Jinjie Ruan wrote:
> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
> is missing in display.
>
> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> ---
> arch/arm64/kernel/smp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
> index 31c8b3094dd7..7f9a5cf0f3b8 100644
> --- a/arch/arm64/kernel/smp.c
> +++ b/arch/arm64/kernel/smp.c
> @@ -1039,7 +1039,8 @@ void __init set_smp_ipi_range(int ipi_base, int n)
> }
>
> ipi_desc[i] = irq_to_desc(ipi_base + i);
> - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
> + if (i < NR_IPI)
> + irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
> }
Please can you show the contents of /proc/interrupts before and after
this patch and put that in the commit message? I'm not seeing how the
two new IPIs get picked up by arch_show_interrupts().
Thanks,
Will
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: smp: Fix missing IPI statistics
2024-06-19 13:32 ` Will Deacon
@ 2024-06-20 3:52 ` Jinjie Ruan
0 siblings, 0 replies; 7+ messages in thread
From: Jinjie Ruan @ 2024-06-20 3:52 UTC (permalink / raw)
To: Will Deacon
Cc: catalin.marinas, mark.rutland, dianders, swboyd, sumit.garg,
frederic, scott, misono.tomohiro, linux-arm-kernel, linux-kernel
On 2024/6/19 21:32, Will Deacon wrote:
> On Fri, Jun 07, 2024 at 03:47:16PM +0800, Jinjie Ruan wrote:
>> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
>> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
>> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
>> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
>> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
>> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
>> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
>> is missing in display.
>>
>> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
>> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
>> ---
>> arch/arm64/kernel/smp.c | 3 ++-
>> 1 file changed, 2 insertions(+), 1 deletion(-)
>>
>> diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
>> index 31c8b3094dd7..7f9a5cf0f3b8 100644
>> --- a/arch/arm64/kernel/smp.c
>> +++ b/arch/arm64/kernel/smp.c
>> @@ -1039,7 +1039,8 @@ void __init set_smp_ipi_range(int ipi_base, int n)
>> }
>>
>> ipi_desc[i] = irq_to_desc(ipi_base + i);
>> - irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>> + if (i < NR_IPI)
>> + irq_set_status_flags(ipi_base + i, IRQ_HIDDEN);
>> }
>
> Please can you show the contents of /proc/interrupts before and after
> this patch and put that in the commit message? I'm not seeing how the
> two new IPIs get picked up by arch_show_interrupts().
Before this patch, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are missing as below:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
11: 463 656 243 654 GICv3 27 Level
arch_timer
13: 14 0 0 0 GICv3 33 Level
uart-pl011
17: 0 0 0 0 ITS-MSI 16384 Edge
virtio2-config
18: 0 5 0 0 ITS-MSI 16385 Edge
virtio2-input
19: 68 0 0 0 GICv3 78 Edge
virtio0
20: 0 0 0 0 GICv3 79 Edge
virtio1
21: 0 0 0 0 GICv3 34 Level
rtc-pl031
22: 2 2 2 2 GICv3 23 Level
arm-pmu
23: 0 0 0 0 ITS-MSI 32768 Edge
virtio3-config
24: 0 0 0 0 ITS-MSI 32769 Edge
virtio3-requests
25: 0 0 0 0 9030000.pl061 3 Edge
GPIO Key Poweroff
IPI0: 15 13 5 21 Rescheduling
interrupts
IPI1: 385 129 282 194 Function call
interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for
crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast
interrupts
IPI5: 1 0 0 0 IRQ work interrupts
Err: 0
After this patch the hwirq6/7 IPI is also displayed:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
7: 0 0 0 0 GICv3 6 Edge IPI
8: 0 0 0 0 GICv3 7 Edge IPI
11: 414 433 424 422 GICv3 27 Level
arch_timer
13: 21 0 0 0 GICv3 33 Level
uart-pl011
17: 0 0 0 0 ITS-MSI 16384 Edge
virtio2-config
18: 0 6 0 0 ITS-MSI 16385 Edge
virtio2-input
19: 60 0 0 0 GICv3 78 Edge
virtio0
20: 0 0 0 0 GICv3 79 Edge
virtio1
21: 0 0 0 0 GICv3 34 Level
rtc-pl031
22: 3 3 3 3 GICv3 23 Level
arm-pmu
23: 0 0 0 0 ITS-MSI 32768 Edge
virtio3-config
24: 0 0 0 0 ITS-MSI 32769 Edge
virtio3-requests
25: 0 0 0 0 9030000.pl061 3 Edge
GPIO Key Poweroff
IPI0: 15 13 19 12 Rescheduling
interrupts
IPI1: 241 162 328 252 Function call
interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for
crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast
interrupts
IPI5: 0 1 0 0 IRQ work interrupts
Err: 0
>
> Thanks,
>
> Will
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] arm64: smp: Fix missing IPI statistics
@ 2024-06-20 6:34 Jinjie Ruan
2024-06-20 22:26 ` Doug Anderson
0 siblings, 1 reply; 7+ messages in thread
From: Jinjie Ruan @ 2024-06-20 6:34 UTC (permalink / raw)
To: catalin.marinas, will, mark.rutland, dianders, swboyd, sumit.garg,
frederic, scott, misono.tomohiro, linux-arm-kernel, linux-kernel
Cc: ruanjinjie
commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
/proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
is missing in display.
Before this patch, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are missing:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
11: 466 600 309 332 GICv3 27 Level arch_timer
13: 24 0 0 0 GICv3 33 Level uart-pl011
15: 64 0 0 0 GICv3 78 Edge virtio0
16: 0 0 0 0 GICv3 79 Edge virtio1
17: 0 0 0 0 GICv3 34 Level rtc-pl031
18: 3 3 3 3 GICv3 23 Level arm-pmu
19: 0 0 0 0 9030000.pl061 3 Edge GPIO Key Poweroff
IPI0: 7 14 9 26 Rescheduling interrupts
IPI1: 354 93 233 255 Function call interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast interrupts
IPI5: 1 0 0 0 IRQ work interrupts
Err: 0
After this pacth, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are displayed:
/ # cat /proc/interrupts
CPU0 CPU1 CPU2 CPU3
11: 393 281 532 449 GICv3 27 Level arch_timer
13: 15 0 0 0 GICv3 33 Level uart-pl011
15: 64 0 0 0 GICv3 78 Edge virtio0
16: 0 0 0 0 GICv3 79 Edge virtio1
17: 0 0 0 0 GICv3 34 Level rtc-pl031
18: 2 2 2 2 GICv3 23 Level arm-pmu
19: 0 0 0 0 9030000.pl061 3 Edge GPIO Key Poweroff
IPI0: 11 19 4 23 Rescheduling interrupts
IPI1: 279 347 222 72 Function call interrupts
IPI2: 0 0 0 0 CPU stop interrupts
IPI3: 0 0 0 0 CPU stop (for crash dump) interrupts
IPI4: 0 0 0 0 Timer broadcast interrupts
IPI5: 1 0 0 1 IRQ work interrupts
IPI6: 0 0 0 0 CPU backtrace interrupts
IPI7: 0 0 0 0 KGDB roundup interrupts
Err: 0
Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Suggested-by: Doug Anderson <dianders@chromium.org>
---
v2:
- Report them in arch_show_interrupts().
- Add suggested-by.
- Update the commit message.
---
arch/arm64/kernel/smp.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/kernel/smp.c b/arch/arm64/kernel/smp.c
index 31c8b3094dd7..5de85dccc09c 100644
--- a/arch/arm64/kernel/smp.c
+++ b/arch/arm64/kernel/smp.c
@@ -767,13 +767,15 @@ void __init smp_prepare_cpus(unsigned int max_cpus)
}
}
-static const char *ipi_types[NR_IPI] __tracepoint_string = {
+static const char *ipi_types[MAX_IPI] __tracepoint_string = {
[IPI_RESCHEDULE] = "Rescheduling interrupts",
[IPI_CALL_FUNC] = "Function call interrupts",
[IPI_CPU_STOP] = "CPU stop interrupts",
[IPI_CPU_CRASH_STOP] = "CPU stop (for crash dump) interrupts",
[IPI_TIMER] = "Timer broadcast interrupts",
[IPI_IRQ_WORK] = "IRQ work interrupts",
+ [IPI_CPU_BACKTRACE] = "CPU backtrace interrupts",
+ [IPI_KGDB_ROUNDUP] = "KGDB roundup interrupts",
};
static void smp_cross_call(const struct cpumask *target, unsigned int ipinr);
@@ -784,7 +786,7 @@ int arch_show_interrupts(struct seq_file *p, int prec)
{
unsigned int cpu, i;
- for (i = 0; i < NR_IPI; i++) {
+ for (i = 0; i < MAX_IPI; i++) {
seq_printf(p, "%*s%u:%s", prec - 1, "IPI", i,
prec >= 4 ? " " : "");
for_each_online_cpu(cpu)
--
2.34.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] arm64: smp: Fix missing IPI statistics
2024-06-20 6:34 Jinjie Ruan
@ 2024-06-20 22:26 ` Doug Anderson
0 siblings, 0 replies; 7+ messages in thread
From: Doug Anderson @ 2024-06-20 22:26 UTC (permalink / raw)
To: Jinjie Ruan
Cc: catalin.marinas, will, mark.rutland, swboyd, sumit.garg, frederic,
scott, misono.tomohiro, linux-arm-kernel, linux-kernel
Hi,
On Wed, Jun 19, 2024 at 11:31 PM Jinjie Ruan <ruanjinjie@huawei.com> wrote:
>
> commit 83cfac95c018 ("genirq: Allow interrupts to be excluded from
> /proc/interrupts") is to avoid IPIs appear twice in /proc/interrupts.
> But the commit 331a1b3a836c ("arm64: smp: Add arch support for backtrace
> using pseudo-NMI") and commit 2f5cd0c7ffde("arm64: kgdb: Implement
> kgdb_roundup_cpus() to enable pseudo-NMI roundup") set CPU_BACKTRACE and
> KGDB_ROUNDUP IPIs "IRQ_HIDDEN" flag but not show them in
> arch_show_interrupts(), which cause the interrupt kstat_irqs accounting
> is missing in display.
>
> Before this patch, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are missing:
> / # cat /proc/interrupts
> CPU0 CPU1 CPU2 CPU3
> 11: 466 600 309 332 GICv3 27 Level arch_timer
> 13: 24 0 0 0 GICv3 33 Level uart-pl011
> 15: 64 0 0 0 GICv3 78 Edge virtio0
> 16: 0 0 0 0 GICv3 79 Edge virtio1
> 17: 0 0 0 0 GICv3 34 Level rtc-pl031
> 18: 3 3 3 3 GICv3 23 Level arm-pmu
> 19: 0 0 0 0 9030000.pl061 3 Edge GPIO Key Poweroff
> IPI0: 7 14 9 26 Rescheduling interrupts
> IPI1: 354 93 233 255 Function call interrupts
> IPI2: 0 0 0 0 CPU stop interrupts
> IPI3: 0 0 0 0 CPU stop (for crash dump) interrupts
> IPI4: 0 0 0 0 Timer broadcast interrupts
> IPI5: 1 0 0 0 IRQ work interrupts
> Err: 0
>
> After this pacth, CPU_BACKTRACE and KGDB_ROUNDUP IPIs are displayed:
> / # cat /proc/interrupts
> CPU0 CPU1 CPU2 CPU3
> 11: 393 281 532 449 GICv3 27 Level arch_timer
> 13: 15 0 0 0 GICv3 33 Level uart-pl011
> 15: 64 0 0 0 GICv3 78 Edge virtio0
> 16: 0 0 0 0 GICv3 79 Edge virtio1
> 17: 0 0 0 0 GICv3 34 Level rtc-pl031
> 18: 2 2 2 2 GICv3 23 Level arm-pmu
> 19: 0 0 0 0 9030000.pl061 3 Edge GPIO Key Poweroff
> IPI0: 11 19 4 23 Rescheduling interrupts
> IPI1: 279 347 222 72 Function call interrupts
> IPI2: 0 0 0 0 CPU stop interrupts
> IPI3: 0 0 0 0 CPU stop (for crash dump) interrupts
> IPI4: 0 0 0 0 Timer broadcast interrupts
> IPI5: 1 0 0 1 IRQ work interrupts
> IPI6: 0 0 0 0 CPU backtrace interrupts
> IPI7: 0 0 0 0 KGDB roundup interrupts
> Err: 0
>
> Fixes: 331a1b3a836c ("arm64: smp: Add arch support for backtrace using pseudo-NMI")
> Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
> Suggested-by: Doug Anderson <dianders@chromium.org>
> ---
> v2:
> - Report them in arch_show_interrupts().
> - Add suggested-by.
> - Update the commit message.
> ---
> arch/arm64/kernel/smp.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Personally I don't find a ton of value in having the "CPU backtrace
interrupts" and "KGDB roundup interrupts" reported, but I agree that
if someone does find value in having them reported that this is the
best way. I guess that means a light:
Reviewed-by: Douglas Anderson <dianders@chromium.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2024-06-20 22:27 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-06-07 7:47 [PATCH] arm64: smp: Fix missing IPI statistics Jinjie Ruan
2024-06-07 16:02 ` Doug Anderson
2024-06-14 2:48 ` Jinjie Ruan
2024-06-19 13:32 ` Will Deacon
2024-06-20 3:52 ` Jinjie Ruan
-- strict thread matches above, loose matches on Subject: below --
2024-06-20 6:34 Jinjie Ruan
2024-06-20 22:26 ` Doug Anderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox