From: Fenghua Yu <fenghuay@nvidia.com>
To: Reinette Chatre <reinette.chatre@intel.com>,
Tony Luck <tony.luck@intel.com>, Ben Horgan <ben.horgan@arm.com>,
James Morse <james.morse@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
Shaopeng Tan <tan.shaopeng@fujitsu.com>,
Chen Yu <yu.c.chen@intel.com>, Babu Moger <babu.moger@amd.com>,
Drew Fustini <fustini@kernel.org>,
Vikram Sethi <vsethi@nvidia.com>,
Shanker Donthineni <sdonthineni@nvidia.com>,
Newton Liu <newtonl@nvidia.com>, Gavin Shan <gshan@redhat.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Fenghua Yu <fenghuay@nvidia.com>
Subject: [PATCH 03/23] resctrl: Expose MBA resource_schemata mode sysfs
Date: Thu, 16 Jul 2026 14:02:53 -0700 [thread overview]
Message-ID: <20260716210329.2914625-3-fenghuay@nvidia.com> (raw)
In-Reply-To: <cover.1784217438.git.fenghuay@nvidia.com>
Node-scoped MBA on MPAM needs a way to distinguish native memory-side
controls from legacy L3-shaped MB emulation. Track the selected emulate
mode on rdt_resource and expose it as
info/<resource>/resource_schemata/mode ("native" or "legacy") when the
architecture enables emulation.
The mode file is only created when rdt_resource::mode is non-zero
(RESCTRL_CTRL_LEGACY or RESCTRL_CTRL_NATIVE). It defaults to
RESCTRL_CTRL_MODE_NONE, so resources whose architecture does not support
control emulation get no mode file and are unaffected. Architecture
backends that support emulation set the initial mode when they create
their controls; on MPAM this is wired up together with the node-scoped
MB_NODE control in a later patch, so this commit only adds the (dormant)
generic mechanism.
The mode file is added read-only here: switching the mode at runtime
requires rebuilding the resource_schemata layout to match the new mode,
so the writable interface is added together with that rebuild logic in a
later patch. Keeping the file read-only until then avoids exposing a
writable-but-no-op interface.
Store rdt_resource_final in the resource_schemata directory priv so the
mode file can resolve the backing resource without dereferencing NULL.
Signed-off-by: Fenghua Yu <fenghuay@nvidia.com>
---
fs/resctrl/rdtgroup.c | 77 ++++++++++++++++++++++++++++++++++++++++-
include/linux/resctrl.h | 17 +++++++++
2 files changed, 93 insertions(+), 1 deletion(-)
diff --git a/fs/resctrl/rdtgroup.c b/fs/resctrl/rdtgroup.c
index 2abb7fda6091..6b1f24c6a1f2 100644
--- a/fs/resctrl/rdtgroup.c
+++ b/fs/resctrl/rdtgroup.c
@@ -2696,6 +2696,74 @@ static unsigned long fflags_from_resource(struct rdt_resource *r)
return WARN_ON_ONCE(1);
}
+static int resctrl_ctrl_mb_mode_show(struct kernfs_open_file *of,
+ struct seq_file *seq, void *v)
+{
+ struct rdt_resource_final *f = rdt_kn_parent_priv(of->kn);
+ struct rdt_resource *r = f->res;
+
+ guard(mutex)(&rdtgroup_mutex);
+
+ switch (r->mode) {
+ case RESCTRL_CTRL_LEGACY:
+ seq_puts(seq, "[legacy] native\n");
+ break;
+ case RESCTRL_CTRL_NATIVE:
+ seq_puts(seq, "legacy [native]\n");
+ break;
+ default:
+ WARN_ONCE(1, "%s: unexpected MB control mode %d\n",
+ f->name, r->mode);
+ seq_puts(seq, "legacy native\n");
+ break;
+ }
+
+ return 0;
+}
+
+static struct rftype resctrl_ctrl_mb_files[] = {
+ {
+ .name = "mode",
+ .mode = 0444,
+ .kf_ops = &rdtgroup_kf_single_ops,
+ .seq_show = resctrl_ctrl_mb_mode_show,
+ /*
+ * Directory-level file, not per-control: fflags is only a
+ * presence flag here, not the BIT(ctrl->type) type filter used
+ * by resctrl_add_ctrl_files().
+ */
+ .fflags = 1,
+ }
+};
+
+static int resctrl_ctrl_add_files(struct kernfs_node *kn)
+{
+ struct rftype *rfts, *rft;
+ int ret, len;
+
+ rfts = resctrl_ctrl_mb_files;
+ len = ARRAY_SIZE(resctrl_ctrl_mb_files);
+
+ lockdep_assert_held(&rdtgroup_mutex);
+
+ for (rft = rfts; rft < rfts + len; rft++) {
+ if (rft->fflags) {
+ ret = rdtgroup_add_file(kn, rft);
+ if (ret)
+ goto error;
+ }
+ }
+
+ return 0;
+error:
+ pr_warn("Failed to add %s, err=%d\n", rft->name, ret);
+ while (--rft >= rfts) {
+ if (rft->fflags)
+ kernfs_remove_by_name(kn, rft->name);
+ }
+ return ret;
+}
+
/*
* No need to cleanup on exit - caller calls the recursive kernfs_remove()
* on failure.
@@ -2704,11 +2772,12 @@ static int resctrl_mkdir_schemata_dir(struct kernfs_node *kn,
struct rdt_resource_final *f)
{
struct kernfs_node *kn_subdir, *kn_ctrl;
+ struct rdt_resource *r = f->res;
struct resctrl_ctrl *ctrl;
char ctrl_full_name[20];
int ret;
- kn_subdir = kernfs_create_dir(kn, "resource_schemata", kn->mode, NULL);
+ kn_subdir = kernfs_create_dir(kn, "resource_schemata", kn->mode, f);
if (IS_ERR(kn_subdir))
return PTR_ERR(kn_subdir);
@@ -2716,6 +2785,12 @@ static int resctrl_mkdir_schemata_dir(struct kernfs_node *kn,
if (ret)
return ret;
+ if (r->mode) {
+ ret = resctrl_ctrl_add_files(kn_subdir);
+ if (ret)
+ return ret;
+ }
+
for_each_resource_ctrl(ctrl, f->res) {
ret = snprintf(ctrl_full_name, sizeof(ctrl_full_name), "%s%s%s",
f->name, resctrl_ctrl_is_default(ctrl) ? "" : "_",
diff --git a/include/linux/resctrl.h b/include/linux/resctrl.h
index 72fb7256270e..4fc41e269d0b 100644
--- a/include/linux/resctrl.h
+++ b/include/linux/resctrl.h
@@ -257,6 +257,16 @@ enum resctrl_ctrl_unit {
RESCTRL_CTRL_UNIT_GBPS,
};
+enum resctrl_ctrl_mode {
+ /*
+ * Default (zero) value: the resource does not support control
+ * emulation, so no resource_schemata/mode file is created for it.
+ */
+ RESCTRL_CTRL_MODE_NONE = 0,
+ RESCTRL_CTRL_LEGACY,
+ RESCTRL_CTRL_NATIVE,
+};
+
/**
* struct resctrl_membw - Memory bandwidth allocation related data
* @min_bw: Minimum memory bandwidth percentage user can request
@@ -399,6 +409,12 @@ struct resctrl_ctrl {
* different memory bandwidths
* @cache_io_alloc_capable:True if portion of the cache can be configured
* for I/O traffic.
+ * @mode: Control emulation mode for this resource.
+ * RESCTRL_CTRL_MODE_NONE if the resource does not support
+ * emulation. "legacy": keep the legacy MB control,
+ * emulating it with a native control when it has no MBW
+ * hardware of its own. "native": expose native controls
+ * directly with no emulation.
* @controls: List of controls of an alloc_capable resource
*/
struct rdt_resource {
@@ -413,6 +429,7 @@ struct rdt_resource {
bool bw_delay_linear;
enum membw_throttle_mode bw_throttle_mode;
bool cache_io_alloc_capable;
+ enum resctrl_ctrl_mode mode;
struct list_head controls;
};
--
2.43.0
next prev parent reply other threads:[~2026-07-16 21:04 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-16 21:02 [PATCH RFC 00/23] resctrl: MBA control emulation and ARM MPAM MB_NODE support Fenghua Yu
2026-07-16 21:02 ` [PATCH 01/23] resctrl: Fix ownership of resource_schemata control subdirectories Fenghua Yu
2026-07-16 21:02 ` [PATCH 02/23] arm_mpam: Fix NULL address access issue Fenghua Yu
2026-07-16 21:02 ` Fenghua Yu [this message]
2026-07-16 21:02 ` [PATCH 04/23] resctrl: Expose per-control status in resource_schemata Fenghua Yu
2026-07-16 21:02 ` [PATCH 05/23] resctrl: Add nested resource_schemata support for emulated controls Fenghua Yu
2026-07-16 21:02 ` [PATCH 06/23] resctrl: Mirror schemata for controls without MBW hardware Fenghua Yu
2026-07-16 21:02 ` [PATCH 07/23] resctrl: Rebuild resource_schemata subdirs on MBA mode change Fenghua Yu
2026-07-16 21:02 ` [PATCH 08/23] Documentation: resctrl: document MBA control emulation Fenghua Yu
2026-07-16 21:02 ` [PATCH 09/23] resctrl: De-hardcode L3 monitor infrastructure Fenghua Yu
2026-07-16 21:03 ` [PATCH 10/23] resctrl: Expose MBA MBM counter assignment sysfs Fenghua Yu
2026-07-16 21:03 ` [PATCH 11/23] resctrl: name node-scoped monitor domains mon_NODE_<id> Fenghua Yu
2026-07-16 21:03 ` [PATCH 12/23] resctrl: Add node-scope MBM total event Fenghua Yu
2026-07-16 21:03 ` [PATCH 13/23] resctrl: Make MBM paths resource-aware Fenghua Yu
2026-07-16 21:03 ` [PATCH 14/23] arm_mpam: Support memory-level MSCs and ABMC per class Fenghua Yu
2026-07-16 21:03 ` [PATCH 15/23] arm_mpam: Refine L3 topology and class selection Fenghua Yu
2026-07-16 21:03 ` [PATCH 16/23] arm_mpam: Include all MSC components during domain setup Fenghua Yu
2026-07-16 21:03 ` [PATCH 17/23] arm_mpam: Handle CPU-less numa nodes Fenghua Yu
2026-07-16 21:03 ` [PATCH 18/23] arm_mpam: Emulate MB control with node-scoped MB_NODE control Fenghua Yu
2026-07-16 21:03 ` [PATCH 19/23] Documentation: arm64: mpam: document memory-level MB control and NUMA nodes Fenghua Yu
2026-07-16 21:03 ` [PATCH 20/23] Documentation: resctrl: document NODE-scoped MBA domains and mon_NODE monitoring Fenghua Yu
2026-07-16 21:03 ` [PATCH 21/23] Documentation: resctrl: document MB_NODE emulation example on ARM MPAM Fenghua Yu
2026-07-16 21:03 ` [PATCH 22/23] arm_mpam: Add KUnit test for CPU-less NUMA node affinity Fenghua Yu
2026-07-16 21:03 ` [PATCH 23/23] selftests/resctrl: Add MB emulation test for ARM MPAM Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260716210329.2914625-3-fenghuay@nvidia.com \
--to=fenghuay@nvidia.com \
--cc=Dave.Martin@arm.com \
--cc=babu.moger@amd.com \
--cc=ben.horgan@arm.com \
--cc=fustini@kernel.org \
--cc=gshan@redhat.com \
--cc=james.morse@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=newtonl@nvidia.com \
--cc=reinette.chatre@intel.com \
--cc=sdonthineni@nvidia.com \
--cc=tan.shaopeng@fujitsu.com \
--cc=tony.luck@intel.com \
--cc=vsethi@nvidia.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox