Re: [RFC PATCH v2 38/45] arm64: smp: Abstract SGI and LPI operations

[Vladimir Murzin <vladimir.murzin@arm.com>]

On 8/29/26 04:47, Jinjie Ruan wrote:
> 
> 在 2026/8/13 16:01, Jinjie Ruan 写道:
>>
>> 在 2026/7/28 0:34, Vladimir Murzin 写道:
>>> SGI and LPI backed IPIs require different setup, enable, disable and
>>> send operations. These differences are currently handled by repeatedly
>>> checking percpu_ipi_descs. As the implementation specific logic grows,
>>> these checks make the common IPI code increasingly difficult to
>>> follow.
>>>
>>> Introduce an operations structure for each implementation to
>>> encapsulate the specific of SGI and LPI handling, leaving the common
>>> IPI paths generic.
>>>
>>> Signed-off-by: Vladimir Murzin <vladimir.murzin@arm.com>
>>> ---
>>>  arch/arm64/kernel/smp.c | 163 +++++++++++++++++++++++++---------------
>>>  1 file changed, 101 insertions(+), 62 deletions(-)
>> Hi, Vladimir,
>>
>> I believe that the modifications here do not need to be so extensive. By
>> maintaining the order of the related function definitions consistent
>> with the original, the changes can be reduced to only 126 lines, and the
>> modifications will be easier to review.

Hi Jinjie,

> Hi, Vladimir,
> 
> What do you think?

I think that perhaps we should pay more attention to the end result after
applying the patch. However, I understand why diff looks like that and
amount of work required to shrink it is close to zero, so in next version
stat would look like

 arch/arm64/kernel/smp.c | 135 ++++++++++++++++++++++++++--------------
 1 file changed, 88 insertions(+), 47 deletions(-)

Cheers
Vladimir