From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: linux-aspeed@lists.ozlabs.org
Subject: [PATCH v3 08/14] ARM: dts: aspeed: yosemite4: Revise i2c11 and i2c12 schematic change
Date: Wed, 13 Dec 2023 08:20:25 +0100 [thread overview]
Message-ID: <ae52b0d3-84a4-4c78-97e0-e5b479b54f16@linaro.org> (raw)
In-Reply-To: <20231211054730.208588-9-Delphine_CC_Chiu@wiwynn.com>
On 11/12/2023 06:47, Delphine CC Chiu wrote:
> Revise i2c11 and i2c12 schematic change:
> - remove space for adm1272 compatible
> - enable interrupt setting for pca9555
> - add eeprom for yosemite4 medusa board/BSM use
> - remove temperature sensor for yosemite4 schematic change
> - add power sensor for power module reading
Way too many changes in one patch. Especially mixing fixes and new
features is bad. Please don't.
>
> Signed-off-by: Delphine CC Chiu <Delphine_CC_Chiu@wiwynn.com>
> ---
> .../aspeed/aspeed-bmc-facebook-yosemite4.dts | 118 ++++++++++++++----
> 1 file changed, 93 insertions(+), 25 deletions(-)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> index da413325ce30..ccb5ecd8d9a6 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-facebook-yosemite4.dts
> @@ -821,41 +821,94 @@ imux29: i2c at 1 {
> &i2c11 {
> status = "okay";
> power-sensor at 10 {
> - compatible = "adi, adm1272";
> + compatible = "adi,adm1272";
> reg = <0x10>;
> };
>
> power-sensor at 12 {
> - compatible = "adi, adm1272";
> + compatible = "adi,adm1272";
> reg = <0x12>;
> };
>
> - gpio at 20 {
> + gpio_ext1: pca9555 at 20 {
That's wrong name.
> compatible = "nxp,pca9555";
> - reg = <0x20>;
> + pinctrl-names = "default";
> gpio-controller;
> #gpio-cells = <2>;
> - };
> -
> - gpio at 21 {
> + reg = <0x20>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <94 IRQ_TYPE_LEVEL_LOW>;
> + gpio-line-names =
> + "P48V_OCP_GPIO1","P48V_OCP_GPIO2",
> + "P48V_OCP_GPIO3","FAN_BOARD_0_REVISION_0_R",
> + "FAN_BOARD_0_REVISION_1_R","FAN_BOARD_1_REVISION_0_R",
> + "FAN_BOARD_1_REVISION_1_R","RST_MUX_R_N",
> + "RST_LED_CONTROL_FAN_BOARD_0_N","RST_LED_CONTROL_FAN_BOARD_1_N",
> + "RST_IOEXP_FAN_BOARD_0_N","RST_IOEXP_FAN_BOARD_1_N",
> + "PWRGD_LOAD_SWITCH_FAN_BOARD_0_R","PWRGD_LOAD_SWITCH_FAN_BOARD_1_R",
> + "","";
> + };
> +
> + gpio_ext2: pca9555 at 21 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
> compatible = "nxp,pca9555";
> - reg = <0x21>;
> + pinctrl-names = "default";
> gpio-controller;
> #gpio-cells = <2>;
> - };
> -
> - gpio at 22 {
> + reg = <0x21>;
> + interrupt-parent = <&gpio0>;
> + interrupts = <94 IRQ_TYPE_LEVEL_LOW>;
> + gpio-line-names =
> + "DELTA_MODULE_TYPE","VSENSE_ERR_VDROP_R",
> + "EN_P48V_AUX_0","EN_P48V_AUX_1",
> + "MEDUSA_BOARD_REV_0","MEDUSA_BOARD_REV_1",
> + "MEDUSA_BOARD_REV_2","MEDUSA_BOARD_TYPE",
> + "HSC_OCP_SLOT_ODD_GPIO1","HSC_OCP_SLOT_ODD_GPIO2",
> + "HSC_OCP_SLOT_ODD_GPIO3","HSC_OCP_SLOT_EVEN_GPIO1",
> + "HSC_OCP_SLOT_EVEN_GPIO2","HSC_OCP_SLOT_EVEN_GPIO3",
> + "ADC_TYPE_0_R","ADC_TYPE_1_R";
> + };
> +
> + gpio_ext3: pca9555 at 22 {
Please fix it everywhere.
In this patch and all your future patches. I keep repeating the same
feedback...
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-13 7:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 5:47 [PATCH v3 00/14] Add i2c-mux and eeprom devices for Meta Yosemite 4 Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 01/14] ARM: dts: aspeed: yosemite4: Revise i2c-mux devices Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 02/14] ARM: dts: aspeed: yosemite4: Enable adc15 Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 03/14] ARM: dts: aspeed: yosemite4: Enable spi-gpio setting Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 04/14] ARM: dts: aspeed: yosemite4: Enable watchdog2 Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 05/14] ARM: dts: aspeed: yosemite4: Revise quad mode to dual mode Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 06/14] ARM: dts: aspeed: yosemite4: Revise power sensor adm1281 for schematic change Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 07/14] ARM: dts: aspeed: yosemite4: Add gpio pca9506 Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 08/14] ARM: dts: aspeed: yosemite4: Revise i2c11 and i2c12 schematic change Delphine CC Chiu
2023-12-13 7:20 ` Krzysztof Kozlowski [this message]
2023-12-11 5:47 ` [PATCH v3 09/14] ARM: dts: aspeed: yosemite4: Revise i2c14 and i2c15 " Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 10/14] ARM: dts: aspeed: yosemite4: Initialize bmc gpio state Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 11/14] ARM: dts: aspeed: yosemite4: Revise mx31790 fan tach config Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 12/14] ARM: dts: aspeed: yosemite4: add mctp config for NIC Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 13/14] ARM: dts: aspeed: yosemite4: support mux to cpld Delphine CC Chiu
2023-12-11 5:47 ` [PATCH v3 14/14] ARM: dts: aspeed: yosemite4: Revise gpio name Delphine CC Chiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae52b0d3-84a4-4c78-97e0-e5b479b54f16@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=linux-aspeed@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox