[PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

The Nokia devices require the setup of its Public Bluetooth Device
Address and for that it is required to depend on vendor specific
commands. For Broadcom based Nokia devices, that is part of btbcm
module and can be selected via BT_BCM config option.

Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
---
 drivers/bluetooth/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
index 35952a94875e..3a6ead603e49 100644
--- a/drivers/bluetooth/Kconfig
+++ b/drivers/bluetooth/Kconfig
@@ -98,6 +98,7 @@ config BT_HCIUART_NOKIA
 	depends on BT_HCIUART_SERDEV
 	depends on PM
 	select BT_HCIUART_H4
+	select BT_BCM
 	help
 	  Nokia H4+ is serial protocol for communication between Bluetooth
 	  device and host. This protocol is required for Bluetooth devices
-- 
2.13.3

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]

Hi,

On Sat, Jul 22, 2017 at 11:57:47AM +0200, Marcel Holtmann wrote:
> The Nokia devices require the setup of its Public Bluetooth Device
> Address and for that it is required to depend on vendor specific
> commands. For Broadcom based Nokia devices, that is part of btbcm
> module and can be selected via BT_BCM config option.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>

Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

-- Sebastian

> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bluetooth/Kconfig b/drivers/bluetooth/Kconfig
> index 35952a94875e..3a6ead603e49 100644
> --- a/drivers/bluetooth/Kconfig
> +++ b/drivers/bluetooth/Kconfig
> @@ -98,6 +98,7 @@ config BT_HCIUART_NOKIA
>  	depends on BT_HCIUART_SERDEV
>  	depends on PM
>  	select BT_HCIUART_H4
> +	select BT_BCM
>  	help
>  	  Nokia H4+ is serial protocol for communication between Bluetooth
>  	  device and host. This protocol is required for Bluetooth devices
> -- 
> 2.13.3
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

Hi Sebastian,

>> The Nokia devices require the setup of its Public Bluetooth Device
>> Address and for that it is required to depend on vendor specific
>> commands. For Broadcom based Nokia devices, that is part of btbcm
>> module and can be selected via BT_BCM config option.
>> 
>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> 
> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

btw. we need to also provide the set_bdaddr for TI chips.

Regards

Marcel

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 805 bytes --]

Hi,

On Sat, Jul 22, 2017 at 09:08:15PM +0200, Marcel Holtmann wrote:
> >> The Nokia devices require the setup of its Public Bluetooth Device
> >> Address and for that it is required to depend on vendor specific
> >> commands. For Broadcom based Nokia devices, that is part of btbcm
> >> module and can be selected via BT_BCM config option.
> >> 
> >> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> > 
> > Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> 
> btw. we need to also provide the set_bdaddr for TI chips.

The TI based chip in Nokia N950 has a proper address configured, so
it works without set_bdaddr (it would still be nice of course). It
also seems to be missing for hci_ll, though. So the required command
is completly unknown?

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

Hi Sebastian,

>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>> Address and for that it is required to depend on vendor specific
>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>> module and can be selected via BT_BCM config option.
>>>> 
>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>> 
>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> 
>> btw. we need to also provide the set_bdaddr for TI chips.
> 
> The TI based chip in Nokia N950 has a proper address configured, so
> it works without set_bdaddr (it would still be nice of course). It
> also seems to be missing for hci_ll, though. So the required command
> is completly unknown?

are these a TI address or a Nokia address? I doubt Nokia would have actually shipped any hardware using an IEEE assigned address to TI.

Where do we have the firmware files for the Nokia devices? Don't they contain a command for setting the BD_ADDR. Also the original Nokia driver had code to re-write that command inline while loading the firmware.

Regards

Marcel

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

Hi Sebastian,

>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>> Address and for that it is required to depend on vendor specific
>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>> module and can be selected via BT_BCM config option.
>>>> 
>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>> 
>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>> 
>> btw. we need to also provide the set_bdaddr for TI chips.
> 
> The TI based chip in Nokia N950 has a proper address configured, so
> it works without set_bdaddr (it would still be nice of course). It
> also seems to be missing for hci_ll, though. So the required command
> is completly unknown?

actually a bunch of the TI HCI vendor command documents are public. We just need to figure out which one does the job. For the WiLink it is HCI_VS_Write_BD_Addr (0xFC06) which just takes the BD_ADDR as parameter.

Regards

Marcel

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1839 bytes --]

Hi,

On Sun, Jul 23, 2017 at 09:32:23AM +0200, Marcel Holtmann wrote:
> >>>> The Nokia devices require the setup of its Public Bluetooth Device
> >>>> Address and for that it is required to depend on vendor specific
> >>>> commands. For Broadcom based Nokia devices, that is part of btbcm
> >>>> module and can be selected via BT_BCM config option.
> >>>> 
> >>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> >>> 
> >>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> >> 
> >> btw. we need to also provide the set_bdaddr for TI chips.
> > 
> > The TI based chip in Nokia N950 has a proper address configured, so
> > it works without set_bdaddr (it would still be nice of course). It
> > also seems to be missing for hci_ll, though. So the required command
> > is completly unknown?
> 
> are these a TI address or a Nokia address? I doubt Nokia would
> have actually shipped any hardware using an IEEE assigned address
> to TI.

I can check this later.

> Where do we have the firmware files for the Nokia devices?

For N950 I extracted it out of the following rpm:

http://repo.merproject.org/obs/nemo:/devel:/hw:/ti:/omap3:/n950-n9/latest_armv7hl/src/ti-wl1273-bt-firmware-0.23-1.2.Nemo.Adaptation.N950.N9.src.rpm

> Don't they contain a command for setting the BD_ADDR.

I did not check, since the firmware file is not device
specific as far as I know.

> Also the original Nokia driver had code to re-write that command
> inline while loading the firmware.

The address injection happens in hardware specific code (stock driver
supports TI, Broadcom & CSR). In opposit to Broadcom and CSR the TI
specific one does not change the address:

https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/drivers/bluetooth/hci_h4p/fw-ti1273.c

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 1273 bytes --]

Hi,

On Mon, Jul 24, 2017 at 12:23:57PM +0200, Sebastian Reichel wrote:
> On Sun, Jul 23, 2017 at 09:32:23AM +0200, Marcel Holtmann wrote:
> > >>>> The Nokia devices require the setup of its Public Bluetooth Device
> > >>>> Address and for that it is required to depend on vendor specific
> > >>>> commands. For Broadcom based Nokia devices, that is part of btbcm
> > >>>> module and can be selected via BT_BCM config option.
> > >>>> 
> > >>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> > >>> 
> > >>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> > >> 
> > >> btw. we need to also provide the set_bdaddr for TI chips.
> > > 
> > > The TI based chip in Nokia N950 has a proper address configured, so
> > > it works without set_bdaddr (it would still be nice of course). It
> > > also seems to be missing for hci_ll, though. So the required command
> > > is completly unknown?
> > 
> > are these a TI address or a Nokia address? I doubt Nokia would
> > have actually shipped any hardware using an IEEE assigned address
> > to TI.
> 
> I can check this later.

The BD address on my N950 starts with B4:EE:D4, which belongs
to TI as far as I can see. Note, that N950 is a developer only
device.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

Hi Sebastian,

>>>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>>>> Address and for that it is required to depend on vendor specific
>>>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>>>> module and can be selected via BT_BCM config option.
>>>>>> 
>>>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>>>> 
>>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>>>> 
>>>> btw. we need to also provide the set_bdaddr for TI chips.
>>> 
>>> The TI based chip in Nokia N950 has a proper address configured, so
>>> it works without set_bdaddr (it would still be nice of course). It
>>> also seems to be missing for hci_ll, though. So the required command
>>> is completly unknown?
>> 
>> are these a TI address or a Nokia address? I doubt Nokia would
>> have actually shipped any hardware using an IEEE assigned address
>> to TI.
> 
> I can check this later.
> 
>> Where do we have the firmware files for the Nokia devices?
> 
> For N950 I extracted it out of the following rpm:
> 
> http://repo.merproject.org/obs/nemo:/devel:/hw:/ti:/omap3:/n950-n9/latest_armv7hl/src/ti-wl1273-bt-firmware-0.23-1.2.Nemo.Adaptation.N950.N9.src.rpm
> 
>> Don't they contain a command for setting the BD_ADDR.
> 
> I did not check, since the firmware file is not device
> specific as far as I know.

doen't matter since the old Nokia written driver hacked it from a sysfs file and the address came from the secure flash area.

>> Also the original Nokia driver had code to re-write that command
>> inline while loading the firmware.
> 
> The address injection happens in hardware specific code (stock driver
> supports TI, Broadcom & CSR). In opposit to Broadcom and CSR the TI
> specific one does not change the address:
> 
> https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/drivers/bluetooth/hci_h4p/fw-ti1273.c

As far as I know they rewrite the Write BD_ADDR command of each vendor at the time before they send to the hardware.

Regards

Marcel

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Marcel Holtmann]

Hi Sebastian,

>>>>>>> The Nokia devices require the setup of its Public Bluetooth Device
>>>>>>> Address and for that it is required to depend on vendor specific
>>>>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
>>>>>>> module and can be selected via BT_BCM config option.
>>>>>>> 
>>>>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
>>>>>> 
>>>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
>>>>> 
>>>>> btw. we need to also provide the set_bdaddr for TI chips.
>>>> 
>>>> The TI based chip in Nokia N950 has a proper address configured, so
>>>> it works without set_bdaddr (it would still be nice of course). It
>>>> also seems to be missing for hci_ll, though. So the required command
>>>> is completly unknown?
>>> 
>>> are these a TI address or a Nokia address? I doubt Nokia would
>>> have actually shipped any hardware using an IEEE assigned address
>>> to TI.
>> 
>> I can check this later.
> 
> The BD address on my N950 starts with B4:EE:D4, which belongs
> to TI as far as I can see. Note, that N950 is a developer only
> device.

as long as not every N950 now has the same address. But I think if Nokia would have shipped the device then it would have had to be a Nokia address.

Regards

Marcel

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 3083 bytes --]

Hi,

On Mon, Jul 24, 2017 at 07:09:08PM +0200, Marcel Holtmann wrote:
> >>>>>> The Nokia devices require the setup of its Public Bluetooth Device
> >>>>>> Address and for that it is required to depend on vendor specific
> >>>>>> commands. For Broadcom based Nokia devices, that is part of btbcm
> >>>>>> module and can be selected via BT_BCM config option.
> >>>>>> 
> >>>>>> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> >>>>> 
> >>>>> Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
> >>>> 
> >>>> btw. we need to also provide the set_bdaddr for TI chips.
> >>> 
> >>> The TI based chip in Nokia N950 has a proper address configured, so
> >>> it works without set_bdaddr (it would still be nice of course). It
> >>> also seems to be missing for hci_ll, though. So the required command
> >>> is completly unknown?
> >> 
> >> are these a TI address or a Nokia address? I doubt Nokia would
> >> have actually shipped any hardware using an IEEE assigned address
> >> to TI.
> > 
> > I can check this later.
> > 
> >> Where do we have the firmware files for the Nokia devices?
> > 
> > For N950 I extracted it out of the following rpm:
> > 
> > http://repo.merproject.org/obs/nemo:/devel:/hw:/ti:/omap3:/n950-n9/latest_armv7hl/src/ti-wl1273-bt-firmware-0.23-1.2.Nemo.Adaptation.N950.N9.src.rpm
> > 
> >> Don't they contain a command for setting the BD_ADDR.
> > 
> > I did not check, since the firmware file is not device
> > specific as far as I know.
> 
> doen't matter since the old Nokia written driver hacked it from a
> sysfs file and the address came from the secure flash area.

The sysfs "just" puts the address into platform_data for their h4p
driver. It does not take care of applying it to the hardware. That
is the job of their h4p driver. Here is the code for the sysfs file:

https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/arch/arm/mach-omap2/board-omap-bt.c

> >> Also the original Nokia driver had code to re-write that command
> >> inline while loading the firmware.
> > 
> > The address injection happens in hardware specific code (stock driver
> > supports TI, Broadcom & CSR). In opposit to Broadcom and CSR the TI
> > specific one does not change the address:
> > 
> > https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/drivers/bluetooth/hci_h4p/fw-ti1273.c
> 
> As far as I know they rewrite the Write BD_ADDR command of each
> vendor at the time before they send to the hardware.

You can clearly see that they modify the address in the hardware
specific firmware files for Broadcom and CSR:

https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/drivers/bluetooth/hci_h4p/fw-bcm.c
https://github.com/nemomobile/kernel-adaptation-n950-n9/blob/master/drivers/bluetooth/hci_h4p/fw-csr.c

But there is no such code for TI (except for a comment):

/* Check if this is bd_address packet */

I think they just forgot to implement it and since the
comment has no XXX/TODO/FIXME prefix nobody noticed it.

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH] Bluetooth: hci_nokia: select BT_BCM for btbcm_set_bdaddr()

[Johan Hedberg]

Hi Marcel,

On Sat, Jul 22, 2017, Marcel Holtmann wrote:
> The Nokia devices require the setup of its Public Bluetooth Device
> Address and for that it is required to depend on vendor specific
> commands. For Broadcom based Nokia devices, that is part of btbcm
> module and can be selected via BT_BCM config option.
> 
> Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> ---
>  drivers/bluetooth/Kconfig | 1 +
>  1 file changed, 1 insertion(+)

Applied to bluetooth-next. Thanks.

Johan