From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
Marc Kleine-Budde <mkl@pengutronix.de>,
linux-can@vger.kernel.org
Subject: Re: [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
Date: Wed, 25 Jun 2025 08:03:09 +0900 [thread overview]
Message-ID: <0cc46642-e13a-49d6-8280-9ed378dd2e62@wanadoo.fr> (raw)
In-Reply-To: <8b6c8271-c3b5-4950-abb4-5888c3d4c67f@web.de>
On 25/06/2025 at 04:21, Markus Elfring wrote:
>>> +++ b/drivers/net/can/usb/ucan.c
>>> @@ -1353,16 +1353,14 @@ static int ucan_probe(struct usb_interface *intf,
>>> ep = &iface_desc->endpoint[i].desc;
>>>
>>> if (((ep->bEndpointAddress & USB_ENDPOINT_DIR_MASK) != 0) &&
>> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>> This is:
>>
>> usb_endpoint_dir_in(ep)
>
> Can the check for a single value like “USB_DIR_IN” be really mapped to
> an other value range?
> https://elixir.bootlin.com/linux/v6.16-rc3/source/include/uapi/linux/usb/ch9.h#L495-L503
Look at the actual values of USB_ENDPOINT_DIR_MASK and USB_DIR_IN ;)
Yours sincerely,
Vincent Mailhol
prev parent reply other threads:[~2025-06-24 23:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 17:12 [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 17:29 ` Vincent Mailhol
2025-06-24 18:28 ` Markus Elfring
2025-06-24 22:59 ` Vincent Mailhol
2025-06-25 5:47 ` [PATCH] " Markus Elfring
2025-06-25 15:51 ` Vincent Mailhol
2025-06-25 16:23 ` Markus Elfring
2025-06-26 2:47 ` Vincent Mailhol
2025-06-26 7:22 ` Markus Elfring
2025-06-26 9:23 ` Vincent Mailhol
2025-06-26 14:46 ` [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations Markus Elfring
2025-06-26 14:50 ` Vincent Mailhol
2025-06-26 15:06 ` Marc Kleine-Budde
2025-06-26 15:17 ` [v2] " Markus Elfring
2025-06-24 19:21 ` [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 23:03 ` Vincent Mailhol [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cc46642-e13a-49d6-8280-9ed378dd2e62@wanadoo.fr \
--to=mailhol.vincent@wanadoo.fr \
--cc=Markus.Elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox