Linux CAN drivers development
 help / color / mirror / Atom feed
From: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
To: Markus Elfring <Markus.Elfring@web.de>
Cc: LKML <linux-kernel@vger.kernel.org>,
	kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
	linux-can@vger.kernel.org, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations
Date: Thu, 26 Jun 2025 23:50:40 +0900	[thread overview]
Message-ID: <4af1102c-a5b6-4d9b-af8d-2c5f721b845e@wanadoo.fr> (raw)
In-Reply-To: <e70a929f-a5c5-487e-9231-61b5423115db@web.de>

Hi Markus,

Thanks for the v2.

On 26/06/2025 at 23:46, Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Thu, 26 Jun 2025 16:34:26 +0200
> 
> * Reuse existing functionality from usb_endpoint_is_bulk_in()
>   and usb_endpoint_is_bulk_out() instead of keeping duplicate source code.
> 
> * Omit two comment lines which became redundant with this refactoring.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>

Reviewed-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>


Yours sincerely,
Vincent Mailhol


  reply	other threads:[~2025-06-26 14:50 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-24 17:12 [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 17:29 ` Vincent Mailhol
2025-06-24 18:28   ` Markus Elfring
2025-06-24 22:59     ` Vincent Mailhol
2025-06-25  5:47       ` [PATCH] " Markus Elfring
2025-06-25 15:51         ` Vincent Mailhol
2025-06-25 16:23           ` Markus Elfring
2025-06-26  2:47             ` Vincent Mailhol
2025-06-26  7:22               ` Markus Elfring
2025-06-26  9:23                 ` Vincent Mailhol
2025-06-26 14:46                   ` [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations Markus Elfring
2025-06-26 14:50                     ` Vincent Mailhol [this message]
2025-06-26 15:06                     ` Marc Kleine-Budde
2025-06-26 15:17                       ` [v2] " Markus Elfring
2025-06-24 19:21   ` [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 23:03     ` Vincent Mailhol

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4af1102c-a5b6-4d9b-af8d-2c5f721b845e@wanadoo.fr \
    --to=mailhol.vincent@wanadoo.fr \
    --cc=Markus.Elfring@web.de \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkl@pengutronix.de \
    --cc=nichen@iscas.ac.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox