From: Markus Elfring <Markus.Elfring@web.de>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>, linux-can@vger.kernel.org
Cc: LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org, Chen Ni <nichen@iscas.ac.cn>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: Re: can: ucan: Use usb_endpoint_type() rather than duplicating its implementation
Date: Thu, 26 Jun 2025 09:22:17 +0200 [thread overview]
Message-ID: <1e64bcef-33f1-4295-b91f-d4598b32b866@web.de> (raw)
In-Reply-To: <CAMZ6Rq+PEZWzxNYDODq-Rz_Y8T_XEihyZKoY-MYo6bn5ATaGLQ@mail.gmail.com>
>> I am unsure if the check reordering would be desirable for this function implementation.
>
> Ah, you want to confirm whether
>
> usb_endpoint_dir_in(ep) && usb_endpoint_xfer_bulk(ep)
>
> is the same as
>
> usb_endpoint_xfer_bulk(ep) && usb_endpoint_dir_in(ep)
>
> ?
Exactly, yes.
Commutativity can probably be applied in this case.
But the different execution order will influence the corresponding run time characteristics.
https://en.wikipedia.org/wiki/Short-circuit_evaluation
https://en.wikipedia.org/wiki/Commutative_property
The data processing order from known API function implementations might get priority
also at discussed source code places in the near future.
Regards,
Markus
next prev parent reply other threads:[~2025-06-26 7:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 17:12 [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 17:29 ` Vincent Mailhol
2025-06-24 18:28 ` Markus Elfring
2025-06-24 22:59 ` Vincent Mailhol
2025-06-25 5:47 ` [PATCH] " Markus Elfring
2025-06-25 15:51 ` Vincent Mailhol
2025-06-25 16:23 ` Markus Elfring
2025-06-26 2:47 ` Vincent Mailhol
2025-06-26 7:22 ` Markus Elfring [this message]
2025-06-26 9:23 ` Vincent Mailhol
2025-06-26 14:46 ` [PATCH v2] can: ucan: Use two USB endpoint API functions rather than duplicating their implementations Markus Elfring
2025-06-26 14:50 ` Vincent Mailhol
2025-06-26 15:06 ` Marc Kleine-Budde
2025-06-26 15:17 ` [v2] " Markus Elfring
2025-06-24 19:21 ` [PATCH] can: ucan: Use usb_endpoint_type() rather than duplicating its implementation Markus Elfring
2025-06-24 23:03 ` Vincent Mailhol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1e64bcef-33f1-4295-b91f-d4598b32b866@web.de \
--to=markus.elfring@web.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mkl@pengutronix.de \
--cc=nichen@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox