From: neil.armstrong@linaro.org
To: Jagadeesh Kona <quic_jkona@quicinc.com>,
Bjorn Andersson <andersson@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Dmitry Baryshkov <lumag@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v5 00/18] clk: qcom: Add support to attach multiple power domains in cc probe
Date: Tue, 29 Jul 2025 16:49:44 +0200 [thread overview]
Message-ID: <8e56e1a8-7b26-44df-ad57-e2092cb5c9ab@linaro.org> (raw)
In-Reply-To: <20250530-videocc-pll-multi-pd-voting-v5-0-02303b3a582d@quicinc.com>
Hi,
On 30/05/2025 15:20, Jagadeesh Kona wrote:
> In recent QCOM chipsets, PLLs require more than one power domain to be
> kept ON to configure the PLL. But the current code doesn't enable all
> the required power domains while configuring the PLLs, this leads to
> functional issues due to suboptimal settings of PLLs.
>
> To address this, add support for handling runtime power management,
> configuring plls and enabling critical clocks from qcom_cc_really_probe.
> The clock controller can specify PLLs, critical clocks, and runtime PM
> requirements using the descriptor data. The code in qcom_cc_really_probe()
> ensures all necessary power domains are enabled before configuring PLLs
> or critical clocks.
>
> This series fixes the below warning reported in SM8550 venus testing due
> to video_cc_pll0 not properly getting configured during videocc probe
>
> [ 46.535132] Lucid PLL latch failed. Output may be unstable!
>
> The patch adding support to configure the PLLs from common code is
> picked from below series and updated it.
> https://lore.kernel.org/all/20250113-support-pll-reconfigure-v1-0-1fae6bc1062d@quicinc.com/
>
> This series is dependent on bindings patch in below Vladimir's series, hence
> included the Vladimir's series patches also in this series and updated them.
> https://lore.kernel.org/all/20250303225521.1780611-1-vladimir.zapolskiy@linaro.org/
Could you re-spin patches 13 to 18 to fix the bindings checks ?
Thanks,
Neil
<snip>
next prev parent reply other threads:[~2025-07-29 14:49 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-30 13:20 [PATCH v5 00/18] clk: qcom: Add support to attach multiple power domains in cc probe Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 01/18] dt-bindings: clock: qcom,sm8450-videocc: Add MXC power domain Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 02/18] dt-bindings: clock: qcom,sm8450-camcc: Allow to specify two power domains Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 03/18] dt-bindings: clock: qcom,sm8450-camcc: Move sc8280xp camcc to sa8775p camcc Jagadeesh Kona
2025-06-03 7:04 ` Krzysztof Kozlowski
2025-05-30 13:20 ` [PATCH v5 04/18] clk: qcom: clk-alpha-pll: Add support for common PLL configuration function Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 05/18] clk: qcom: common: Handle runtime power management in qcom_cc_really_probe Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 06/18] clk: qcom: common: Add support to configure clk regs " Jagadeesh Kona
2025-05-30 23:00 ` Konrad Dybcio
2025-05-30 13:20 ` [PATCH v5 07/18] clk: qcom: videocc-sm8450: Move PLL & clk configuration to really probe Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 08/18] clk: qcom: videocc-sm8550: " Jagadeesh Kona
2025-05-30 22:57 ` Konrad Dybcio
2025-06-03 8:02 ` Bryan O'Donoghue
2025-05-30 13:20 ` [PATCH v5 09/18] clk: qcom: camcc-sm8450: " Jagadeesh Kona
2025-06-03 8:05 ` Bryan O'Donoghue
2025-05-30 13:20 ` [PATCH v5 10/18] clk: qcom: camcc-sm8550: " Jagadeesh Kona
2025-06-03 8:06 ` Bryan O'Donoghue
2025-05-30 13:20 ` [PATCH v5 11/18] clk: qcom: camcc-sm8650: " Jagadeesh Kona
2025-06-03 8:07 ` Bryan O'Donoghue
2025-05-30 13:20 ` [PATCH v5 12/18] clk: qcom: camcc-x1e80100: " Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 13/18] arm64: dts: qcom: sm8450: Additionally manage MXC power domain in videocc Jagadeesh Kona
2025-05-30 13:20 ` [PATCH v5 14/18] arm64: dts: qcom: sm8550: " Jagadeesh Kona
2025-05-30 13:21 ` [PATCH v5 15/18] arm64: dts: qcom: sm8650: " Jagadeesh Kona
2025-05-30 13:21 ` [PATCH v5 16/18] arm64: dts: qcom: sm8450: Additionally manage MXC power domain in camcc Jagadeesh Kona
2025-06-03 8:08 ` Bryan O'Donoghue
2025-05-30 13:21 ` [PATCH v5 17/18] arm64: dts: qcom: sm8550: " Jagadeesh Kona
2025-06-03 8:09 ` Bryan O'Donoghue
2025-05-30 13:21 ` [PATCH v5 18/18] arm64: dts: qcom: sm8650: " Jagadeesh Kona
2025-06-03 8:09 ` Bryan O'Donoghue
2025-06-03 8:09 ` [PATCH v5 00/18] clk: qcom: Add support to attach multiple power domains in cc probe Bryan O'Donoghue
2025-06-12 4:00 ` (subset) " Bjorn Andersson
2025-06-12 10:03 ` Jagadeesh Kona
2025-06-12 10:52 ` Krzysztof Kozlowski
2025-06-16 7:25 ` Jagadeesh Kona
2025-06-17 13:27 ` Bjorn Andersson
2025-06-17 19:16 ` Jagadeesh Kona
2025-07-29 14:49 ` neil.armstrong [this message]
2025-07-30 9:50 ` Jagadeesh Kona
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8e56e1a8-7b26-44df-ad57-e2092cb5c9ab@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lumag@kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox