From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
To: <linux-cxl@vger.kernel.org>, <linuxarm@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
Ben Widawsky <bwidawsk@kernel.org>
Subject: [PATCH 0/2] cxl: Fix oversized LSA write payload due to header
Date: Mon, 15 Aug 2022 16:40:42 +0100 [thread overview]
Message-ID: <20220815154044.24733-1-Jonathan.Cameron@huawei.com> (raw)
Fix the bug by claiming the payload is smaller by 8 bytes for both
reads and writes. Also add a defensive check to aid catching similar
bugs in future.
Note that two issues also found in QEMU code whilst looking at this
bug. I'll send out fixes for those shortly.
Note that even with these
ndctl create-namespace fails. More debugging underway.
Jonathan Cameron (2):
cxl/mbox: Add a check on input payload size
cxl/pmem: Fix failure to account for 8 byte header for writes to the
device LSA.
drivers/cxl/core/mbox.c | 2 +-
drivers/cxl/pmem.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--
2.32.0
next reply other threads:[~2022-08-15 15:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-15 15:40 Jonathan Cameron [this message]
2022-08-15 15:40 ` [PATCH 1/2] cxl/mbox: Add a check on input payload size Jonathan Cameron
2022-08-15 15:40 ` [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA Jonathan Cameron
2022-08-15 21:55 ` Dan Williams
2022-08-17 11:29 ` Jonathan Cameron
2022-10-10 15:31 ` Jonathan Cameron
2022-10-21 23:31 ` Dan Williams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220815154044.24733-1-Jonathan.Cameron@huawei.com \
--to=jonathan.cameron@huawei.com \
--cc=bwidawsk@kernel.org \
--cc=dan.j.williams@intel.com \
--cc=ira.weiny@intel.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=vishal.l.verma@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox