Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	Dan Williams <dan.j.williams@intel.com>
Cc: <linux-cxl@vger.kernel.org>, <vishal.l.verma@intel.com>,
	<ira.weiny@intel.com>, Ben Widawsky <bwidawsk@kernel.org>
Subject: Re: [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA.
Date: Fri, 21 Oct 2022 16:31:01 -0700	[thread overview]
Message-ID: <63532bb5576c4_4da32942e@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20221010163053.00003207@huawei.com>

Jonathan Cameron wrote:
> On Wed, 17 Aug 2022 12:29:30 +0100
> Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:
> 
> > On Mon, 15 Aug 2022 14:55:42 -0700
> > Dan Williams <dan.j.williams@intel.com> wrote:
> > 
> > > [ apologies if this is a duplicate response ]
> > > 
> > > Jonathan Cameron wrote:  
> > > > Writes to the device must include an offset and size as defined in
> > > > CXL 2.0 8.2.9.5.2.4 Set LSA (Opcode 4103h)
> > > > 
> > > > Fixes tag is non obvious as this code has been through several
> > > > reworks and variable names + wasn't in use until the addition
> > > > of the region code.    
> > > 
> > > Looks like:
> > > 
> > > Fixes: 60b8f17215de ("cxl/pmem: Translate NVDIMM label commands to CXL label commands")
> > > 
> > > ...to me since any transfer that got within 8 bytes of the payload_size
> > > would fail.  
> > 
> > Makes sense - go with that one.
> 
> Hi Dan,
> 
> I was assuming you'd pick this up as b4 will happily pick the fixes
> tag out of the thread and there weren't any other comments.
> 
> Let me know if you want me to resend with the tag in place.

I believe you should have gotten a notice from patchwork, but I have
this queued up for v6.1-rc fixes.

      reply	other threads:[~2022-10-21 23:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 15:40 [PATCH 0/2] cxl: Fix oversized LSA write payload due to header Jonathan Cameron
2022-08-15 15:40 ` [PATCH 1/2] cxl/mbox: Add a check on input payload size Jonathan Cameron
2022-08-15 15:40 ` [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA Jonathan Cameron
2022-08-15 21:55   ` Dan Williams
2022-08-17 11:29     ` Jonathan Cameron
2022-10-10 15:31       ` Jonathan Cameron
2022-10-21 23:31         ` Dan Williams [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=63532bb5576c4_4da32942e@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bwidawsk@kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox