Re: [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA.

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 17 Aug 2022 12:29:30 +0100
Jonathan Cameron <Jonathan.Cameron@huawei.com> wrote:

> On Mon, 15 Aug 2022 14:55:42 -0700
> Dan Williams <dan.j.williams@intel.com> wrote:
> 
> > [ apologies if this is a duplicate response ]
> > 
> > Jonathan Cameron wrote:  
> > > Writes to the device must include an offset and size as defined in
> > > CXL 2.0 8.2.9.5.2.4 Set LSA (Opcode 4103h)
> > > 
> > > Fixes tag is non obvious as this code has been through several
> > > reworks and variable names + wasn't in use until the addition
> > > of the region code.    
> > 
> > Looks like:
> > 
> > Fixes: 60b8f17215de ("cxl/pmem: Translate NVDIMM label commands to CXL label commands")
> > 
> > ...to me since any transfer that got within 8 bytes of the payload_size
> > would fail.  
> 
> Makes sense - go with that one.

Hi Dan,

I was assuming you'd pick this up as b4 will happily pick the fixes
tag out of the thread and there weren't any other comments.

Let me know if you want me to resend with the tag in place.

Thanks,

Jonathan
 
> 
> > 
> > I notice that cxl_test worked around this bug simply because the mocking
> > does not attempt to emulate the actual mailbox transfer, just the
> > logical data transfer. I apprecitate having QEMU to back up the unit
> > testing.
> >   
>