Linux CXL
 help / color / mirror / Atom feed
From: Dan Williams <dan.j.williams@intel.com>
To: Jonathan Cameron <Jonathan.Cameron@huawei.com>,
	<linux-cxl@vger.kernel.org>, <linuxarm@huawei.com>
Cc: Dan Williams <dan.j.williams@intel.com>,
	<vishal.l.verma@intel.com>, <ira.weiny@intel.com>,
	Ben Widawsky <bwidawsk@kernel.org>
Subject: RE: [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA.
Date: Mon, 15 Aug 2022 14:55:42 -0700	[thread overview]
Message-ID: <62fac0de2685b_dfbc1294d2@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <20220815154044.24733-3-Jonathan.Cameron@huawei.com>

[ apologies if this is a duplicate response ]

Jonathan Cameron wrote:
> Writes to the device must include an offset and size as defined in
> CXL 2.0 8.2.9.5.2.4 Set LSA (Opcode 4103h)
> 
> Fixes tag is non obvious as this code has been through several
> reworks and variable names + wasn't in use until the addition
> of the region code.

Looks like:

Fixes: 60b8f17215de ("cxl/pmem: Translate NVDIMM label commands to CXL label commands")

...to me since any transfer that got within 8 bytes of the payload_size
would fail.

I notice that cxl_test worked around this bug simply because the mocking
does not attempt to emulate the actual mailbox transfer, just the
logical data transfer. I apprecitate having QEMU to back up the unit
testing.

  reply	other threads:[~2022-08-16  5:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-15 15:40 [PATCH 0/2] cxl: Fix oversized LSA write payload due to header Jonathan Cameron
2022-08-15 15:40 ` [PATCH 1/2] cxl/mbox: Add a check on input payload size Jonathan Cameron
2022-08-15 15:40 ` [PATCH 2/2] cxl/pmem: Fix failure to account for 8 byte header for writes to the device LSA Jonathan Cameron
2022-08-15 21:55   ` Dan Williams [this message]
2022-08-17 11:29     ` Jonathan Cameron
2022-10-10 15:31       ` Jonathan Cameron
2022-10-21 23:31         ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62fac0de2685b_dfbc1294d2@dwillia2-xfh.jf.intel.com.notmuch \
    --to=dan.j.williams@intel.com \
    --cc=Jonathan.Cameron@huawei.com \
    --cc=bwidawsk@kernel.org \
    --cc=ira.weiny@intel.com \
    --cc=linux-cxl@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=vishal.l.verma@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox