Re: [PATCH 01/19] cxl/regs: Clarify when a 'struct cxl_register_map' is input vs output

[Jonathan Cameron <Jonathan.Cameron@Huawei.com>]

On Sun, 04 Jun 2023 16:31:43 -0700
Dan Williams <dan.j.williams@intel.com> wrote:

> The @map parameter to cxl_probe_X_registers() is filled in with the
> mapping parameters of the register block. The @map parameter to
> cxl_map_X_registers() only reads that information to perform the
> mapping. Mark @map const for cxl_map_X_registers() to clarify that it is
> only an input to those helpers.
> 
> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
This makes sense as a stand alone clarification.

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>

> ---
>  drivers/cxl/core/regs.c |    8 ++++----
>  drivers/cxl/cxl.h       |    4 ++--
>  2 files changed, 6 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/cxl/core/regs.c b/drivers/cxl/core/regs.c
> index 1476a0299c9b..52d1dbeda527 100644
> --- a/drivers/cxl/core/regs.c
> +++ b/drivers/cxl/core/regs.c
> @@ -200,10 +200,10 @@ void __iomem *devm_cxl_iomap_block(struct device *dev, resource_size_t addr,
>  }
>  
>  int cxl_map_component_regs(struct device *dev, struct cxl_component_regs *regs,
> -			   struct cxl_register_map *map, unsigned long map_mask)
> +			   const struct cxl_register_map *map, unsigned long map_mask)
>  {
>  	struct mapinfo {
> -		struct cxl_reg_map *rmap;
> +		const struct cxl_reg_map *rmap;
>  		void __iomem **addr;
>  	} mapinfo[] = {
>  		{ &map->component_map.hdm_decoder, &regs->hdm_decoder },
> @@ -233,11 +233,11 @@ EXPORT_SYMBOL_NS_GPL(cxl_map_component_regs, CXL);
>  
>  int cxl_map_device_regs(struct device *dev,
>  			struct cxl_device_regs *regs,
> -			struct cxl_register_map *map)
> +			const struct cxl_register_map *map)
>  {
>  	resource_size_t phys_addr = map->resource;
>  	struct mapinfo {
> -		struct cxl_reg_map *rmap;
> +		const struct cxl_reg_map *rmap;
>  		void __iomem **addr;
>  	} mapinfo[] = {
>  		{ &map->device_map.status, &regs->status, },
> diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h
> index f93a28538962..dfc94e76c7d6 100644
> --- a/drivers/cxl/cxl.h
> +++ b/drivers/cxl/cxl.h
> @@ -254,10 +254,10 @@ void cxl_probe_component_regs(struct device *dev, void __iomem *base,
>  void cxl_probe_device_regs(struct device *dev, void __iomem *base,
>  			   struct cxl_device_reg_map *map);
>  int cxl_map_component_regs(struct device *dev, struct cxl_component_regs *regs,
> -			   struct cxl_register_map *map,
> +			   const struct cxl_register_map *map,
>  			   unsigned long map_mask);
>  int cxl_map_device_regs(struct device *dev, struct cxl_device_regs *regs,
> -			struct cxl_register_map *map);
> +			const struct cxl_register_map *map);
>  
>  enum cxl_regloc_type;
>  int cxl_find_regblock(struct pci_dev *pdev, enum cxl_regloc_type type,
>