Re: [RFC PATCH v2 09/20] fwctl/cxl: Add driver for CXL mailbox for handling CXL features commands

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Nov 15, 2024 at 02:25:42PM -0700, Dave Jiang wrote:
> @@ -1721,7 +1742,25 @@ int cxl_mailbox_init(struct cxl_mailbox *cxl_mbox, struct device *host)
>  	mutex_init(&cxl_mbox->mbox_mutex);
>  	rcuwait_init(&cxl_mbox->mbox_wait);
>  
> -	return 0;
> +	fwctl->cxl_mbox = cxl_mbox;
> +	dev = &fwctl->dev;
> +	device_initialize(dev);
> +	device_set_pm_not_required(dev);
> +	dev->parent = host;
> +	dev->bus = &cxl_bus_type;
> +	dev->type = &cxl_fwctl_type;
> +
> +	rc = device_add(dev);
> +	if (rc)
> +		goto err;

If you don't call dev_set_name(), don't you have to set dev->id to
something unique?

> diff --git a/drivers/fwctl/Kconfig b/drivers/fwctl/Kconfig
> index e5ee2d46d431..e49903a9d0d3 100644
> --- a/drivers/fwctl/Kconfig
> +++ b/drivers/fwctl/Kconfig
> @@ -19,5 +19,14 @@ config FWCTL_MLX5
>  	  This will allow configuration and debug tools to work out of the box on
>  	  mainstream kernel.
>  
> +	  If you don't know what to do here, say N.
> +
> +config FWCTL_CXL
> +	tristate "CXL fwctl driver"
> +	depends on CXL_BUS
> +	help
> +	  CXLCTL provides interface for the user process to access user allowed
> +	  mailbox commands for CXL device.
> +
>  	  If you don't know what to do here, say N.
>  endif

Keep sorted

> diff --git a/drivers/fwctl/Makefile b/drivers/fwctl/Makefile
> index 1c535f694d7f..bd356e6f2e5a 100644
> --- a/drivers/fwctl/Makefile
> +++ b/drivers/fwctl/Makefile
> @@ -1,5 +1,6 @@
>  # SPDX-License-Identifier: GPL-2.0
>  obj-$(CONFIG_FWCTL) += fwctl.o
>  obj-$(CONFIG_FWCTL_MLX5) += mlx5/
> +obj-$(CONFIG_FWCTL_CXL) += cxl/

Keep sorted

Jason