Re: [RFC PATCH v2 05/20] cxl: Add Get Feature command support for user submission

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Fri, 15 Nov 2024 14:25:38 -0700
Dave Jiang <dave.jiang@intel.com> wrote:

> Add enumeration of Get Feature mailbox command for the kernel to recognize
> the command being passed in from user space.
> 
> CXL spec r3.1 8.2.9.6.2 Get Feature (Opcode 0501h)
> 
> The feature requested is identified by specific UUID.
> 
> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Hmm. Should we push this into Shiju's series if thought is that will land
first?  Seems harmless but I find it hard to care that much ;)

Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> ---
>  drivers/cxl/core/mbox.c      | 1 +
>  include/uapi/linux/cxl_mem.h | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c
> index f70bd7d28ff8..f49665d3b4d6 100644
> --- a/drivers/cxl/core/mbox.c
> +++ b/drivers/cxl/core/mbox.c
> @@ -68,6 +68,7 @@ static struct cxl_mem_command cxl_mem_commands[CXL_MEM_COMMAND_ID_MAX] = {
>  	CXL_CMD(GET_SCAN_MEDIA_CAPS, 0x10, 0x4, 0),
>  	CXL_CMD(GET_TIMESTAMP, 0, 0x8, 0),
>  	CXL_CMD(GET_SUPPORTED_FEATURES, 0x8, CXL_VARIABLE_PAYLOAD, 0),
> +	CXL_CMD(GET_FEATURE, 0x15, CXL_VARIABLE_PAYLOAD, 0),
>  };
>  
>  /*
> diff --git a/include/uapi/linux/cxl_mem.h b/include/uapi/linux/cxl_mem.h
> index bd2535962f70..90dcb9723997 100644
> --- a/include/uapi/linux/cxl_mem.h
> +++ b/include/uapi/linux/cxl_mem.h
> @@ -51,6 +51,7 @@
>  	___C(CLEAR_LOG, "Clear Log"),					  \
>  	___C(GET_SUP_LOG_SUBLIST, "Get Supported Logs Sub-List"),	  \
>  	___C(GET_SUPPORTED_FEATURES, "Get Supported Features"),		  \
> +	___C(GET_FEATURE, "Get Feature"),				  \
>  	___C(MAX, "invalid / last command")
>  
>  #define ___C(a, b) CXL_MEM_COMMAND_ID_##a