Re: [RFC PATCH v2 0/20] fwctl/cxl: Add CXL feature commands support via fwctl

[Jonathan Cameron <Jonathan.Cameron@huawei.com>]

On Wed, 20 Nov 2024 14:57:20 -0400
Jason Gunthorpe <jgg@nvidia.com> wrote:

> On Fri, Nov 15, 2024 at 02:25:33PM -0700, Dave Jiang wrote:
> > v2:
> > - Dropped 1/13 and 2/13 from previous version. Merged upstream already.
> > - Combined changes from Shiju for "get supported features"
> > - Addressed comments from Jonathan and Jason
> > - See specific changes in individual patch revision history
> > - Added hardware command info to FWCTL
> > - Added filtering to set feature command
> > - Added documentation  
> 
> I looked through it, and I think it is good enough that the next
> posting should not be RFC from my perspective..
> 
> The amount of CXL core patches has reduced quite a lot, it would be good to
> order the patches so CXL was grouped together at the start, that would
> make it easier to create a shared branch down the road
> 
> For instance very roughly something like:
> 
> >       cxl: Refactor user ioctl command path from mds to mailbox
> >       cxl: Add Get Supported Features command for kernel usage
> >       cxl/mbox: Add GET_FEATURE mailbox command
> >       cxl: Add Get Feature command support for user submission
> >       cxl/mbox: Add SET_FEATURE mailbox command

Some of these are common to the EDAC RAS features set which
I'm really hoping finally lands next cycle.

So we will need to be a little careful in how we merge things.

Going to need to be careful how we handle this.  Maybe Dave should
pick up the feature stuff as an immutable branch after rc1 and
both series get rebuilt on top of that.  Need to discuss if
Borislav is happy with that for potential merge of the RAS
features series (EDAC).

Anyhow, time up for me today. I'll look at the rest of the series
tomorrow.

Jonathan

> >       cxl: Add Set Feature command support for user submission
> >       cxl: Move cxl_driver related bits to be usable by external drivers
> >       cxl: Save Command Effects Log (CEL) effects for enabled commands
> >       cxl: Move defines and error codes from cxlmem.h to cxl/mailbox.h
> >       cxl/test: Add Get Supported Features mailbox command support
> >       cxl/test: Add Get Feature support to cxl_test
> >       cxl/test: Add Set Feature support to cxl_test  
> 
> >       fwctl: FWCTL_HW_INFO to return hardware information
> >       fwctl/cxl: Add driver for CXL mailbox for handling CXL features commands
> >       fwctl/cxl: Add support for get driver information
> >       fwctl/cxl: Add hw_info callback
> >       fwctl/cxl: Add support for fwctl RPC command to enable CXL feature commands
> >       fwctl/cxl: Add support to filter exclusive features
> >       fwctl/cxl: Add documentation to FWCTL CXL  
> 
> Thanks,
> Jason