Re: [RFC PATCH v2 11/20] fwctl: FWCTL_HW_INFO to return hardware information

[Jason Gunthorpe <jgg@nvidia.com>]

On Fri, Dec 06, 2024 at 11:39:03AM -0700, Dave Jiang wrote:
> 
> 
> On 12/5/24 10:32 PM, Dan Williams wrote:
> > Dave Jiang wrote:
> >> Add an optional ioctl FWCTL_HW_INFO to pass command specific information
> >> to user space. An array of 'struct fwctl_command_info' will be returned
> >> from the ioctl. These commands are send to the driver via FWCTL_RPC call.
> >> The command info struct contains the command id, the related hardware
> >> opcode, input and output size for the command, and the effects the command
> >> has if it's a write command.
> > 
> > Maybe this made more immediate sense to Jason, but I do not see why CXL
> > needs a FWCTL_CMD_HWINFO when FWCTL_CMD_RPC can just convey the GET
> > SUPPORTED FEATURES payload?
> 
> That is because I wrote the code with intention of supporting the
> existing chardev commands in addition to features. If we are only
> supporting feature commands fwctl, then we can drop this and make
> things simpler.

If that is what this series is doing then lets drop it, if you need it
later it is easy to add

Jason