Re: [v2 4/4] cxl/pci: Simplify the code logic of cxl_hdm_decode_init

[Yanfei Xu <yanfei.xu@intel.com>]

On 8/10/2024 3:15 AM, Dan Williams wrote:
> Yanfei Xu wrote:
>> When HDM decoders exist but is not enabled, the cases can be divided into
>> two categories: DVSEC range enabled and not enabled. Extract the check of
>> mem_enabled out to improve code readability. No functional change.
> 
> I am not convinced that this is clear win, and that there is no
> functional change.

Yeah, no functional change.

Before the patch2 which moves the check of dvsec_range_allowed() 
earlier, the previous codes in cxl_hdm_decode_init() is like below:
             ....
         for (i = 0, allowed = 0; info->mem_enabled && i < info->ranges; 
i++) {
             ....
         }

         if (!allowed && info->mem_enabled) {
             ....
         }

             ....
         if (info->mem_enabled)
                 return 0;

It checks "info->mem_enabled" consecutively three times, so if 
extracting the check and replace it with one check of 
"!info->mem_enabled" can improve code readability I was thinking.
However with applying of patch2, maybe this patch is not much necessary, 
we can drop it. :)

Thanks,
Yanfei