Re: [PATCH 3/7] cxl/test: Refactor platform device enumerations

[Dave Jiang <dave.jiang@intel.com>]

On 5/5/26 9:45 PM, Alison Schofield wrote:
> On Wed, Apr 22, 2026 at 04:02:33PM -0700, Dave Jiang wrote:
>> Split all the host bridges, rootports, upstream and downstream ports
>> enumerations to separate helper functions. This should make adding
>> type2 hierarchy easier later on.
>>
>> Signed-off-by: Dave Jiang <dave.jiang@intel.com>
>> ---
>>  tools/testing/cxl/test/cxl.c | 327 +++++++++++++++++++++++------------
>>  1 file changed, 217 insertions(+), 110 deletions(-)
>>
>> diff --git a/tools/testing/cxl/test/cxl.c b/tools/testing/cxl/test/cxl.c
>> index 903223013e41..5fd73f0634c6 100644
>> --- a/tools/testing/cxl/test/cxl.c
>> +++ b/tools/testing/cxl/test/cxl.c
> 
> snip
> 
>> +static void cxl_usps_remove(void)
>> +{
>> +	for (int i = ARRAY_SIZE(cxl_switch_dport) - 1; i >= 0; i--) {
>> +		struct platform_device *pdev = cxl_switch_dport[i];
>> +
>> +		if (!pdev)
>> +			break;
>> +
>> +		platform_device_unregister(cxl_switch_dport[i]);
>> +	}
>> +}
> 
> snip
> 
> 
>> +
>> +static void cxl_dsps_remove(void)
>> +{
>> +	for (int i = ARRAY_SIZE(cxl_switch_uport) - 1; i >= 0; i--) {
>> +		struct platform_device *pdev = cxl_switch_uport[i];
>> +
>> +		if (!pdev)
>> +			break;
>> +
>> +		platform_device_unregister(cxl_switch_uport[i]);
>> +	}
>> +}
> 
> The bodies of cxl_usps_remove() and cxl_dsps_remove() appear swapped.
> ie the Usps one iterates the Dport and the Dsps one iterates the Uport.
> I think these above need a switcheroo, and then the call order below 
> needs reversing:

ok will fix

> 
>> +static void cxl_switches_remove(void)
>> +{
>> +	cxl_usps_remove();
>> +	cxl_dsps_remove();
>> +}
> 
> skip to end
> 
>