Re: [PATCH v7 06/11] iio: adc: hx711: introduce hx711_chip_info structure

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Probe unconditionally fails for legacy platform device instantiation, breaking backwards compatibility.
--

commit df7c142f973e9e00df00559065a303371d262619
Author: Piyush Patle <piyushpatle228@gmail.com>

iio: adc: hx711: introduce hx711_chip_info structure

This commit introduces a per-variant static configuration structure to
populate IIO device fields at probe time. This prepares the driver for
supporting additional hardware variants while intending to keep existing
functionality unchanged.

> diff --git a/drivers/iio/adc/hx711.c b/drivers/iio/adc/hx711.c
> index 2da128c1caf36..913e1a50529ad 100644
> --- a/drivers/iio/adc/hx711.c
> +++ b/drivers/iio/adc/hx711.c
[ ... ]
> @@ -473,6 +498,12 @@ static int hx711_probe(struct platform_device *pdev)
>  
>  	mutex_init(&hx711_data->lock);
>  
> +	chip_info = device_get_match_data(dev);
> +	if (!chip_info)
> +		return dev_err_probe(dev, -ENODEV, "missing driver data\n");

For legacy platform devices instantiated without a firmware node like Device
Tree or ACPI, device_get_match_data() returns NULL.

Will this unconditional error return cause the probe to fail for those legacy
users?

Since the commit message notes there are no functional changes for existing
users, should this fallback to the default hx711_chip structure when
chip_info is NULL?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260510194947.31997-1-piyushpatle228@gmail.com?part=6