From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Piyush Patle <piyushpatle228@gmail.com>
Cc: ak@it-klinger.de, jic23@kernel.org, dlechner@baylibre.com,
nuno.sa@analog.com, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, linux-iio@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset
Date: Mon, 11 May 2026 14:22:40 +0300 [thread overview]
Message-ID: <agG8AG1srKZ4oWp6@ashevche-desk.local> (raw)
In-Reply-To: <20260510194947.31997-9-piyushpatle228@gmail.com>
On Mon, May 11, 2026 at 01:19:30AM +0530, Piyush Patle wrote:
> Separate the initial value assignments from the declarations in
> hx711_read() and hx711_reset().
>
> This is a small preparatory cleanup before the later loop-iterator and
> variant-specific changes adjust the local variable layout in these
> functions.
...
> static int hx711_reset(struct hx711_data *hx711_data)
> {
> - int val = hx711_wait_for_ready(hx711_data);
> + int val;
> + val = hx711_wait_for_ready(hx711_data);
>
> if (val) {
No, blank line should divide the definitions and code, and should not be in
semantically coupled places.
...
Again, no need to resend, but keep in mind if you need a v8, this and other
comments needs to be addressed.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-05-11 11:22 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-10 19:49 [PATCH v7 00/11] iio: adc: hx711: add HX710B support Piyush Patle
2026-05-10 19:49 ` [PATCH v7 01/11] dt-bindings: iio: adc: hx711: clean up existing binding text Piyush Patle
2026-05-11 16:08 ` Conor Dooley
2026-05-10 19:49 ` [PATCH v7 02/11] dt-bindings: iio: adc: hx711: add VSUP supply property Piyush Patle
2026-05-11 16:09 ` Conor Dooley
2026-05-10 19:49 ` [PATCH v7 03/11] dt-bindings: iio: adc: hx711: add RATE GPIO property Piyush Patle
2026-05-11 16:09 ` Conor Dooley
2026-05-10 19:49 ` [PATCH v7 04/11] dt-bindings: iio: adc: hx711: add HX710B support Piyush Patle
2026-05-11 16:09 ` Conor Dooley
2026-05-11 21:54 ` sashiko-bot
2026-05-12 16:51 ` Conor Dooley
2026-05-10 19:49 ` [PATCH v7 05/11] iio: adc: hx711: move scale computation to per-device storage Piyush Patle
2026-05-11 11:19 ` Andy Shevchenko
2026-05-11 13:45 ` Piyush Patle
2026-05-10 19:49 ` [PATCH v7 06/11] iio: adc: hx711: introduce hx711_chip_info structure Piyush Patle
2026-05-11 14:33 ` Jonathan Cameron
2026-05-11 22:27 ` sashiko-bot
2026-05-10 19:49 ` [PATCH v7 07/11] iio: adc: hx711: pass trailing pulse count into hx711_read Piyush Patle
2026-05-10 19:49 ` [PATCH v7 08/11] iio: adc: hx711: split variable assignments in hx711_read and hx711_reset Piyush Patle
2026-05-11 11:22 ` Andy Shevchenko [this message]
2026-05-11 14:34 ` Jonathan Cameron
2026-05-10 19:49 ` [PATCH v7 09/11] iio: adc: hx711: localize loop iterators in hx711_read Piyush Patle
2026-05-10 19:49 ` [PATCH v7 10/11] iio: adc: hx711: pass iio_chan_spec to hx711_reset_read Piyush Patle
2026-05-11 23:10 ` sashiko-bot
2026-05-10 20:26 ` [PATCH v7 11/11] iio: adc: hx711: add support for HX710B Piyush Patle
2026-05-11 11:27 ` Andy Shevchenko
2026-05-11 13:49 ` Piyush Patle
2026-05-11 14:59 ` Jonathan Cameron
2026-05-11 14:26 ` Jonathan Cameron
2026-05-12 0:01 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=agG8AG1srKZ4oWp6@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=ak@it-klinger.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=piyushpatle228@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox