Re: [PATCH v7 04/11] dt-bindings: iio: adc: hx711: add HX710B support

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 2565 bytes --]

On Mon, May 11, 2026 at 09:54:29PM +0000, sashiko-bot@kernel.org wrote:
> Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> - [Medium] The `dvdd-supply` property is incorrectly permitted for the older HX711 variant, violating the intended hardware constraints and contradicting the commit message.
> --
> 
> commit b2ce63274d21d343a80ad3dfc6983d09ccc4fbdc
> Author: Piyush Patle <piyushpatle228@gmail.com>
> 
> dt-bindings: iio: adc: hx711: add HX710B support
>     
> This adds the avia,hx710b compatible string and documents the hx710b-specific
> dvdd and vref supplies. It also adds constraints to forbid hx711-only
> properties on hx710b nodes and requires vref-supply for hx710b.
> 
> > diff --git a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > index 9134bbe413796..b2b5c7bdf05e6 100644
> > --- a/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> > +++ b/Documentation/devicetree/bindings/iio/adc/avia-hx711.yaml
> 
> [ ... ]
> 
> > @@ -44,6 +49,17 @@ properties:
> >        RATE pin state is determined by the board wiring.
> >      maxItems: 1
> >  
> > +  dvdd-supply:
> > +    description:
> > +      Digital supply voltage (DVDD). For the HX710B, DVDD must be
> > +      greater than or equal to AVDD. When DVDD is a battery rail and
> > +      AVDD is a regulated supply, one channel monitors the DVDD-AVDD
> > +      difference for battery level detection.
> > +
> > +  vref-supply:
> > +    description:
> > +      Reference voltage input (VREF).
> > +
> >    clock-frequency:
> 
> [ ... ]
> 
> > @@ -53,6 +69,21 @@ properties:
> >      maximum: 2500000
> >      default: 400000
> >  
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: avia,hx710b
> > +    then:
> > +      properties:
> > +        vsup-supply: false
> > +        rate-gpios: false
> > +      required:
> > +        - vref-supply
> > +    else:
> > +      properties:
> > +        vref-supply: false
> 
> The commit message states the intention to document the hx710b-specific dvdd
> and vref supplies.
> 
> Since dvdd-supply is defined in the top-level properties block, does this
> else clause also need to forbid dvdd-supply for the older avia,hx711 variant?
> 
> Currently, omitting dvdd-supply: false permits the property for the older
> hx711 variant. Should dvdd-supply: false be added here?

Seemingly no, hx711 schematic has a dvdd.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]