Re: [PATCH 03/15] dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [High] The `if` conditionals in `allOf` incorrectly use `enum:` instead of `contains: enum:`, causing the condition to never match.
--

commit 422b32e17fa321946e679002f4f6f7b6b918fe88
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8192 dt-bindings into MT8186

This commit regroups the MT8192 clock and system clock dt-bindings into
the MT8186 files. This simplifies maintainability and establishes common files
for SoCs with similar clock controller designs.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index 28e05b5fb23bb..3b543c810f18d 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> @@ -58,7 +58,26 @@ properties:
>            - mediatek,mt8188-vencsys
>            - mediatek,mt8188-wpesys
>            - mediatek,mt8188-wpesys-vpp0
> -
> +          - mediatek,mt8192-camsys

[ ... ]

[Severity: High]
This isn't a bug introduced by this patch (it appears to have been introduced
in the previous patch of the series), but looking at the allOf block further
down in this file:

allOf:
  - if:
      properties:
        compatible:
          enum:
            - mediatek,mt8188-adsp-audio26m

Does this condition fail to match because it uses enum: instead of
contains: enum:?

Since the compatible property is evaluated as an array of strings, comparing
it directly against a string enum prevents the condition from matching when
running dt_binding_check on any device tree containing the affected MT8188
compatibles.

This causes the schema validation to silently fail to enforce the
#clock-cells and #reset-cells requirements for all MT8188 compatibles.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com?part=3