Re: [PATCH 07/15] clk: mediatek: Add MT8189 topckgen clock support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing MODULE_DEVICE_TABLE(of, ...) macro prevents module autoloading.
--

commit ad61575ea6a112e8fdb28af2de8ae432cbe5778c
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

clk: mediatek: Add MT8189 topckgen clock support

Add support for the MT8189 topckgen clock controller, which provides
muxes and dividers for clock selection in other IP blocks.

> diff --git a/drivers/clk/mediatek/clk-mt8189-topckgen.c b/drivers/clk/mediatek/clk-mt8189-topckgen.c
> new file mode 100644
> index 0000000000000..62d292f5b8b87
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt8189-topckgen.c

[ ... ]

> +static const struct of_device_id of_match_clk_mt8189_topck[] = {
> +	{ .compatible = "mediatek,mt8189-topckgen", .data = &topck_desc },
> +	{ /* sentinel */ }
> +};

[Severity: Medium]
Will this module automatically load if configured as a loadable module (=m)?

Without the MODULE_DEVICE_TABLE(of, ...) macro, it appears udev won't 
be able to automatically load the driver based on the device tree compatible
string alias. This could leave downstream IP blocks that depend on the
topckgen clocks without clock support, potentially causing functional or
boot failures.

> +
> +static struct platform_driver clk_mt8189_topck_drv = {
> +	.probe = mtk_clk_simple_probe,
> +	.remove = mtk_clk_simple_remove,
> +	.driver = {
> +		.name = "clk-mt8189-topck",
> +		.of_match_table = of_match_clk_mt8189_topck,
> +	},
> +};

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com?part=7