Re: [PATCH 09/15] clk: mediatek: Add MT8189 vlpcfg clock support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] Missing MODULE_DEVICE_TABLE for of_match_clk_mt8189_vlpcfg prevents automatic module loading.
--

commit 4e00bfeb3666b50213ed9466f10f258b5c5893af
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

clk: mediatek: Add MT8189 vlpcfg clock support

This commit introduces the MT8189 vlpcfg clock controller driver, which
manages clock gate control for the vlp domain IPs.

> diff --git a/drivers/clk/mediatek/clk-mt8189-vlpcfg.c b/drivers/clk/mediatek/clk-mt8189-vlpcfg.c
> new file mode 100644
> index 0000000000000..81e2d44bd320f
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt8189-vlpcfg.c

[ ... ]

> +static const struct of_device_id of_match_clk_mt8189_vlpcfg[] = {
> +	{ .compatible = "mediatek,mt8189-vlpcfg", .data = &vlpcfg_reg_mcd },
> +	{ .compatible = "mediatek,mt8189-vlpcfg-ao", .data = &vlpcfg_ao_reg_mcd },
> +	{ /* sentinel */ }
> +};

[Severity: Medium]
Does this driver need a MODULE_DEVICE_TABLE declaration for
of_match_clk_mt8189_vlpcfg?

Since the driver can be built as a loadable module, omitting the device
table macro means the module build system will not extract the device tree
match aliases into the .modalias section.

Could this prevent udev from automatically loading the module when the
hardware is discovered during boot?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com?part=9