Re: [PATCH 02/15] dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
- [Medium] Schema validation bypass due to missing `contains:` keyword in conditional blocks for the `compatible` property.
- [Medium] Schema constraint typo (`reset-cells` instead of `#reset-cells`) fails to forbid the property on non-provider devices.
--

commit df2142379daed191855d2325fce7ca8b5c551906
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

dt-bindings: clock: mediatek: regroup MT8188 dt-bindings into MT8186

Regroup the MT8188 clock and system clock dt-bindings into MT8186 ones
to ease maintainability and have common files for several currently
supported SoC or new future ones.

> diff --git a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> index 37e1d7487ab4c..28e05b5fb23bb 100644
> --- a/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/mediatek,mt8186-clock.yaml

[ ... ]

> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - mediatek,mt8188-adsp-audio26m
> +            - mediatek,mt8188-camsys

[Severity: Medium]
Does this if condition fail to match the compatible strings?

The compatible property in Device Tree schemas is always parsed as a JSON
array of strings. Because this attempts to match the array directly against
a scalar string enum without using contains:, it evaluates to false for all
items and silently fails to enforce the #clock-cells requirement.

The correct syntax (contains: enum:) was used successfully in the 
mediatek,mt8186-sys-clock.yaml changes later in this patch.

[ ... ]

> +  - if:
> +      properties:
> +        compatible:
> +          enum:
> +            - mediatek,mt8188-camsys-rawa
> +            - mediatek,mt8188-camsys-rawb

[Severity: Medium]
Does this also skip #reset-cells enforcement by missing the contains: keyword
before the enum?

[ ... ]

> +            - mediatek,mt8188-ipesys
> +    then:
> +      required:
> +        - '#reset-cells'
> +    else:
> +      properties:
> +        reset-cells: false

[Severity: Medium]
Should this be '#reset-cells' instead of reset-cells?

Because '#reset-cells': const: 1 was added globally to the file to support
MT8188 providers, missing the # prefix (and quotes) means the fallback
constraint is applied to a non-existent property. This allows
non-reset-provider devices to erroneously define #reset-cells in their
device tree nodes without triggering schema validation errors.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com?part=2