Re: [PATCH 08/15] clk: mediatek: Add MT8189 vlpckgen clock support

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The driver is missing the MODULE_DEVICE_TABLE(of, ...) declaration for the OF match table, preventing module autoloading.
--

commit ee1b10c9e19991da4719281ac8913fc069799dd3
Author: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>

clk: mediatek: Add MT8189 vlpckgen clock support

This commit adds support for the MT8189 vlpckgen clock controller. It
provides the necessary muxes and dividers for clock selection in the
vlp domain for other IP blocks.

> diff --git a/drivers/clk/mediatek/clk-mt8189-vlpckgen.c b/drivers/clk/mediatek/clk-mt8189-vlpckgen.c
> new file mode 100644
> index 0000000000000..39ca051b9ef81
> --- /dev/null
> +++ b/drivers/clk/mediatek/clk-mt8189-vlpckgen.c

[ ... ]

> +static const struct of_device_id of_match_clk_mt8189_vlpck[] = {
> +	{ .compatible = "mediatek,mt8189-vlpckgen", .data = &vlpck_desc },
> +	{ /* sentinel */ }
> +};

[Severity: Medium]
Does this driver need a MODULE_DEVICE_TABLE(of, of_match_clk_mt8189_vlpck)
declaration here? 

Without it, udev might not automatically load the module during boot when
the device tree node is encountered, as the modalias information won't be
generated.

> +
> +static struct platform_driver clk_mt8189_vlpck_drv = {
> +	.probe = mtk_clk_simple_probe,
> +	.remove = mtk_clk_simple_remove,
> +	.driver = {
> +		.name = "clk-mt8189-vlpck",
> +		.of_match_table = of_match_clk_mt8189_vlpck,
> +	},
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260701-mt8189-clocks-system-base-v1-0-2b048feea50a@collabora.com?part=8