[PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Mikhail Lukianchikov]

Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema.

The conversion adds proper validation for the 'microchip,led-modes'
property inside the MDIO node and updates the MAINTAINERS entry.

Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
---
Changes in v2:
 - Rename file to microchip,lan7800.yaml.
 - Keeps only one maintainer.
 - Code style fixed.
 - Example fixed, remove usb-port@1 node.
 - Move patternProperties for PHY inside mdio node to fix validation. (suggested by sashiko-bot)

Link to v1: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com

 .../bindings/net/microchip,lan7800.yaml       | 105 ++++++++++++++++++
 .../bindings/net/microchip,lan78xx.txt        |  53 ---------
 MAINTAINERS                                   |   3 +-
 3 files changed, 106 insertions(+), 55 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
 delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt

diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
new file mode 100644
index 000000000000..289980c23181
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
@@ -0,0 +1,105 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller
+
+maintainers:
+  - Rengarajan Sundararajan <Rengarajan.S@microchip.com>
+
+description:
+  The LAN7800/LAN7801/LAN7850 devices are usually configured by
+  programming their OTP or with an external EEPROM, but some
+  platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree
+  properties, if present, override the OTP and EEPROM.
+
+allOf:
+  - $ref: /schemas/usb/usb-device.yaml#
+  - $ref: /schemas/net/ethernet-controller.yaml#
+
+properties:
+  compatible:
+    enum:
+      - usb424,7800
+      - usb424,7801
+      - usb424,7850
+
+  reg:
+    maxItems: 1
+    description: USB port number
+
+  local-mac-address:
+    $ref: /schemas/types.yaml#/definitions/uint8-array
+    minItems: 6
+    maxItems: 6
+    description:
+      MAC address to use if not stored in OTP or EEPROM. If present,
+      overrides OTP/EEPROM.
+
+  mdio:
+    $ref: /schemas/net/mdio.yaml#
+    unevaluatedProperties: false
+
+    patternProperties:
+      "^ethernet-phy(@[0-9a-f]+)?$":
+        type: object
+        description: |
+          PHY node for the embedded or external PHY. The PHY address is
+          given by the 'reg' property.
+
+        properties:
+          reg:
+            maxItems: 1
+            description: PHY address.
+
+          microchip,led-modes:
+            $ref: /schemas/types.yaml#/definitions/uint32-array
+            minItems: 1
+            maxItems: 4
+            description:
+              Array of LED mode values for each of up to 4 LEDs.
+              Omitted LEDs are turned off. Allowed values are defined
+              in include/dt-bindings/net/microchip-lan78xx.h.
+
+        required:
+          - reg
+
+        additionalProperties: false
+
+required:
+  - compatible
+  - reg
+
+unevaluatedProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/net/microchip-lan78xx.h>
+    / {
+        usb {
+            compatible = "usb-host";
+            #address-cells = <1>;
+            #size-cells = <0>;
+
+            ethernet@1 {
+                compatible = "usb424,7800";
+                reg = <1>;
+                local-mac-address = [00 11 22 33 44 55];
+
+                mdio {
+                    #address-cells = <1>;
+                    #size-cells = <0>;
+                    ethernet-phy@1 {
+                        reg = <1>;
+                        microchip,led-modes = <
+                            LAN78XX_LINK_1000_ACTIVITY
+                            LAN78XX_LINK_10_100_ACTIVITY
+                        >;
+                    };
+                };
+            };
+        };
+    };
+...
diff --git a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt b/Documentation/devicetree/bindings/net/microchip,lan78xx.txt
deleted file mode 100644
index 11a679530ae6..000000000000
--- a/Documentation/devicetree/bindings/net/microchip,lan78xx.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-Microchip LAN78xx Gigabit Ethernet controller
-
-The LAN78XX devices are usually configured by programming their OTP or with
-an external EEPROM, but some platforms (e.g. Raspberry Pi 3 B+) have neither.
-The Device Tree properties, if present, override the OTP and EEPROM.
-
-Required properties:
-- compatible: Should be one of "usb424,7800", "usb424,7801" or "usb424,7850".
-
-The MAC address will be determined using the optional properties
-defined in ethernet.txt.
-
-Optional properties of the embedded PHY:
-- microchip,led-modes: a 0..4 element vector, with each element configuring
-  the operating mode of an LED. Omitted LEDs are turned off. Allowed values
-  are defined in "include/dt-bindings/net/microchip-lan78xx.h".
-
-Example:
-
-/* Based on the configuration for a Raspberry Pi 3 B+ */
-&usb {
-	usb-port@1 {
-		compatible = "usb424,2514";
-		reg = <1>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-
-		usb-port@1 {
-			compatible = "usb424,2514";
-			reg = <1>;
-			#address-cells = <1>;
-			#size-cells = <0>;
-
-			ethernet: ethernet@1 {
-				compatible = "usb424,7800";
-				reg = <1>;
-				local-mac-address = [ 00 11 22 33 44 55 ];
-
-				mdio {
-					#address-cells = <0x1>;
-					#size-cells = <0x0>;
-					eth_phy: ethernet-phy@1 {
-						reg = <1>;
-						microchip,led-modes = <
-							LAN78XX_LINK_1000_ACTIVITY
-							LAN78XX_LINK_10_100_ACTIVITY
-						>;
-					};
-				};
-			};
-		};
-	};
-};
diff --git a/MAINTAINERS b/MAINTAINERS
index f37a81950e25..157a677a284f 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -27928,10 +27928,9 @@ F:	drivers/usb/isp1760/*
 USB LAN78XX ETHERNET DRIVER
 M:	Thangaraj Samynathan <Thangaraj.S@microchip.com>
 M:	Rengarajan Sundararajan <Rengarajan.S@microchip.com>
-M:	UNGLinuxDriver@microchip.com
 L:	netdev@vger.kernel.org
 S:	Maintained
-F:	Documentation/devicetree/bindings/net/microchip,lan78xx.txt
+F:	Documentation/devicetree/bindings/net/microchip,lan7800.yaml
 F:	drivers/net/usb/lan78xx.*
 F:	include/dt-bindings/net/microchip-lan78xx.h
 
-- 
2.52.0

Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Rob Herring (Arm)]

On Fri, 10 Jul 2026 00:17:25 +0600, Mikhail Lukianchikov wrote:
> Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
> documentation from plain text to DT schema.
> 
> The conversion adds proper validation for the 'microchip,led-modes'
> property inside the MDIO node and updates the MAINTAINERS entry.
> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
> ---
> Changes in v2:
>  - Rename file to microchip,lan7800.yaml.
>  - Keeps only one maintainer.
>  - Code style fixed.
>  - Example fixed, remove usb-port@1 node.
>  - Move patternProperties for PHY inside mdio node to fix validation. (suggested by sashiko-bot)
> 
> Link to v1: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com
> 
>  .../bindings/net/microchip,lan7800.yaml       | 105 ++++++++++++++++++
>  .../bindings/net/microchip,lan78xx.txt        |  53 ---------
>  MAINTAINERS                                   |   3 +-
>  3 files changed, 106 insertions(+), 55 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: 'compatible' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: 'model' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: '#address-cells' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /: '#size-cells' is a required property
	from schema $id: http://devicetree.org/schemas/root-node.yaml
Documentation/devicetree/bindings/net/microchip,lan7800.example.dtb: /usb: failed to match any schema with compatible: ['usb-host']

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260709181724.24682-2-avermoal@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] The ethernet-phy node schema incorrectly rejects standard Ethernet PHY properties by using `additionalProperties: false` without referencing `ethernet-phy.yaml`.
--

--- Patch [1]: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema ---
commit 484d7e78e4b223fac4e7382aab39e598f0a7d9b3
Author: Mikhail Lukianchikov <avermoal@gmail.com>

dt-bindings: net: microchip,lan78xx: convert to DT schema
    
Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
documentation from plain text to DT schema. The conversion adds proper
validation for the 'microchip,led-modes' property inside the MDIO node.

Link: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com

> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 0000000000000..289980c231810
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
[ ... ]
> +    patternProperties:
> +      "^ethernet-phy(@[0-9a-f]+)?$":
> +        type: object
> +        description: |
> +          PHY node for the embedded or external PHY. The PHY address is
> +          given by the 'reg' property.
> +
> +        properties:
> +          reg:
> +            maxItems: 1
> +            description: PHY address.
> +
> +          microchip,led-modes:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            minItems: 1
> +            maxItems: 4
> +            description:
> +              Array of LED mode values for each of up to 4 LEDs.
> +              Omitted LEDs are turned off. Allowed values are defined
> +              in include/dt-bindings/net/microchip-lan78xx.h.
> +
> +        required:
> +          - reg
> +
> +        additionalProperties: false

[Severity: Medium]
Will this schema definition incorrectly reject standard Ethernet PHY properties?

Using additionalProperties: false here without an explicit 
$ref: /schemas/net/ethernet-phy.yaml# strictly forbids all standard
Ethernet PHY properties (like max-speed, interrupts, or reset-gpios) 
on the child ethernet-phy node. 

This causes the dt-schema validation to fail for boards that legitimately 
describe their hardware PHY connections, which forces users to omit valid 
device descriptions to pass validation.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260709181724.24682-2-avermoal@gmail.com?part=1

Re: [PATCH v2] dt-bindings: net: microchip,lan78xx: convert to DT schema

[Rob Herring]

On Fri, Jul 10, 2026 at 12:17:25AM +0600, Mikhail Lukianchikov wrote:
> Convert the Microchip LAN78xx family (LAN7800, LAN7801, LAN7850) binding
> documentation from plain text to DT schema.
> 
> The conversion adds proper validation for the 'microchip,led-modes'
> property inside the MDIO node and updates the MAINTAINERS entry.
> 
> Signed-off-by: Mikhail Lukianchikov <avermoal@gmail.com>
> ---
> Changes in v2:
>  - Rename file to microchip,lan7800.yaml.
>  - Keeps only one maintainer.
>  - Code style fixed.
>  - Example fixed, remove usb-port@1 node.
>  - Move patternProperties for PHY inside mdio node to fix validation. (suggested by sashiko-bot)
> 
> Link to v1: https://lore.kernel.org/netdev/20260707165840.107409-1-avermoal@gmail.com
> 
>  .../bindings/net/microchip,lan7800.yaml       | 105 ++++++++++++++++++
>  .../bindings/net/microchip,lan78xx.txt        |  53 ---------
>  MAINTAINERS                                   |   3 +-
>  3 files changed, 106 insertions(+), 55 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/microchip,lan7800.yaml
>  delete mode 100644 Documentation/devicetree/bindings/net/microchip,lan78xx.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/microchip,lan7800.yaml b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> new file mode 100644
> index 000000000000..289980c23181
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/microchip,lan7800.yaml
> @@ -0,0 +1,105 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/microchip,lan7800.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Microchip LAN7800/LAN7801/LAN7850 Gigabit Ethernet controller
> +
> +maintainers:
> +  - Rengarajan Sundararajan <Rengarajan.S@microchip.com>
> +
> +description:
> +  The LAN7800/LAN7801/LAN7850 devices are usually configured by
> +  programming their OTP or with an external EEPROM, but some
> +  platforms (e.g. Raspberry Pi 3 B+) have neither. The Device Tree
> +  properties, if present, override the OTP and EEPROM.
> +
> +allOf:
> +  - $ref: /schemas/usb/usb-device.yaml#
> +  - $ref: /schemas/net/ethernet-controller.yaml#
> +
> +properties:
> +  compatible:
> +    enum:
> +      - usb424,7800
> +      - usb424,7801
> +      - usb424,7850
> +
> +  reg:
> +    maxItems: 1
> +    description: USB port number
> +
> +  local-mac-address:
> +    $ref: /schemas/types.yaml#/definitions/uint8-array
> +    minItems: 6
> +    maxItems: 6
> +    description:
> +      MAC address to use if not stored in OTP or EEPROM. If present,
> +      overrides OTP/EEPROM.
> +
> +  mdio:
> +    $ref: /schemas/net/mdio.yaml#
> +    unevaluatedProperties: false
> +
> +    patternProperties:
> +      "^ethernet-phy(@[0-9a-f]+)?$":
> +        type: object

Is there some reason standard phy properties are not valid here? If not, 
then add:

	   $ref: /schemas/net/ethernet-phy.yaml#
           unevaluatedProperties: false

> +        description: |
> +          PHY node for the embedded or external PHY. The PHY address is
> +          given by the 'reg' property.

Drop. That's true for every MDIO bus.

> +
> +        properties:
> +          reg:
> +            maxItems: 1
> +            description: PHY address.
> +
> +          microchip,led-modes:
> +            $ref: /schemas/types.yaml#/definitions/uint32-array
> +            minItems: 1
> +            maxItems: 4
> +            description:
> +              Array of LED mode values for each of up to 4 LEDs.
> +              Omitted LEDs are turned off. Allowed values are defined
> +              in include/dt-bindings/net/microchip-lan78xx.h.
> +
> +        required:
> +          - reg
> +
> +        additionalProperties: false
> +
> +required:
> +  - compatible
> +  - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> +  - |
> +    #include <dt-bindings/net/microchip-lan78xx.h>
> +    / {

Drop root node.

> +        usb {
> +            compatible = "usb-host";

Drop fake compatibles.

> +            #address-cells = <1>;
> +            #size-cells = <0>;
> +
> +            ethernet@1 {
> +                compatible = "usb424,7800";
> +                reg = <1>;
> +                local-mac-address = [00 11 22 33 44 55];
> +
> +                mdio {
> +                    #address-cells = <1>;
> +                    #size-cells = <0>;
> +                    ethernet-phy@1 {
> +                        reg = <1>;
> +                        microchip,led-modes = <
> +                            LAN78XX_LINK_1000_ACTIVITY
> +                            LAN78XX_LINK_10_100_ACTIVITY
> +                        >;
> +                    };
> +                };
> +            };
> +        };
> +    };
> +...