Re: [PATCH 21/22] arm64: dts: qcom: qcs6490-rb3gen2: Fix the PCIe iommu-map entries

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:

Pre-existing issues:
- [Medium] The fix for malformed `iommu-map` entries is incomplete because it misses the `qcs6490-rb3gen2-industrial-mezzanine.dtso` overlay, which contains identically malformed entries.
--

--- Patch [21]: [PATCH 21/22] arm64: dts: qcom: qcs6490-rb3gen2: Fix the PCIe iommu-map entries ---
commit b18d2572691fe332011993576c307feac443dbbf
Author: Manivannan Sadhasivam <manivannan.sadhasivam@oss.qualcomm.com>

arm64: dts: qcom: qcs6490-rb3gen2: Fix the PCIe iommu-map entries

This commit fixes malformed iommu-map entries for PCIe nodes in the
qcs6490-rb3gen2 device tree by adding the missing SID mask cell to match
the apps_smmu provider's 2-cell requirement.

> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts

[ ... ]

> @@ -846,15 +846,15 @@ &pcie1 {
>  	pinctrl-0 = <&pcie1_reset_n>, <&pcie1_wake_n>, <&pcie1_clkreq_n>;
>  	pinctrl-names = "default";
>  
> -	iommu-map = <0x0 &apps_smmu 0x1c80 0x1>,
> -		    <0x100 &apps_smmu 0x1c81 0x1>,

[ ... ]

> +	iommu-map = <0x0 &apps_smmu 0x1c80 0x0 0x1>,
> +		    <0x100 &apps_smmu 0x1c81 0x0 0x1>,

[Severity: Medium]
This is a pre-existing issue, but does this fix also need to be applied to
the qcs6490-rb3gen2-industrial-mezzanine.dtso overlay?

Looking at the mezzanine overlay file, it appears to contain identically
malformed iommu-map entries missing the 0x0 mask cell for both &pcie0
and &pcie1:

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:&pcie0 {
	...
	iommu-map = <0x0 &apps_smmu 0x1c00 0x1>,
	...
}

arch/arm64/boot/dts/qcom/qcs6490-rb3gen2-industrial-mezzanine.dtso:&pcie1 {
	...
	iommu-map = <0x0 &apps_smmu 0x1c80 0x1>,
	...
}

Will the OF core still warn and potentially misparse these entries when
booting a device with the industrial mezzanine overlay applied?

> +		    <0x208 &apps_smmu 0x1c84 0x0 0x1>,

[ ... ]

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-iommu-map-fix-v1-0-83405d37ba41@oss.qualcomm.com?part=21