Re: [PATCH 18/19] arm64: dts: apple: t8112: Add USB4 ACIO and NHI

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] The device tree references an undefined label `cio_reset`, resulting in a fatal `dtc` compilation error.
--

commit b642ea767536f5c5b53c872de870f2221d25f380
Author: Sven Peter <sven@kernel.org>

arm64: dts: apple: t8112: Add USB4 ACIO and NHI

This commit adds the ACIO host router, NHI, DART and mailbox nodes for both
Type-C ports on t8112 and connects the host routers to the Type-C connectors.

> diff --git a/arch/arm64/boot/dts/apple/t8112.dtsi b/arch/arm64/boot/dts/apple/t8112.dtsi
> index ec248ca052cb2..735ca3b8b7164 100644
> --- a/arch/arm64/boot/dts/apple/t8112.dtsi
> +++ b/arch/arm64/boot/dts/apple/t8112.dtsi
[ ... ]
> +		usb4_0_acio: cio@381ac0000 {
> +			compatible = "apple,t8112-usb4-acio", "apple,t8103-usb4-acio";
> +			reg = <0x3 0x81ac0000 0x0 0xc000>,
> +				<0x3 0x81080000 0x0 0x20000>;
> +			reg-names = "rc", "sram";
> +
> +			mboxes = <&usb4_0_mbox>;
> +			resets = <&cio_reset 0>;

[Severity: Low]
Does this device tree compile successfully? It appears that the cio_reset
label is undefined, which will cause a fatal dtc compilation error when
building the device tree binaries for the Apple arm64 platforms containing
the usb4_0_acio node.

> +
> +			power-domains = <&ps_atc0_cio>,
[ ... ]
> +		usb4_1_acio: cio@501ac0000 {
> +			compatible = "apple,t8112-usb4-acio", "apple,t8103-usb4-acio";
> +			reg = <0x5 0x01ac0000 0x0 0xc000>,
> +				<0x5 0x01080000 0x0 0x20000>;
> +			reg-names = "rc", "sram";
> +
> +			mboxes = <&usb4_1_mbox>;
> +			resets = <&cio_reset 1>;

[Severity: Low]
This reference in the usb4_1_acio node also points to the undefined
cio_reset label.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260830-b4-apple-soc-tbt-v1-0-44bc9348683c@kernel.org?part=18