[PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[Jisheng Zhang]

Add the compatible for the UARTs of the Synaptics SL2610, which are
compatible with the Synopsys DesignWare APB UART.

Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
---

since v1:
 - use sl2610 instead of sl261x
 - send as a separate patch

 .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
 1 file changed, 11 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
index 664305de4986..a40f2737e71b 100644
--- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
+++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
@@ -34,7 +34,16 @@ allOf:
       properties:
         resets:
           minItems: 2
-    else:
+
+  - if:
+      not:
+        properties:
+          compatible:
+            contains:
+              enum:
+                - starfive,jh7110-uart
+                - syna,sl2610-uart
+    then:
       properties:
         resets:
           maxItems: 1
@@ -80,6 +89,7 @@ properties:
               - starfive,jh7100-hsuart
               - starfive,jh7100-uart
               - starfive,jh7110-uart
+              - syna,sl2610-uart
               - ultrarisc,dp1000-uart
           - const: snps,dw-apb-uart
       - const: snps,dw-apb-uart
-- 
2.53.0

Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] dt-bindings: missing minItems: 2 constraint for syna,sl2610-uart resets
--

commit d2c2a625dcf17e541f9ec792d85888075ee11605
Author: Jisheng Zhang <jszhang@kernel.org>

dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

Add the compatible for the UARTs of the Synaptics SL2610, which are
compatible with the Synopsys DesignWare APB UART.

> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 664305de4986f..a40f2737e71b5 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -34,7 +34,16 @@ allOf:
>        properties:
>          resets:
>            minItems: 2
> -    else:
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - starfive,jh7110-uart
> +                - syna,sl2610-uart

[Severity: Low]
Does this compatible string also need to be added to the if-then block
enforcing the minItems: 2 constraint?

This block explicitly exempts syna,sl2610-uart from the maxItems: 1 
single-reset constraint, indicating it requires 2 resets. However, the 
block immediately above this (which enforces minItems: 2 for 
starfive,jh7110-uart) was not updated to include syna,sl2610-uart.

As a result, device trees for syna,sl2610-uart with only 1 reset will
silently pass schema validation.

> +    then:
>        properties:
>          resets:
>            maxItems: 1

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261005151918.25259-1-jszhang@kernel.org?part=1

Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1601 bytes --]

On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote:
> Add the compatible for the UARTs of the Synaptics SL2610, which are
> compatible with the Synopsys DesignWare APB UART.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> 
> since v1:
>  - use sl2610 instead of sl261x
>  - send as a separate patch
> 
>  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> index 664305de4986..a40f2737e71b 100644
> --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> @@ -34,7 +34,16 @@ allOf:
>        properties:
>          resets:
>            minItems: 2
> -    else:
> +
> +  - if:
> +      not:
> +        properties:
> +          compatible:
> +            contains:
> +              enum:
> +                - starfive,jh7110-uart
> +                - syna,sl2610-uart

Is the number of uart resets on this device variable?

> +    then:
>        properties:
>          resets:
>            maxItems: 1
> @@ -80,6 +89,7 @@ properties:
>                - starfive,jh7100-hsuart
>                - starfive,jh7100-uart
>                - starfive,jh7110-uart
> +              - syna,sl2610-uart
>                - ultrarisc,dp1000-uart
>            - const: snps,dw-apb-uart
>        - const: snps,dw-apb-uart
> -- 
> 2.53.0
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[Jisheng Zhang]

On Wed, Oct 07, 2026 at 02:04:05PM +0100, Conor Dooley wrote:
> On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote:
> > Add the compatible for the UARTs of the Synaptics SL2610, which are
> > compatible with the Synopsys DesignWare APB UART.
> > 
> > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > ---
> > 
> > since v1:
> >  - use sl2610 instead of sl261x
> >  - send as a separate patch
> > 
> >  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
> >  1 file changed, 11 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > index 664305de4986..a40f2737e71b 100644
> > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > @@ -34,7 +34,16 @@ allOf:
> >        properties:
> >          resets:
> >            minItems: 2
> > -    else:
> > +
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              enum:
> > +                - starfive,jh7110-uart
> > +                - syna,sl2610-uart
> 
> Is the number of uart resets on this device variable?

Yes, some uarts have only 1 reset, while others have two resets.

> 
> > +    then:
> >        properties:
> >          resets:
> >            maxItems: 1
> > @@ -80,6 +89,7 @@ properties:
> >                - starfive,jh7100-hsuart
> >                - starfive,jh7100-uart
> >                - starfive,jh7110-uart
> > +              - syna,sl2610-uart
> >                - ultrarisc,dp1000-uart
> >            - const: snps,dw-apb-uart
> >        - const: snps,dw-apb-uart
> > -- 
> > 2.53.0
> > 

Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 2188 bytes --]

On Thu, Oct 08, 2026 at 09:49:07PM +0800, Jisheng Zhang wrote:
> On Wed, Oct 07, 2026 at 02:04:05PM +0100, Conor Dooley wrote:
> > On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote:
> > > Add the compatible for the UARTs of the Synaptics SL2610, which are
> > > compatible with the Synopsys DesignWare APB UART.
> > > 
> > > Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> > > ---
> > > 
> > > since v1:
> > >  - use sl2610 instead of sl261x
> > >  - send as a separate patch
> > > 
> > >  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
> > >  1 file changed, 11 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > > index 664305de4986..a40f2737e71b 100644
> > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml
> > > @@ -34,7 +34,16 @@ allOf:
> > >        properties:
> > >          resets:
> > >            minItems: 2
> > > -    else:
> > > +
> > > +  - if:
> > > +      not:
> > > +        properties:
> > > +          compatible:
> > > +            contains:
> > > +              enum:
> > > +                - starfive,jh7110-uart
> > > +                - syna,sl2610-uart
> > 
> > Is the number of uart resets on this device variable?
> 
> Yes, some uarts have only 1 reset, while others have two resets.

In the future, please mention this so it doesn't look like an oversight.
Acked-by: Conor Dooley <conor.dooley@microchip.com>
pw-bot: not-applicable

Thanks,
Conor.

> 
> > 
> > > +    then:
> > >        properties:
> > >          resets:
> > >            maxItems: 1
> > > @@ -80,6 +89,7 @@ properties:
> > >                - starfive,jh7100-hsuart
> > >                - starfive,jh7100-uart
> > >                - starfive,jh7110-uart
> > > +              - syna,sl2610-uart
> > >                - ultrarisc,dp1000-uart
> > >            - const: snps,dw-apb-uart
> > >        - const: snps,dw-apb-uart
> > > -- 
> > > 2.53.0
> > > 
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] dt-bindings: serial: snps-dw-apb-uart: Add Synaptics sl2610 uart

[Greg Kroah-Hartman]

On Mon, Oct 05, 2026 at 11:19:18PM +0800, Jisheng Zhang wrote:
> Add the compatible for the UARTs of the Synaptics SL2610, which are
> compatible with the Synopsys DesignWare APB UART.
> 
> Signed-off-by: Jisheng Zhang <jszhang@kernel.org>
> ---
> 
> since v1:
>  - use sl2610 instead of sl261x
>  - send as a separate patch
> 
>  .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)

Does not apply to the tty-testing branch :(