* [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
@ 2022-09-12 19:26 Horatiu Vultur
2022-09-13 7:18 ` Michael Walle
2022-09-13 7:18 ` Claudiu.Beznea
0 siblings, 2 replies; 6+ messages in thread
From: Horatiu Vultur @ 2022-09-12 19:26 UTC (permalink / raw)
To: devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, claudiu.beznea, nicolas.ferre,
michael, Horatiu Vultur
According to the datasheet the interrupts for internal PHYs are
80 and 81.
Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
---
arch/arm/boot/dts/lan966x.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
index bcb130a2471d..23665a042990 100644
--- a/arch/arm/boot/dts/lan966x.dtsi
+++ b/arch/arm/boot/dts/lan966x.dtsi
@@ -547,13 +547,13 @@ mdio1: mdio@e200413c {
phy0: ethernet-phy@1 {
reg = <1>;
- interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
phy1: ethernet-phy@2 {
reg = <2>;
- interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
+ interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
status = "disabled";
};
};
--
2.33.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
2022-09-12 19:26 [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs Horatiu Vultur
@ 2022-09-13 7:18 ` Michael Walle
2022-09-13 7:57 ` Horatiu Vultur
2022-09-13 7:18 ` Claudiu.Beznea
1 sibling, 1 reply; 6+ messages in thread
From: Michael Walle @ 2022-09-13 7:18 UTC (permalink / raw)
To: Horatiu Vultur
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
claudiu.beznea, nicolas.ferre
Hi Horatiu,
Am 2022-09-12 21:26, schrieb Horatiu Vultur:
> According to the datasheet the interrupts for internal PHYs are
> 80 and 81.
Can you point me to that documentation?
Accoring to Table 3-155: Shared Peripheral Interrupts
There are ID47 and ID48 listed as "MIIM controller 0 interrupt".
Whatever that is, because the internal PHYs are on MIIM
controller 1.
But 80 and 81 would be ID48 and ID49. Did you test the
interrupts?
-michael
> Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> ---
> arch/arm/boot/dts/lan966x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi
> b/arch/arm/boot/dts/lan966x.dtsi
> index bcb130a2471d..23665a042990 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -547,13 +547,13 @@ mdio1: mdio@e200413c {
>
> phy0: ethernet-phy@1 {
> reg = <1>;
> - interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
>
> phy1: ethernet-phy@2 {
> reg = <2>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
2022-09-13 7:18 ` Michael Walle
@ 2022-09-13 7:57 ` Horatiu Vultur
2022-09-13 8:00 ` Michael Walle
0 siblings, 1 reply; 6+ messages in thread
From: Horatiu Vultur @ 2022-09-13 7:57 UTC (permalink / raw)
To: Michael Walle
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
claudiu.beznea, nicolas.ferre
The 09/13/2022 09:18, Michael Walle wrote:
>
> Hi Horatiu,
Hi Walle,
>
> Am 2022-09-12 21:26, schrieb Horatiu Vultur:
> > According to the datasheet the interrupts for internal PHYs are
> > 80 and 81.
>
> Can you point me to that documentation?
I have not found yet one on the microchip.com
>
> Accoring to Table 3-155: Shared Peripheral Interrupts
> There are ID47 and ID48 listed as "MIIM controller 0 interrupt".
> Whatever that is, because the internal PHYs are on MIIM
> controller 1.
>
> But 80 and 81 would be ID48 and ID49. Did you test the
> interrupts?
Looking the same table (3-155) in the documentation that I have these
interrupts correspond to ID112 and ID113 (Embedded CuPHY port 0/1 interrupt).
And because these are shared peripheral interrupts, it is required to
substract 32. Therefore I got the numbers 80 and 81.
As the internal PHYs don't have yet interrupt support, I have sent a
patch here [1] and I have tested it with this.
[1] https://www.spinics.net/lists/kernel/msg4511731.html
>
> -michael
>
> > Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
> > Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
> > ---
> > arch/arm/boot/dts/lan966x.dtsi | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/lan966x.dtsi
> > b/arch/arm/boot/dts/lan966x.dtsi
> > index bcb130a2471d..23665a042990 100644
> > --- a/arch/arm/boot/dts/lan966x.dtsi
> > +++ b/arch/arm/boot/dts/lan966x.dtsi
> > @@ -547,13 +547,13 @@ mdio1: mdio@e200413c {
> >
> > phy0: ethernet-phy@1 {
> > reg = <1>;
> > - interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> > status = "disabled";
> > };
> >
> > phy1: ethernet-phy@2 {
> > reg = <2>;
> > - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> > + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> > status = "disabled";
> > };
> > };
--
/Horatiu
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
2022-09-13 7:57 ` Horatiu Vultur
@ 2022-09-13 8:00 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-09-13 8:00 UTC (permalink / raw)
To: Horatiu Vultur
Cc: devicetree, linux-kernel, robh+dt, krzysztof.kozlowski+dt,
claudiu.beznea, nicolas.ferre
Am 2022-09-13 09:57, schrieb Horatiu Vultur:
>> Accoring to Table 3-155: Shared Peripheral Interrupts
>> There are ID47 and ID48 listed as "MIIM controller 0 interrupt".
>> Whatever that is, because the internal PHYs are on MIIM
>> controller 1.
>>
>> But 80 and 81 would be ID48 and ID49. Did you test the
>> interrupts?
>
> Looking the same table (3-155) in the documentation that I have these
> interrupts correspond to ID112 and ID113 (Embedded CuPHY port 0/1
> interrupt).
> And because these are shared peripheral interrupts, it is required to
> substract 32. Therefore I got the numbers 80 and 81.
Ahh, I need more coffee :) Yes you are right.
> As the internal PHYs don't have yet interrupt support, I have sent a
> patch here [1] and I have tested it with this.
>
> [1] https://www.spinics.net/lists/kernel/msg4511731.html
Thanks for the pointer!
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
2022-09-12 19:26 [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs Horatiu Vultur
2022-09-13 7:18 ` Michael Walle
@ 2022-09-13 7:18 ` Claudiu.Beznea
2022-09-13 7:24 ` Michael Walle
1 sibling, 1 reply; 6+ messages in thread
From: Claudiu.Beznea @ 2022-09-13 7:18 UTC (permalink / raw)
To: Horatiu.Vultur, devicetree, linux-kernel
Cc: robh+dt, krzysztof.kozlowski+dt, Nicolas.Ferre, michael
On 12.09.2022 22:26, Horatiu Vultur wrote:
> According to the datasheet the interrupts for internal PHYs are
> 80 and 81.
>
> Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
Applied to at91-fixes, thanks!
> ---
> arch/arm/boot/dts/lan966x.dtsi | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/lan966x.dtsi b/arch/arm/boot/dts/lan966x.dtsi
> index bcb130a2471d..23665a042990 100644
> --- a/arch/arm/boot/dts/lan966x.dtsi
> +++ b/arch/arm/boot/dts/lan966x.dtsi
> @@ -547,13 +547,13 @@ mdio1: mdio@e200413c {
>
> phy0: ethernet-phy@1 {
> reg = <1>;
> - interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
>
> phy1: ethernet-phy@2 {
> reg = <2>;
> - interrupts = <GIC_SPI 82 IRQ_TYPE_LEVEL_HIGH>;
> + interrupts = <GIC_SPI 81 IRQ_TYPE_LEVEL_HIGH>;
> status = "disabled";
> };
> };
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs
2022-09-13 7:18 ` Claudiu.Beznea
@ 2022-09-13 7:24 ` Michael Walle
0 siblings, 0 replies; 6+ messages in thread
From: Michael Walle @ 2022-09-13 7:24 UTC (permalink / raw)
To: Claudiu.Beznea
Cc: Horatiu.Vultur, devicetree, linux-kernel, robh+dt,
krzysztof.kozlowski+dt, Nicolas.Ferre
Am 2022-09-13 09:18, schrieb Claudiu.Beznea@microchip.com:
> On 12.09.2022 22:26, Horatiu Vultur wrote:
>> According to the datasheet the interrupts for internal PHYs are
>> 80 and 81.
>>
>> Fixes: 6ad69e07def67c ("ARM: dts: lan966x: add MIIM nodes")
>> Signed-off-by: Horatiu Vultur <horatiu.vultur@microchip.com>
>
> Applied to at91-fixes, thanks!
I'm not sure the fix is correct, though.
-michael
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-09-13 8:00 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-09-12 19:26 [PATCH] ARM: dts: lan966x: Fix the interrupt number for internal PHYs Horatiu Vultur
2022-09-13 7:18 ` Michael Walle
2022-09-13 7:57 ` Horatiu Vultur
2022-09-13 8:00 ` Michael Walle
2022-09-13 7:18 ` Claudiu.Beznea
2022-09-13 7:24 ` Michael Walle
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox