[PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krishna Kurapati]

Currently for Glymur non-multiport USB controllers, number of interrupts
are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
present.

Mark glymur non-multiport controllers to support a maximum of 6 interrupts
including the hs_phy_irq and ss_phy_irq.

Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
---
Changes in v2:
- Modified commit text indicating the issue in max interrupt-names for
  Glymur non-mp controllers.

Link to v1:
https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
---
 Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
index ea60f7220afe..3bef18f9557e 100644
--- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
+++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
@@ -524,7 +524,6 @@ allOf:
         compatible:
           contains:
             enum:
-              - qcom,glymur-dwc3
               - qcom,milos-dwc3
               - qcom,x1e80100-dwc3
     then:
@@ -547,6 +546,7 @@ allOf:
           contains:
             enum:
               - qcom,eliza-dwc3
+              - qcom,glymur-dwc3
               - qcom,ipq4019-dwc3
               - qcom,ipq8064-dwc3
               - qcom,kaanapali-dwc3
-- 
2.34.1

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] Moving `qcom,glymur-dwc3` to a different `if-then` conditional block changes the positional requirements of the `interrupt-names` array, breaking ABI and schema validation for existing device trees.
--

commit 15d826b7f9c1b0ac7d9038a76e721573a86a768f
Author: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>

dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

This commit modifies the device tree binding for the Glymur non-multiport
USB controllers to allow a maximum of 6 interrupts. It moves the compatible
string to a different conditional block to accommodate both hs_phy_irq and
ss_phy_irq.

Link: https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/

> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index ea60f7220afe3..3bef18f9557e1 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml

[ ... ]

> @@ -547,6 +546,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,eliza-dwc3
> +              - qcom,glymur-dwc3

[Severity: High]
Does moving this compatible string to the qcom,eliza-dwc3 conditional block
inadvertently break the device tree schema ABI for existing platforms?

The original qcom,milos-dwc3 block matched the baseline interrupt sequence
used by existing device trees, requiring dp_hs_phy_irq at index 2:

allOf / if block for qcom,milos-dwc3:
        interrupt-names:
          minItems: 4
          items:
            - const: dwc_usb3
            - const: pwr_event
            - const: dp_hs_phy_irq

The target qcom,eliza-dwc3 block imposes a different positional requirement,
expecting hs_phy_irq at index 2 and dp_hs_phy_irq at index 3:

allOf / if block for qcom,eliza-dwc3:
        interrupt-names:
          minItems: 5
          items:
            - const: dwc_usb3
            - const: pwr_event
            - const: hs_phy_irq
            - const: dp_hs_phy_irq

Looking at existing configurations, such as usb_0 in
arch/arm64/boot/dts/qcom/glymur.dtsi, the layout defines dp_hs_phy_irq
as the third interrupt:

arch/arm64/boot/dts/qcom/glymur.dtsi:usb_0 {
                interrupt-names = "dwc_usb3",
                                  "pwr_event",
                                  "dp_hs_phy_irq",
                                  "dm_hs_phy_irq",
                                  "ss_phy_irq";
}

Since JSON schema arrays evaluate items positionally, won't this change
cause existing in-tree device trees to fail dtbs_check validation?

>                - qcom,ipq4019-dwc3
>                - qcom,ipq8064-dwc3
>                - qcom,kaanapali-dwc3

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260828081542.52796-1-krishna.kurapati@oss.qualcomm.com?part=1

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski]

On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
> Currently for Glymur non-multiport USB controllers, number of interrupts
> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
> present.
> 
> Mark glymur non-multiport controllers to support a maximum of 6 interrupts
> including the hs_phy_irq and ss_phy_irq.

Why?

> 
> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
> ---
> Changes in v2:
> - Modified commit text indicating the issue in max interrupt-names for
>   Glymur non-mp controllers.
> 
> Link to v1:
> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
> ---
>  Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> index ea60f7220afe..3bef18f9557e 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
> @@ -524,7 +524,6 @@ allOf:
>          compatible:
>            contains:
>              enum:
> -              - qcom,glymur-dwc3
>                - qcom,milos-dwc3
>                - qcom,x1e80100-dwc3
>      then:
> @@ -547,6 +546,7 @@ allOf:
>            contains:
>              enum:
>                - qcom,eliza-dwc3
> +              - qcom,glymur-dwc3
>                - qcom,ipq4019-dwc3
>                - qcom,ipq8064-dwc3
>                - qcom,kaanapali-dwc3

This changes the ABI without an explanation.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krishna Kurapati]

On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>> Currently for Glymur non-multiport USB controllers, number of interrupts
>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>> present.
>>
>> Mark glymur non-multiport controllers to support a maximum of 6 interrupts
>> including the hs_phy_irq and ss_phy_irq.
> 
> Why?
> 
>>
>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>> ---
>> Changes in v2:
>> - Modified commit text indicating the issue in max interrupt-names for
>>    Glymur non-mp controllers.
>>
>> Link to v1:
>> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
>> ---
>>   Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> index ea60f7220afe..3bef18f9557e 100644
>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>> @@ -524,7 +524,6 @@ allOf:
>>           compatible:
>>             contains:
>>               enum:
>> -              - qcom,glymur-dwc3
>>                 - qcom,milos-dwc3
>>                 - qcom,x1e80100-dwc3
>>       then:
>> @@ -547,6 +546,7 @@ allOf:
>>             contains:
>>               enum:
>>                 - qcom,eliza-dwc3
>> +              - qcom,glymur-dwc3
>>                 - qcom,ipq4019-dwc3
>>                 - qcom,ipq8064-dwc3
>>                 - qcom,kaanapali-dwc3
> 
> This changes the ABI without an explanation.
> 
As per the harware specification, the controllers do have both 
hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that 
info. Will update the commit message accordingly.

Regards,
Krishna,

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski]

On 31/08/2026 11:03, Krishna Kurapati wrote:
> 
> 
> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>> present.
>>>
>>> Mark glymur non-multiport controllers to support a maximum of 6 interrupts
>>> including the hs_phy_irq and ss_phy_irq.
>>
>> Why?
>>
>>>
>>> Signed-off-by: Krishna Kurapati <krishna.kurapati@oss.qualcomm.com>
>>> ---
>>> Changes in v2:
>>> - Modified commit text indicating the issue in max interrupt-names for
>>>    Glymur non-mp controllers.
>>>
>>> Link to v1:
>>> https://lore.kernel.org/all/20260803-glymur-usb-binding-fixes-v1-1-9ce334777387@oss.qualcomm.com/
>>> ---
>>>   Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml | 2 +-
>>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> index ea60f7220afe..3bef18f9557e 100644
>>> --- a/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> +++ b/Documentation/devicetree/bindings/usb/qcom,snps-dwc3.yaml
>>> @@ -524,7 +524,6 @@ allOf:
>>>           compatible:
>>>             contains:
>>>               enum:
>>> -              - qcom,glymur-dwc3
>>>                 - qcom,milos-dwc3
>>>                 - qcom,x1e80100-dwc3
>>>       then:
>>> @@ -547,6 +546,7 @@ allOf:
>>>             contains:
>>>               enum:
>>>                 - qcom,eliza-dwc3
>>> +              - qcom,glymur-dwc3
>>>                 - qcom,ipq4019-dwc3
>>>                 - qcom,ipq8064-dwc3
>>>                 - qcom,kaanapali-dwc3
>>
>> This changes the ABI without an explanation.
>>
> As per the harware specification, the controllers do have both 
> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that 
> info. Will update the commit message accordingly.
> 

So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
incomplete? Lack of context here is not helping.

If they have these IRQs but it does not matter, then it is not a good
reason to change ABI and you should just add the clock as optional to
the end. Was this binding already released? I think yes.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Konrad Dybcio]

On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>
>>
>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>> present.

[...]

>>>>                 - qcom,eliza-dwc3
>>>> +              - qcom,glymur-dwc3
>>>>                 - qcom,ipq4019-dwc3
>>>>                 - qcom,ipq8064-dwc3
>>>>                 - qcom,kaanapali-dwc3
>>>
>>> This changes the ABI without an explanation.
>>>
>> As per the harware specification, the controllers do have both 
>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that 
>> info. Will update the commit message accordingly.
>>
> 
> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
> incomplete? Lack of context here is not helping.
> 
> If they have these IRQs but it does not matter, then it is not a good
> reason to change ABI and you should just add the clock as optional to
> the end. Was this binding already released? I think yes.

IIUC the intent of the patch is to allow specifying the currently
missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
Bundling the DT change would have made that easier.

Konrad

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krishna Kurapati]

On 9/2/2026 7:40 PM, Konrad Dybcio wrote:
> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>
>>>
>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>> present.
> 
> [...]
> 
>>>>>                  - qcom,eliza-dwc3
>>>>> +              - qcom,glymur-dwc3
>>>>>                  - qcom,ipq4019-dwc3
>>>>>                  - qcom,ipq8064-dwc3
>>>>>                  - qcom,kaanapali-dwc3
>>>>
>>>> This changes the ABI without an explanation.
>>>>
>>> As per the harware specification, the controllers do have both
>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>> info. Will update the commit message accordingly.
>>>
>>
>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>> incomplete? Lack of context here is not helping.
>>
>> If they have these IRQs but it does not matter, then it is not a good
>> reason to change ABI and you should just add the clock as optional to
>> the end. Was this binding already released? I think yes.
> 
> IIUC the intent of the patch is to allow specifying the currently
> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
> Bundling the DT change would have made that easier.
Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in 
the DT along with the usb binding changes. DT change was posted separately:

https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/

Regards,
Krishna,

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Konrad Dybcio]

On 9/2/26 6:59 PM, Krishna Kurapati wrote:
> 
> 
> On 9/2/2026 7:40 PM, Konrad Dybcio wrote:
>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>>
>>>>
>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>>> present.
>>
>> [...]
>>
>>>>>>                  - qcom,eliza-dwc3
>>>>>> +              - qcom,glymur-dwc3
>>>>>>                  - qcom,ipq4019-dwc3
>>>>>>                  - qcom,ipq8064-dwc3
>>>>>>                  - qcom,kaanapali-dwc3
>>>>>
>>>>> This changes the ABI without an explanation.
>>>>>
>>>> As per the harware specification, the controllers do have both
>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>>> info. Will update the commit message accordingly.
>>>>
>>>
>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>>> incomplete? Lack of context here is not helping.
>>>
>>> If they have these IRQs but it does not matter, then it is not a good
>>> reason to change ABI and you should just add the clock as optional to
>>> the end. Was this binding already released? I think yes.
>>
>> IIUC the intent of the patch is to allow specifying the currently
>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
>> Bundling the DT change would have made that easier.
> Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately:
> 
> https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/

Shipping bindings and DT changes in a _series_ is preferred, what one
must avoid is changing them within the same _patch_

Konrad

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski]

On 03/09/2026 08:32, Konrad Dybcio wrote:
> On 9/2/26 6:59 PM, Krishna Kurapati wrote:
>>
>>
>> On 9/2/2026 7:40 PM, Konrad Dybcio wrote:
>>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>>>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>>>
>>>>>
>>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>>>> present.
>>>
>>> [...]
>>>
>>>>>>>                  - qcom,eliza-dwc3
>>>>>>> +              - qcom,glymur-dwc3
>>>>>>>                  - qcom,ipq4019-dwc3
>>>>>>>                  - qcom,ipq8064-dwc3
>>>>>>>                  - qcom,kaanapali-dwc3
>>>>>>
>>>>>> This changes the ABI without an explanation.
>>>>>>
>>>>> As per the harware specification, the controllers do have both
>>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>>>> info. Will update the commit message accordingly.
>>>>>
>>>>
>>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>>>> incomplete? Lack of context here is not helping.
>>>>
>>>> If they have these IRQs but it does not matter, then it is not a good
>>>> reason to change ABI and you should just add the clock as optional to
>>>> the end. Was this binding already released? I think yes.
>>>
>>> IIUC the intent of the patch is to allow specifying the currently
>>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
>>> Bundling the DT change would have made that easier.
>> Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately:
>>
>> https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/
> 
> Shipping bindings and DT changes in a _series_ is preferred, what one
> must avoid is changing them within the same _patch_

No, DTS cannot be posted within USB patchset.

Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Konrad Dybcio]

On 9/3/26 8:40 AM, Krzysztof Kozlowski wrote:
> On 03/09/2026 08:32, Konrad Dybcio wrote:
>> On 9/2/26 6:59 PM, Krishna Kurapati wrote:
>>>
>>>
>>> On 9/2/2026 7:40 PM, Konrad Dybcio wrote:
>>>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>>>>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>>>>
>>>>>>
>>>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>>>>> present.
>>>>
>>>> [...]
>>>>
>>>>>>>>                  - qcom,eliza-dwc3
>>>>>>>> +              - qcom,glymur-dwc3
>>>>>>>>                  - qcom,ipq4019-dwc3
>>>>>>>>                  - qcom,ipq8064-dwc3
>>>>>>>>                  - qcom,kaanapali-dwc3
>>>>>>>
>>>>>>> This changes the ABI without an explanation.
>>>>>>>
>>>>>> As per the harware specification, the controllers do have both
>>>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>>>>> info. Will update the commit message accordingly.
>>>>>>
>>>>>
>>>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>>>>> incomplete? Lack of context here is not helping.
>>>>>
>>>>> If they have these IRQs but it does not matter, then it is not a good
>>>>> reason to change ABI and you should just add the clock as optional to
>>>>> the end. Was this binding already released? I think yes.
>>>>
>>>> IIUC the intent of the patch is to allow specifying the currently
>>>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
>>>> Bundling the DT change would have made that easier.
>>> Yes, I wanted to add the missing hs_phy_irq. I didn't want to bundle in the DT along with the usb binding changes. DT change was posted separately:
>>>
>>> https://lore.kernel.org/all/20260803-glymur-dt-usb-fixes-v1-1-0f5f52853102@oss.qualcomm.com/
>>
>> Shipping bindings and DT changes in a _series_ is preferred, what one
>> must avoid is changing them within the same _patch_
> 
> No, DTS cannot be posted within USB patchset.

Aah, I missed that point..

Konrad

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski]

On 02/09/2026 16:10, Konrad Dybcio wrote:
> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>
>>>
>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>> present.
> 
> [...]
> 
>>>>>                 - qcom,eliza-dwc3
>>>>> +              - qcom,glymur-dwc3
>>>>>                 - qcom,ipq4019-dwc3
>>>>>                 - qcom,ipq8064-dwc3
>>>>>                 - qcom,kaanapali-dwc3
>>>>
>>>> This changes the ABI without an explanation.
>>>>
>>> As per the harware specification, the controllers do have both 
>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that 
>>> info. Will update the commit message accordingly.
>>>
>>
>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>> incomplete? Lack of context here is not helping.
>>
>> If they have these IRQs but it does not matter, then it is not a good
>> reason to change ABI and you should just add the clock as optional to
>> the end. Was this binding already released? I think yes.
> 
> IIUC the intent of the patch is to allow specifying the currently
> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
> Bundling the DT change would have made that easier.

This does not answer my concerns. So repeating: patch is changing ABI
without an explanation. This means contributor needs to provide
explanation for the ABI change in terms of actual impact.


Best regards,
Krzysztof

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krishna Kurapati]

On 9/3/2026 12:11 PM, Krzysztof Kozlowski wrote:
> On 02/09/2026 16:10, Konrad Dybcio wrote:
>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>>
>>>>
>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>>> present.
>>
>> [...]
>>
>>>>>>                  - qcom,eliza-dwc3
>>>>>> +              - qcom,glymur-dwc3
>>>>>>                  - qcom,ipq4019-dwc3
>>>>>>                  - qcom,ipq8064-dwc3
>>>>>>                  - qcom,kaanapali-dwc3
>>>>>
>>>>> This changes the ABI without an explanation.
>>>>>
>>>> As per the harware specification, the controllers do have both
>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>>> info. Will update the commit message accordingly.
>>>>
>>>
>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>>> incomplete? Lack of context here is not helping.
>>>
>>> If they have these IRQs but it does not matter, then it is not a good
>>> reason to change ABI and you should just add the clock as optional to
>>> the end. Was this binding already released? I think yes.
>>
>> IIUC the intent of the patch is to allow specifying the currently
>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
>> Bundling the DT change would have made that easier.
> 
> This does not answer my concerns. So repeating: patch is changing ABI
> without an explanation. This means contributor needs to provide
> explanation for the ABI change in terms of actual impact.
> 
 From a functional standpoint, there would be no effect. I was trying to 
make the bindings reflect that the hardware has hs_phy_irq.

Regards,
Krishna,

Re: [PATCH v2] dt-bindings: usb: qcom,snps-dwc3: Fix glymur binding for non-MP controllers

[Krzysztof Kozlowski]

On 03/09/2026 10:11, Krishna Kurapati wrote:
> 
> 
> On 9/3/2026 12:11 PM, Krzysztof Kozlowski wrote:
>> On 02/09/2026 16:10, Konrad Dybcio wrote:
>>> On 8/31/26 2:29 PM, Krzysztof Kozlowski wrote:
>>>> On 31/08/2026 11:03, Krishna Kurapati wrote:
>>>>>
>>>>>
>>>>> On 8/31/2026 2:07 PM, Krzysztof Kozlowski wrote:
>>>>>> On Fri, Aug 28, 2026 at 01:45:42PM +0530, Krishna Kurapati wrote:
>>>>>>> Currently for Glymur non-multiport USB controllers, number of interrupts
>>>>>>> are limited to a maximum of "5". Either hs_phy_irq or ss_phy_irq are to be
>>>>>>> present.
>>>
>>> [...]
>>>
>>>>>>>                  - qcom,eliza-dwc3
>>>>>>> +              - qcom,glymur-dwc3
>>>>>>>                  - qcom,ipq4019-dwc3
>>>>>>>                  - qcom,ipq8064-dwc3
>>>>>>>                  - qcom,kaanapali-dwc3
>>>>>>
>>>>>> This changes the ABI without an explanation.
>>>>>>
>>>>> As per the harware specification, the controllers do have both
>>>>> hs_phy_irq and ss_phy_irq. Hence wanted the binding to capture that
>>>>> info. Will update the commit message accordingly.
>>>>>
>>>>
>>>> So the change in 99df63d20dabda8d7ae01bcca7cdb1e92110a555 was
>>>> incomplete? Lack of context here is not helping.
>>>>
>>>> If they have these IRQs but it does not matter, then it is not a good
>>>> reason to change ABI and you should just add the clock as optional to
>>>> the end. Was this binding already released? I think yes.
>>>
>>> IIUC the intent of the patch is to allow specifying the currently
>>> missing hs_phy_irq on non-multiport controllers (i.e. usb3_[012]).
>>> Bundling the DT change would have made that easier.
>>
>> This does not answer my concerns. So repeating: patch is changing ABI
>> without an explanation. This means contributor needs to provide
>> explanation for the ABI change in terms of actual impact.
>>
>  From a functional standpoint, there would be no effect. I was trying to 
> make the bindings reflect that the hardware has hs_phy_irq.

If there is no functional impact, so before everything was fine and now
is fine as well, then usual expectations is to make it
backwards-compatible way, so grow the list with minItems.

Best regards,
Krzysztof