From: Jani Nikula <jani.nikula@intel.com>
To: Jonathan Corbet <corbet@lwn.net>,
Guenter Roeck <linux@roeck-us.net>,
Krzysztof Kozlowski <krzk@kernel.org>
Cc: sashiko-bot@kernel.org, sashiko-reviews@lists.linux.dev,
sashiko@lists.linux.dev,
Linux Kernel Workflows <workflows@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
kfree@google.com, Dave Airlie <airlied@redhat.com>,
Simona Vetter <simona.vetter@ffwll.ch>
Subject: Re: Stop false review statements
Date: Mon, 18 May 2026 11:22:20 +0300 [thread overview]
Message-ID: <6010df0409abe1c9fc922ce57d7baa6c6998fa49@intel.com> (raw)
In-Reply-To: <877bp2m586.fsf@trenco.lwn.net>
On Sun, 17 May 2026, Jonathan Corbet <corbet@lwn.net> wrote:
> That said, I was certainly considering *human* reviewers at the time,
> and all of the people who agreed with the suggested policy were too.
> Adding bots seems like a stretch to me.
>
> I can't speak for subsystems that require Reviewed-by tags on their
> commits, but I'm not sure that their maintainers would accept an
> automated review as satisfying that requirement.
For the parts of the drm subsystem that have a committer/maintainer
model, one of the requirements for pushing is that at least two people
have been involved. Reviewed-by is one of the ways to record this is
indeed the case.
I can't speak for the entire subsystem either, but to me it was always
about people, trust, and the community.
We may add ways to record that an LLM has reviewed a patch, but I think
the fundamental requirement that two human beings have been involved is
going to remain.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2026-05-18 8:22 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-16 8:05 Stop false review statements Krzysztof Kozlowski
2026-05-16 12:11 ` Guenter Roeck
2026-05-16 12:16 ` Krzysztof Kozlowski
2026-05-16 12:23 ` Guenter Roeck
2026-05-16 12:29 ` Krzysztof Kozlowski
2026-05-16 13:24 ` Laurent Pinchart
2026-05-16 13:45 ` Krzysztof Kozlowski
2026-05-16 21:10 ` Mauro Carvalho Chehab
2026-05-17 15:21 ` Jonathan Corbet
2026-05-18 8:22 ` Jani Nikula [this message]
2026-05-16 15:20 ` Konstantin Ryabitsev
2026-05-16 15:36 ` Greg KH
2026-05-16 15:41 ` Roman Gushchin
2026-05-16 15:45 ` Greg KH
2026-05-16 15:49 ` Roman Gushchin
2026-05-16 18:28 ` Arnaldo Carvalho de Melo
2026-05-16 21:29 ` Derek Barbosa
2026-05-16 21:33 ` Krzysztof Kozlowski
2026-05-16 21:59 ` Roman Gushchin
2026-05-17 8:25 ` Krzysztof Kozlowski
2026-05-17 10:05 ` Mauro Carvalho Chehab
2026-05-17 10:10 ` Willy Tarreau
2026-05-17 10:12 ` Greg KH
2026-05-17 16:29 ` Theodore Tso
2026-05-17 22:22 ` Laurent Pinchart
2026-05-17 16:39 ` Mauro Carvalho Chehab
2026-05-17 17:03 ` Guenter Roeck
2026-05-17 18:17 ` Roman Gushchin
2026-05-17 18:56 ` Mauro Carvalho Chehab
2026-05-18 5:31 ` Greg KH
2026-05-17 18:57 ` Theodore Tso
2026-05-17 19:36 ` Mauro Carvalho Chehab
2026-05-18 8:04 ` Jani Nikula
2026-05-18 8:12 ` Krzysztof Kozlowski
2026-05-18 12:16 ` Theodore Tso
2026-05-18 12:54 ` Geert Uytterhoeven
2026-05-18 19:40 ` Mauro Carvalho Chehab
2026-05-16 18:28 ` Krzysztof Kozlowski
2026-05-16 18:56 ` Roman Gushchin
2026-05-16 19:00 ` Krzysztof Kozlowski
2026-05-16 19:13 ` Guenter Roeck
2026-05-16 19:25 ` Guenter Roeck
2026-05-16 19:31 ` Roman Gushchin
2026-05-16 19:15 ` Roman Gushchin
2026-05-16 20:41 ` Theodore Tso
2026-05-17 15:56 ` Danilo Krummrich
2026-05-17 21:25 ` Danilo Krummrich
2026-05-18 17:19 ` Roman Gushchin
2026-05-18 2:12 ` SeongJae Park
2026-05-16 22:32 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2026-05-17 19:42 Roman Gushchin
2026-05-17 22:05 ` Mauro Carvalho Chehab
2026-05-17 19:53 Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6010df0409abe1c9fc922ce57d7baa6c6998fa49@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@redhat.com \
--cc=corbet@lwn.net \
--cc=devicetree@vger.kernel.org \
--cc=kfree@google.com \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=sashiko-bot@kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sashiko@lists.linux.dev \
--cc=simona.vetter@ffwll.ch \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox