From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: ShiTou Hong <redstone.dcity@gmail.com>,
andersson@kernel.org, konradybcio@kernel.org,
conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
ShiTou Hong <dc_redstone@outlook.com>,
KancyJoe <kancy2333@outlook.com>
Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm8250-hdk: Add support of QCA6390
Date: Mon, 26 Oct 2026 11:54:33 +0100 [thread overview]
Message-ID: <7c287dda-9e81-4e98-8a8e-0984afa5507d@oss.qualcomm.com> (raw)
In-Reply-To: <20261023072832.2642647-5-dc_redstone@outlook.com>
On 10/23/26 9:28 AM, ShiTou Hong wrote:
> The sm8250-hdk has a QCA6390 WiFi/BT module which hasn't
> been added in the dts file.
>
> Enable the UART port of BT, add the bluetooth node.
> Add the QCA6390 PMU node.
> Add the wifi node of pcieport0.
> Add the missing regulator node of PM8009 which is used by QCA6390.
> Add the pinctrl of QCA6390 enable pins.
Don't describe the diff, describe the problem
https://docs.kernel.org/process/submitting-patches.html#describe-your-changes
[...]
> + qca6390_pins: qca6390-default-state {
> + wlan-enable-pins {
> + pins = "gpio20";
> + function = "gpio";
> + drive-strength = <16>;
> + output-low;
Drop output-foo, the driver will take care of that
> + bias-pull-up;
> + };
> +
> + bt-enable-pins {
> + pins = "gpio21";
> + function = "gpio";
> + drive-strength = <16>;
> + output-low;
likewise
Konrad
next prev parent reply other threads:[~2026-10-26 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 7:28 [PATCH 1/6] arm64: dts: qcom: sm8250-hdk: Enable the sdhc_2 port ShiTou Hong
2026-10-23 7:28 ` [PATCH 2/6] arm64: dts: qcom: sm8250-hdk: Add LT9611UXC HDMI bridge ShiTou Hong
2026-10-26 10:33 ` Konrad Dybcio
2026-10-23 7:28 ` [PATCH 3/6] arm64: dts: qcom: sm8250-hdk: Add FSA4480 USB-C protocol chip ShiTou Hong
2026-10-23 7:51 ` sashiko-bot
2026-10-23 7:28 ` [PATCH 4/6] arm64: dts: qcom: sm8250-hdk: Enable the PCIe ports ShiTou Hong
2026-10-23 7:43 ` sashiko-bot
2026-10-23 7:28 ` [PATCH 5/6] arm64: dts: qcom: sm8250-hdk: Add support of QCA6390 ShiTou Hong
2026-10-26 10:54 ` Konrad Dybcio [this message]
2026-10-23 7:28 ` [PATCH 6/6] arm64: dts: qcom: sm8250-hdk: Add PM8150b LEDs ShiTou Hong
2026-10-26 10:32 ` [PATCH 1/6] arm64: dts: qcom: sm8250-hdk: Enable the sdhc_2 port Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7c287dda-9e81-4e98-8a8e-0984afa5507d@oss.qualcomm.com \
--to=konrad.dybcio@oss.qualcomm.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=dc_redstone@outlook.com \
--cc=devicetree@vger.kernel.org \
--cc=kancy2333@outlook.com \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=redstone.dcity@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox