[PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

Add the sq52206 compatible to the ina2xx.yaml

Signed-off-by: Wenliang Yan <wenliang202407@163.com>
---

Add the meaning of 'shunt-gain' in SQ52206.

 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 05a9cb36cd82..25e0b2f0b28d 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
 properties:
   compatible:
     enum:
+      - silergy,sq52206
       - silergy,sy24655
       - ti,ina209
       - ti,ina219
@@ -58,6 +59,9 @@ properties:
       shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider
       voltage range is used.
 
+      For SQ52206,the shunt gain value 1 mapps to ADCRANGE=10/11, the value 2
+      mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00.
+
       The default value is device dependent, and is defined by the reset value
       of PGA/ADCRANGE in the respective configuration registers.
     $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.43.0

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Krzysztof Kozlowski]

On Wed, Jan 22, 2025 at 09:29:39AM +0800, Wenliang Yan wrote:
> Add the sq52206 compatible to the ina2xx.yaml
> 
> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
> ---
> 
> Add the meaning of 'shunt-gain' in SQ52206.

You already sent v3... and you got comment from me. You ignored both
Conor and me, so me doing third time the same and expecting different
results would be definition of insanity.

Please read carefully submitting patches before posting new version.

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2025-01-22 15:59:02, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Wed, Jan 22, 2025 at 09:29:39AM +0800, Wenliang Yan wrote:
>> Add the sq52206 compatible to the ina2xx.yaml
>> 
>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>> ---
>> 
>> Add the meaning of 'shunt-gain' in SQ52206.
>
>You already sent v3... and you got comment from me. You ignored both
>Conor and me, so me doing third time the same and expecting different
>results would be definition of insanity.
>
>Please read carefully submitting patches before posting new version.
>
>Best regards,
>Krzysztof

Sorry, I have received your comment and 'acked'. I was originally
planning to resend [PATCH v3 2/2], because I have not received a
response from Guenter Roeck<linux@roeck-us.net>. However, I forgot to
add 'RESEND' in the title. Thank you for your patient reply.
I apologize again.

Thanks,
Wenliang Yan

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Guenter Roeck]

On 1/22/25 17:36, Wenliang Yan wrote:
> At 2025-01-22 15:59:02, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>> On Wed, Jan 22, 2025 at 09:29:39AM +0800, Wenliang Yan wrote:
>>> Add the sq52206 compatible to the ina2xx.yaml
>>>
>>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>>> ---
>>>
>>> Add the meaning of 'shunt-gain' in SQ52206.
>>
>> You already sent v3... and you got comment from me. You ignored both
>> Conor and me, so me doing third time the same and expecting different
>> results would be definition of insanity.
>>
>> Please read carefully submitting patches before posting new version.
>>
>> Best regards,
>> Krzysztof
> 
> Sorry, I have received your comment and 'acked'. I was originally
> planning to resend [PATCH v3 2/2], because I have not received a
> response from Guenter Roeck<linux@roeck-us.net>. However, I forgot to
> add 'RESEND' in the title. Thank you for your patient reply.
> I apologize again.
> 

A resend after just four days, plus dropping all Acks ? Are you serious ?

Please keep in mind that not all of us are getting paid for doing this.
If I am otherwise busy, it will take longer. Sometimes it will take
much longer. If you resend a patches, they will end up at the tail
of my review queue. If you drop Acks, expect me to dig it all up,
and figure out on my own what if anything changed, the patches will
end up even further down, as in "I'll look into this series if I have
nothing else left to review".

Guenter

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2025-01-23 11:30:59, "Guenter Roeck" <linux@roeck-us.net> wrote:
>On 1/22/25 17:36, Wenliang Yan wrote:
>> At 2025-01-22 15:59:02, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>>> On Wed, Jan 22, 2025 at 09:29:39AM +0800, Wenliang Yan wrote:
>>>> Add the sq52206 compatible to the ina2xx.yaml
>>>>
>>>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>>>> ---
>>>>
>>>> Add the meaning of 'shunt-gain' in SQ52206.
>>>
>>> You already sent v3... and you got comment from me. You ignored both
>>> Conor and me, so me doing third time the same and expecting different
>>> results would be definition of insanity.
>>>
>>> Please read carefully submitting patches before posting new version.
>>>
>>> Best regards,
>>> Krzysztof
>> 
>> Sorry, I have received your comment and 'acked'. I was originally
>> planning to resend [PATCH v3 2/2], because I have not received a
>> response from Guenter Roeck<linux@roeck-us.net>. However, I forgot to
>> add 'RESEND' in the title. Thank you for your patient reply.
>> I apologize again.
>> 
>
>A resend after just four days, plus dropping all Acks ? Are you serious ?
>
>Please keep in mind that not all of us are getting paid for doing this.
>If I am otherwise busy, it will take longer. Sometimes it will take
>much longer. If you resend a patches, they will end up at the tail
>of my review queue. If you drop Acks, expect me to dig it all up,
>and figure out on my own what if anything changed, the patches will
>end up even further down, as in "I'll look into this series if I have
>nothing else left to review".
>
>Guenter

Sorry for the inconvenience caused by my actions. I am just concerned that
you did not receive the email, and I will continue to wait for your review
and correction.

Best regards,
Wenliang Yan

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Krzysztof Kozlowski]

On 23/01/2025 08:58, Wenliang Yan wrote:
> At 2025-01-23 11:30:59, "Guenter Roeck" <linux@roeck-us.net> wrote:
>> On 1/22/25 17:36, Wenliang Yan wrote:
>>> At 2025-01-22 15:59:02, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>>>> On Wed, Jan 22, 2025 at 09:29:39AM +0800, Wenliang Yan wrote:
>>>>> Add the sq52206 compatible to the ina2xx.yaml
>>>>>
>>>>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>>>>> ---
>>>>>
>>>>> Add the meaning of 'shunt-gain' in SQ52206.
>>>>
>>>> You already sent v3... and you got comment from me. You ignored both
>>>> Conor and me, so me doing third time the same and expecting different
>>>> results would be definition of insanity.
>>>>
>>>> Please read carefully submitting patches before posting new version.
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Sorry, I have received your comment and 'acked'. I was originally
>>> planning to resend [PATCH v3 2/2], because I have not received a
>>> response from Guenter Roeck<linux@roeck-us.net>. However, I forgot to
>>> add 'RESEND' in the title. Thank you for your patient reply.
>>> I apologize again.
>>>
>>
>> A resend after just four days, plus dropping all Acks ? Are you serious ?
>>
>> Please keep in mind that not all of us are getting paid for doing this.
>> If I am otherwise busy, it will take longer. Sometimes it will take
>> much longer. If you resend a patches, they will end up at the tail
>> of my review queue. If you drop Acks, expect me to dig it all up,
>> and figure out on my own what if anything changed, the patches will
>> end up even further down, as in "I'll look into this series if I have
>> nothing else left to review".
>>
>> Guenter
> 
> Sorry for the inconvenience caused by my actions. I am just concerned that
> you did not receive the email, and I will continue to wait for your review
> and correction.
What review? I am telling you that you ignored us twice and I am not
doing the same third time expecting different results.

How did you respond to this:

"Please read carefully submitting patches before posting new version."

?

How did you respond to previous acks?

Best regards,
Krzysztof

[PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

Add the sq52206 compatible to the ina2xx.yaml

Signed-off-by: Wenliang Yan <wenliang202407@163.com>
---

Add the meaning of 'shunt-gain' in SQ52206.

 Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
index 05a9cb36cd82..25e0b2f0b28d 100644
--- a/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
+++ b/Documentation/devicetree/bindings/hwmon/ti,ina2xx.yaml
@@ -20,6 +20,7 @@ description: |
 properties:
   compatible:
     enum:
+      - silergy,sq52206
       - silergy,sy24655
       - ti,ina209
       - ti,ina219
@@ -58,6 +59,9 @@ properties:
       shunt voltage, and a value of 4 maps to ADCRANGE=0 such that a wider
       voltage range is used.
 
+      For SQ52206,the shunt gain value 1 mapps to ADCRANGE=10/11, the value 2
+      mapps to ADCRANGE=01, and the value 4 mapps to ADCRANGE=00.
+
       The default value is device dependent, and is defined by the reset value
       of PGA/ADCRANGE in the respective configuration registers.
     $ref: /schemas/types.yaml#/definitions/uint32
-- 
2.43.0

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Krzysztof Kozlowski]

On Fri, Jan 17, 2025 at 04:20:16PM +0800, Wenliang Yan wrote:
> Add the sq52206 compatible to the ina2xx.yaml
> 
> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
> ---
> 
> Add the meaning of 'shunt-gain' in SQ52206.
> 

Didn't you got an Ack from Conor already?

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof

Re: [PATCH v3 1/2] dt-bindings:Add SQ52206 to ina2xx devicetree bindings

[Wenliang Yan]

At 2025-01-18 22:37:00, "Krzysztof Kozlowski" <krzk@kernel.org> wrote:
>On Fri, Jan 17, 2025 at 04:20:16PM +0800, Wenliang Yan wrote:
>> Add the sq52206 compatible to the ina2xx.yaml
>> 
>> Signed-off-by: Wenliang Yan <wenliang202407@163.com>
>> ---
>> 
>> Add the meaning of 'shunt-gain' in SQ52206.
>> 
>
>Didn't you got an Ack from Conor already?
>
>Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
>
>Best regards,
>Krzysztof

Thank you for your 'ack'. 
I did not receive an Ack from Conor before.

Best regards,
Wenliang Yan