Devicetree
 help / color / mirror / Atom feed
From: Shawn Guo <shengchao.guo@oss.qualcomm.com>
To: Bjorn Andersson <andersson@kernel.org>
Cc: Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@kernel.org>,
	Deepti Jaggi <deepti.jaggi@oss.qualcomm.com>,
	devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
Subject: Re: [PATCH v5 5/7] arm64: dts: qcom: Add device tree for Nord Embedded variant
Date: Thu, 16 Jul 2026 18:16:43 +0800	[thread overview]
Message-ID: <alivi4AHGHrKxkGw@QCOM-aGQu4IUr3Y> (raw)
In-Reply-To: <alfmcB3T4Kv3dffx@baldur>

On Wed, Jul 15, 2026 at 03:03:57PM -0500, Bjorn Andersson wrote:
> On Tue, Jul 14, 2026 at 08:15:24PM +0800, Shawn Guo wrote:
> > On Sun, Jul 12, 2026 at 10:39:44AM -0500, Bjorn Andersson wrote:
> > > On Thu, Jul 09, 2026 at 09:20:11PM +0800, Shawn Guo wrote:
> > > > Unlike the GearVM variant, Nord Embedded variant has platform resources
> > > > (clocks, regulators, powerdomains, pins, etc.) directly controlled by
> > > > Linux.
[...]
> > > > +&ufs_mem_hc {
> > > > +	reg = <0x0 0x01d44000 0x0 0x3000>,
> > > > +	      <0x0 0x01d60000 0x0 0x15000>;
> > > > +	reg-names = "std",
> > > > +		    "mcq";
> > > 
> > > All other changes in this patch directly relates to resource providers,
> > > why does the UFS controller's mmio ranges change?
> > 
> > We can have them in nord.dtsi just like all other device nodes, but we
> > will need to delete reg-names from nord-gearvm.dtsi, since
> > qcom,sa8255p-ufshc binding doesn't require reg-names.
> > 
> > @@ -2907,5 +2907,6 @@ &ufs_mem_hc {
> >         compatible = "qcom,sa8797p-ufshc",
> >                      "qcom,sa8255p-ufshc";
> >         reg = <0x0 0x01d44000 0x0 0x3000>;
> > +       /delete-property/ reg-names;
> >         power-domains = <&scmi3_pd 0>;
> >  };
> > 
> > I will do this with v6, unless you hate delete-property.
> > 
> 
> Now I see the answer is was actually looking for: the SCMI-based variant
> doesn't list the mcq region. Why is that?

Good question! It seems to be a binding problem to me. I just proposed
a fix [1] and will move reg/reg-names into nord.dtsi to be shared by both
variants. It will be neat. But that also means we will have one more
dependency for v6 of the series, sadly.

Shawn

[1] https://lore.kernel.org/all/20260716083313.2367249-1-shengchao.guo@oss.qualcomm.com/

  reply	other threads:[~2026-07-16 10:16 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-09 13:20 [PATCH v5 0/7] Add initial device trees for Nord platform Shawn Guo
2026-07-09 13:20 ` [PATCH v5 1/7] arm64: dts: qcom: Add device tree for Nord SoC series Shawn Guo
2026-07-09 13:38   ` sashiko-bot
2026-07-09 13:20 ` [PATCH v5 2/7] arm64: dts: qcom: Add device tree for Nord GearVM variant Shawn Guo
2026-07-09 13:51   ` sashiko-bot
2026-07-09 13:20 ` [PATCH v5 3/7] dt-bindings: arm: qcom: Document SA8797P Ride board Shawn Guo
2026-07-09 13:20 ` [PATCH v5 4/7] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-07-09 13:20 ` [PATCH v5 5/7] arm64: dts: qcom: Add device tree for Nord Embedded variant Shawn Guo
2026-07-12 15:39   ` Bjorn Andersson
2026-07-14 12:15     ` Shawn Guo
2026-07-15 20:03       ` Bjorn Andersson
2026-07-16 10:16         ` Shawn Guo [this message]
2026-07-09 13:20 ` [PATCH v5 6/7] dt-bindings: arm: qcom: Document Nord IQ10 RRD board Shawn Guo
2026-07-10  7:04   ` Krzysztof Kozlowski
2026-07-10  7:07     ` Krzysztof Kozlowski
2026-07-14 12:16       ` Shawn Guo
2026-07-09 13:20 ` [PATCH v5 7/7] arm64: dts: qcom: Add device tree for " Shawn Guo
2026-07-09 14:30   ` sashiko-bot
2026-07-12 15:15   ` Bjorn Andersson
2026-07-14 12:21     ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=alivi4AHGHrKxkGw@QCOM-aGQu4IUr3Y \
    --to=shengchao.guo@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=bartosz.golaszewski@oss.qualcomm.com \
    --cc=brgl@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=deepti.jaggi@oss.qualcomm.com \
    --cc=devicetree@vger.kernel.org \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox