From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Chang Yu <marcus.yu.56@gmail.com>
Cc: "Jonathan Cameron" <jic23@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Nuno Sá" <nuno.sa@analog.com>,
"Andy Shevchenko" <andy@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Joshua Crofts" <joshua.crofts1@gmail.com>,
"Shi Hao" <i.shihao.999@gmail.com>,
"Jose A. Perez de Azpillaga" <azpijr@gmail.com>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver
Date: Wed, 14 Oct 2026 13:38:49 +0300 [thread overview]
Message-ID: <as9bueoY_elkSPdB@ashevche-desk.local> (raw)
In-Reply-To: <as70Y0biw0XMjwL6@zephyrus-g14.localdomain>
On Wed, Oct 14, 2026 at 11:17:55AM +0800, Chang Yu wrote:
> On Tue, Oct 13, 2026 at 07:27:42PM +0300, Andy Shevchenko wrote:
> > On Tue, Oct 13, 2026 at 07:56:39PM +0800, Chang Yu wrote:
...
> > > +/*
> > > + * Integration time is calculated as (ATIME + 1) * ((ASTEP + 1) * 2.78us).
> > > + * ATIME must be between 0 and 255, inclusive
> > > + * ASTEP must be between 0 and 65534, inclusive
> >
> > Haven't noticed before, but is it indeed 65534 and not 65535 here (or 255 and
> > not 254 above)? Haven't checked datasheet, please double check.
> >
> Per the datasheet 0 <= ASTEP <= 65534 (65535 was explicitly marked as "do not
> use"), and since ASTEP = n - 1, we have 1 <= n <= 65535. Similary
> 0 <= ATIME <= 255, ATIME = step - 1, so 1 <= step <= 256.
>
> So I think the numbers here are correct.
Thanks for checking! In case you need a new version, just add that into the
above comment, like
* Per datasheet, do not use 65535 for ASTEP.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2026-10-14 10:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 11:56 [PATCH v6 0/2] Add support for AS7343 multi-spectral sensor Chang Yu
2026-10-13 11:56 ` [PATCH v6 1/2] dt-bindings: iio: light: add as7343 Chang Yu
2026-10-13 12:04 ` sashiko-bot
2026-10-13 12:36 ` Joshua Crofts
2026-10-13 15:15 ` Chang Yu
2026-10-13 21:23 ` Jose A. Perez de Azpillaga
2026-10-14 11:22 ` Krzysztof Kozlowski
2026-10-13 11:56 ` [PATCH v6 2/2] iio: light: add AS7343 multi-spectral sensor driver Chang Yu
2026-10-13 12:35 ` Joshua Crofts
2026-10-13 16:28 ` Andy Shevchenko
2026-10-13 16:27 ` Andy Shevchenko
2026-10-14 3:17 ` Chang Yu
2026-10-14 10:38 ` Andy Shevchenko [this message]
2026-10-14 10:04 ` Jose A. Perez de Azpillaga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=as9bueoY_elkSPdB@ashevche-desk.local \
--to=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=azpijr@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlechner@baylibre.com \
--cc=i.shihao.999@gmail.com \
--cc=jic23@kernel.org \
--cc=joshua.crofts1@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.yu.56@gmail.com \
--cc=nuno.sa@analog.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox