[PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Biju]

From: Biju Das <biju.das.jz@bp.renesas.com>

Add a conditional schema rule to the syscon bindings that requires the
ranges property when the compatible string contains
renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control block
on the RZ/G3L SoC correctly declares its address translation, as the
device has child nodes that need a valid ranges mapping to be described
in the device tree.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
 Documentation/devicetree/bindings/mfd/syscon.yaml | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
index 9c81010d5a74..cbf83a06ae25 100644
--- a/Documentation/devicetree/bindings/mfd/syscon.yaml
+++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
@@ -269,6 +269,8 @@ properties:
   resets:
     maxItems: 1
 
+  ranges: true
+
 required:
   - compatible
   - reg
@@ -276,6 +278,18 @@ required:
 allOf:
   - $ref: syscon-common.yaml#
 
+  - if:
+      properties:
+        compatible:
+          contains:
+            const: renesas,r9a08g046-lvds-cmn
+    then:
+      properties:
+        ranges: true
+
+      required:
+        - ranges
+
 unevaluatedProperties: false
 
 examples:
-- 
2.43.0

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [High] The conditional schema rule for `renesas,r9a08g046-lvds-cmn` is unreachable dead code due to omission from the top-level selection lists.
- [High] The schema implicitly requires child nodes and address translation for the device, but completely rejects them due to `unevaluatedProperties: false`.
- [Medium] Defining `ranges: true` globally weakens schema validation for all generic syscon devices.
--

commit a221f26520a3a09abdff9436ec38d41103c001ab
Author: Biju Das <biju.das.jz@bp.renesas.com>

dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

This patch adds a conditional schema rule to the syscon bindings that
requires the ranges property when the compatible string contains
renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control block
on the RZ/G3L SoC correctly declares its address translation for child nodes.

> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index e228670880631..088df592e7ace 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -268,6 +268,8 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  ranges: true

[Severity: Medium]
Does adding this globally weaken schema validation for all generic syscon
devices? Since ranges is also defined conditionally below, could we remove
this top-level definition to avoid making the schema overly permissive for
over 100 other devices?

> +
>  required:
>    - compatible
>    - reg
> @@ -275,6 +277,18 @@ required:
>  allOf:
>    - $ref: syscon-common.yaml#
>  
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: renesas,r9a08g046-lvds-cmn

[Severity: High]
Is this conditional rule unreachable? The schema uses a custom select block
to limit applicability:

select:
  properties:
    compatible:
      contains:
        enum:

Because renesas,r9a08g046-lvds-cmn is not added to the select enum, dtschema
might never select syscon.yaml to validate a node with this compatible string.
Does this compatible string need to be added to the top-level selection lists
to ensure validation occurs?

> +    then:
> +      properties:
> +        ranges: true
> +
> +      required:
> +        - ranges
> +
>  unevaluatedProperties: false

[Severity: High]
Since the commit message notes the device has child nodes that need a valid
ranges mapping, will setting unevaluatedProperties to false reject them?

Using ranges to map child addresses mandates the presence of child nodes as
well as #address-cells and #size-cells. However, syscon.yaml does not define
#address-cells, #size-cells, or any child node pattern properties. Will a
correctly formed device tree node with children be incorrectly rejected by
dtbs_check with unevaluated property errors?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260602131331.90756-1-biju.das.jz@bp.renesas.com?part=1

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
> From: Biju Das <biju.das.jz@bp.renesas.com>
> 
> Add a conditional schema rule to the syscon bindings that requires the
> ranges property when the compatible string contains
> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control block
> on the RZ/G3L SoC correctly declares its address translation, as the
> device has child nodes that need a valid ranges mapping to be described
> in the device tree.
> 
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
> index 9c81010d5a74..cbf83a06ae25 100644
> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> @@ -269,6 +269,8 @@ properties:
>    resets:
>      maxItems: 1
>  
> +  ranges: true

There are no children allowed, so ranges property is wrong.

You are changing binding which DOES NOT allow simple-mfd or any other
children. Ranges is not a problem here.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>
>> Add a conditional schema rule to the syscon bindings that requires the
>> ranges property when the compatible string contains
>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control block
>> on the RZ/G3L SoC correctly declares its address translation, as the
>> device has child nodes that need a valid ranges mapping to be described
>> in the device tree.
>>
>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14 ++++++++++++++
>>  1 file changed, 14 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> index 9c81010d5a74..cbf83a06ae25 100644
>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>> @@ -269,6 +269,8 @@ properties:
>>    resets:
>>      maxItems: 1
>>  
>> +  ranges: true
> 
> There are no children allowed, so ranges property is wrong.
> 
> You are changing binding which DOES NOT allow simple-mfd or any other
> children. Ranges is not a problem here.


And if you tested it on your DTS, you would see this does not work...

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

Thanks for the feedback.

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 11:22
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> > On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
> >> From: Biju Das <biju.das.jz@bp.renesas.com>
> >>
> >> Add a conditional schema rule to the syscon bindings that requires
> >> the ranges property when the compatible string contains
> >> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
> >> block on the RZ/G3L SoC correctly declares its address translation,
> >> as the device has child nodes that need a valid ranges mapping to be
> >> described in the device tree.
> >>
> >> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >> ---
> >>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
> >> ++++++++++++++
> >>  1 file changed, 14 insertions(+)
> >>
> >> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> index 9c81010d5a74..cbf83a06ae25 100644
> >> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >> @@ -269,6 +269,8 @@ properties:
> >>    resets:
> >>      maxItems: 1
> >>
> >> +  ranges: true
> >
> > There are no children allowed, so ranges property is wrong.
> >
> > You are changing binding which DOES NOT allow simple-mfd or any other
> > children. Ranges is not a problem here.
> 
> 
> And if you tested it on your DTS, you would see this does not work...

I don't see any warnings or error. I have done this change based on Rob's comment
based on sashiko review [1].

If you agree, I can drop this patch.

[1]
https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/

Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 12:26, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
> Thanks for the feedback.
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 11:22
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>>
>>>> Add a conditional schema rule to the syscon bindings that requires
>>>> the ranges property when the compatible string contains
>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
>>>> block on the RZ/G3L SoC correctly declares its address translation,
>>>> as the device has child nodes that need a valid ranges mapping to be
>>>> described in the device tree.
>>>>
>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>> ---
>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
>>>> ++++++++++++++
>>>>  1 file changed, 14 insertions(+)
>>>>
>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> index 9c81010d5a74..cbf83a06ae25 100644
>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>> @@ -269,6 +269,8 @@ properties:
>>>>    resets:
>>>>      maxItems: 1
>>>>
>>>> +  ranges: true
>>>
>>> There are no children allowed, so ranges property is wrong.
>>>
>>> You are changing binding which DOES NOT allow simple-mfd or any other
>>> children. Ranges is not a problem here.
>>
>>
>> And if you tested it on your DTS, you would see this does not work...
> 
> I don't see any warnings or error. I have done this change based on Rob's comment
> based on sashiko review [1].
> 
> If you agree, I can drop this patch.
> 
> [1]
> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/

Look:
https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.renesas.com/
What compatibles are here?

Now open the binding - what compatibles are allowed for
renesas,r9a08g046-lvds-cmn ?

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 12:11
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 12:26, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> > Thanks for the feedback.
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 08 June 2026 11:22
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
> >> for renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> >>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
> >>>> From: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>
> >>>> Add a conditional schema rule to the syscon bindings that requires
> >>>> the ranges property when the compatible string contains
> >>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
> >>>> block on the RZ/G3L SoC correctly declares its address translation,
> >>>> as the device has child nodes that need a valid ranges mapping to
> >>>> be described in the device tree.
> >>>>
> >>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>>> ---
> >>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
> >>>> ++++++++++++++
> >>>>  1 file changed, 14 insertions(+)
> >>>>
> >>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>> index 9c81010d5a74..cbf83a06ae25 100644
> >>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>> @@ -269,6 +269,8 @@ properties:
> >>>>    resets:
> >>>>      maxItems: 1
> >>>>
> >>>> +  ranges: true
> >>>
> >>> There are no children allowed, so ranges property is wrong.
> >>>
> >>> You are changing binding which DOES NOT allow simple-mfd or any
> >>> other children. Ranges is not a problem here.
> >>
> >>
> >> And if you tested it on your DTS, you would see this does not work...
> >
> > I don't see any warnings or error. I have done this change based on
> > Rob's comment based on sashiko review [1].
> >
> > If you agree, I can drop this patch.
> >
> > [1]
> > https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/
> 
> Look:
> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.renesas.com/
> What compatibles are here?
> 
> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?

OK, I am missing the fallbacks "simple-mfd", "syscon"; in the compatibles allowed
for renesas,r9a08g046-lvds-cmn.

OK, I will add those.

Cheers,
Biju

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 13:22, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 12:11
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 12:26, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>> Thanks for the feedback.
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>> Sent: 08 June 2026 11:22
>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>> for renesas,r9a08g046-lvds-cmn
>>>>
>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>
>>>>>> Add a conditional schema rule to the syscon bindings that requires
>>>>>> the ranges property when the compatible string contains
>>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
>>>>>> block on the RZ/G3L SoC correctly declares its address translation,
>>>>>> as the device has child nodes that need a valid ranges mapping to
>>>>>> be described in the device tree.
>>>>>>
>>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>> ---
>>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
>>>>>> ++++++++++++++
>>>>>>  1 file changed, 14 insertions(+)
>>>>>>
>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>> index 9c81010d5a74..cbf83a06ae25 100644
>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>> @@ -269,6 +269,8 @@ properties:
>>>>>>    resets:
>>>>>>      maxItems: 1
>>>>>>
>>>>>> +  ranges: true
>>>>>
>>>>> There are no children allowed, so ranges property is wrong.
>>>>>
>>>>> You are changing binding which DOES NOT allow simple-mfd or any
>>>>> other children. Ranges is not a problem here.
>>>>
>>>>
>>>> And if you tested it on your DTS, you would see this does not work...
>>>
>>> I don't see any warnings or error. I have done this change based on
>>> Rob's comment based on sashiko review [1].
>>>
>>> If you agree, I can drop this patch.
>>>
>>> [1]
>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/
>>
>> Look:
>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.renesas.com/
>> What compatibles are here?
>>
>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
> 
> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the compatibles allowed
> for renesas,r9a08g046-lvds-cmn.
> 
> OK, I will add those.

No, maybe, dunno... How anything here could have been tested? dtbs_check
clearly points errors on your DTS.

Best regards,
Krzysztof

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 13:46, Krzysztof Kozlowski wrote:
> On 08/06/2026 13:22, Biju Das wrote:
>> Hi Krzysztof Kozlowski,
>>
>>> -----Original Message-----
>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>> Sent: 08 June 2026 12:11
>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
>>>
>>> On 08/06/2026 12:26, Biju Das wrote:
>>>> Hi Krzysztof Kozlowski,
>>>>
>>>> Thanks for the feedback.
>>>>
>>>>> -----Original Message-----
>>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>>> Sent: 08 June 2026 11:22
>>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>>> for renesas,r9a08g046-lvds-cmn
>>>>>
>>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
>>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>>>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>>
>>>>>>> Add a conditional schema rule to the syscon bindings that requires
>>>>>>> the ranges property when the compatible string contains
>>>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
>>>>>>> block on the RZ/G3L SoC correctly declares its address translation,
>>>>>>> as the device has child nodes that need a valid ranges mapping to
>>>>>>> be described in the device tree.
>>>>>>>
>>>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>> ---
>>>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
>>>>>>> ++++++++++++++
>>>>>>>  1 file changed, 14 insertions(+)
>>>>>>>
>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>> index 9c81010d5a74..cbf83a06ae25 100644
>>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>> @@ -269,6 +269,8 @@ properties:
>>>>>>>    resets:
>>>>>>>      maxItems: 1
>>>>>>>
>>>>>>> +  ranges: true
>>>>>>
>>>>>> There are no children allowed, so ranges property is wrong.
>>>>>>
>>>>>> You are changing binding which DOES NOT allow simple-mfd or any
>>>>>> other children. Ranges is not a problem here.
>>>>>
>>>>>
>>>>> And if you tested it on your DTS, you would see this does not work...
>>>>
>>>> I don't see any warnings or error. I have done this change based on
>>>> Rob's comment based on sashiko review [1].
>>>>
>>>> If you agree, I can drop this patch.
>>>>
>>>> [1]
>>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org/
>>>
>>> Look:
>>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.renesas.com/
>>> What compatibles are here?
>>>
>>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
>>
>> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the compatibles allowed
>> for renesas,r9a08g046-lvds-cmn.
>>
>> OK, I will add those.
> 
> No, maybe, dunno... How anything here could have been tested? dtbs_check
> clearly points errors on your DTS.
> 


You should re-do the commit 51284d8b1dbcd7fa0220c49eeab29b14617e0d88
because it is completely broken. This is schema for syscons, not devices
with children.

You added incomplete, incorrect binding having obvious dtbs_check
failures which you would see if you validated DTS (never posted!!!).

And you keep introducing more issues, by trying to fix non-existing
issues while keeping the main problem - completely mismatched
renesas,r9a08g046-lvds-cmn binding with reality unfixed.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 12:47
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 13:22, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 08 June 2026 12:11
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
> >> for renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 12:26, Biju Das wrote:
> >>> Hi Krzysztof Kozlowski,
> >>>
> >>> Thanks for the feedback.
> >>>
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzk@kernel.org>
> >>>> Sent: 08 June 2026 11:22
> >>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
> >>>> for renesas,r9a08g046-lvds-cmn
> >>>>
> >>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> >>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
> >>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>>>
> >>>>>> Add a conditional schema rule to the syscon bindings that
> >>>>>> requires the ranges property when the compatible string contains
> >>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
> >>>>>> block on the RZ/G3L SoC correctly declares its address
> >>>>>> translation, as the device has child nodes that need a valid
> >>>>>> ranges mapping to be described in the device tree.
> >>>>>>
> >>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>>> ---
> >>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
> >>>>>> ++++++++++++++
> >>>>>>  1 file changed, 14 insertions(+)
> >>>>>>
> >>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>> index 9c81010d5a74..cbf83a06ae25 100644
> >>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>> @@ -269,6 +269,8 @@ properties:
> >>>>>>    resets:
> >>>>>>      maxItems: 1
> >>>>>>
> >>>>>> +  ranges: true
> >>>>>
> >>>>> There are no children allowed, so ranges property is wrong.
> >>>>>
> >>>>> You are changing binding which DOES NOT allow simple-mfd or any
> >>>>> other children. Ranges is not a problem here.
> >>>>
> >>>>
> >>>> And if you tested it on your DTS, you would see this does not work...
> >>>
> >>> I don't see any warnings or error. I have done this change based on
> >>> Rob's comment based on sashiko review [1].
> >>>
> >>> If you agree, I can drop this patch.
> >>>
> >>> [1]
> >>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org
> >>> /
> >>
> >> Look:
> >> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.re
> >> nesas.com/
> >> What compatibles are here?
> >>
> >> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
> >
> > OK, I am missing the fallbacks "simple-mfd", "syscon"; in the
> > compatibles allowed for renesas,r9a08g046-lvds-cmn.
> >
> > OK, I will add those.
> 
> No, maybe, dunno... How anything here could have been tested? dtbs_check clearly points errors on your
> DTS.

I ran the below commands and none of then triggered the error/warning you are suspecting.
Am I missing anything here?

make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- dt_binding_check -j32
make ARCH=arm64 -s dtbs_check -j32
make ARCH=arm64 DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- -s dtbs_check -j32
make ARCH=arm64 CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- W=1 dtbs -j32 2>&1 | tee -a arm64-dtbs.log

Cheers,
Biju

> 
> Best regards,
> Krzysztof

Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Krzysztof Kozlowski]

On 08/06/2026 13:51, Biju Das wrote:
> Hi Krzysztof Kozlowski,
> 
>> -----Original Message-----
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>> Sent: 08 June 2026 12:47
>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
>>
>> On 08/06/2026 13:22, Biju Das wrote:
>>> Hi Krzysztof Kozlowski,
>>>
>>>> -----Original Message-----
>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>> Sent: 08 June 2026 12:11
>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>> for renesas,r9a08g046-lvds-cmn
>>>>
>>>> On 08/06/2026 12:26, Biju Das wrote:
>>>>> Hi Krzysztof Kozlowski,
>>>>>
>>>>> Thanks for the feedback.
>>>>>
>>>>>> -----Original Message-----
>>>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>>>> Sent: 08 June 2026 11:22
>>>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
>>>>>> for renesas,r9a08g046-lvds-cmn
>>>>>>
>>>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
>>>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
>>>>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>>>
>>>>>>>> Add a conditional schema rule to the syscon bindings that
>>>>>>>> requires the ranges property when the compatible string contains
>>>>>>>> renesas,r9a08g046-lvds-cmn. This ensures the LVDS common control
>>>>>>>> block on the RZ/G3L SoC correctly declares its address
>>>>>>>> translation, as the device has child nodes that need a valid
>>>>>>>> ranges mapping to be described in the device tree.
>>>>>>>>
>>>>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>>>>>>>> ---
>>>>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
>>>>>>>> ++++++++++++++
>>>>>>>>  1 file changed, 14 insertions(+)
>>>>>>>>
>>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> index 9c81010d5a74..cbf83a06ae25 100644
>>>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
>>>>>>>> @@ -269,6 +269,8 @@ properties:
>>>>>>>>    resets:
>>>>>>>>      maxItems: 1
>>>>>>>>
>>>>>>>> +  ranges: true
>>>>>>>
>>>>>>> There are no children allowed, so ranges property is wrong.
>>>>>>>
>>>>>>> You are changing binding which DOES NOT allow simple-mfd or any
>>>>>>> other children. Ranges is not a problem here.
>>>>>>
>>>>>>
>>>>>> And if you tested it on your DTS, you would see this does not work...
>>>>>
>>>>> I don't see any warnings or error. I have done this change based on
>>>>> Rob's comment based on sashiko review [1].
>>>>>
>>>>> If you agree, I can drop this patch.
>>>>>
>>>>> [1]
>>>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.org
>>>>> /
>>>>
>>>> Look:
>>>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.re
>>>> nesas.com/
>>>> What compatibles are here?
>>>>
>>>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
>>>
>>> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the
>>> compatibles allowed for renesas,r9a08g046-lvds-cmn.
>>>
>>> OK, I will add those.
>>
>> No, maybe, dunno... How anything here could have been tested? dtbs_check clearly points errors on your
>> DTS.
> 
> I ran the below commands and none of then triggered the error/warning you are suspecting.
> Am I missing anything here?
> 
> make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- dt_binding_check -j32
> make ARCH=arm64 -s dtbs_check -j32
> make ARCH=arm64 DT_SCHEMA_FILES=${1} CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- -s dtbs_check -j32
> make ARCH=arm64 CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- W=1 dtbs -j32 2>&1 | tee -a arm64-dtbs.log

No, you must validate all schemas, not one file. And without DTS
obviously this will not point any error on dtbs_check.

I am reverting your commit.

Best regards,
Krzysztof

RE: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn

[Biju Das]

Hi Krzysztof Kozlowski,

> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: 08 June 2026 12:55
> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required for renesas,r9a08g046-lvds-cmn
> 
> On 08/06/2026 13:51, Biju Das wrote:
> > Hi Krzysztof Kozlowski,
> >
> >> -----Original Message-----
> >> From: Krzysztof Kozlowski <krzk@kernel.org>
> >> Sent: 08 June 2026 12:47
> >> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
> >> for renesas,r9a08g046-lvds-cmn
> >>
> >> On 08/06/2026 13:22, Biju Das wrote:
> >>> Hi Krzysztof Kozlowski,
> >>>
> >>>> -----Original Message-----
> >>>> From: Krzysztof Kozlowski <krzk@kernel.org>
> >>>> Sent: 08 June 2026 12:11
> >>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges required
> >>>> for renesas,r9a08g046-lvds-cmn
> >>>>
> >>>> On 08/06/2026 12:26, Biju Das wrote:
> >>>>> Hi Krzysztof Kozlowski,
> >>>>>
> >>>>> Thanks for the feedback.
> >>>>>
> >>>>>> -----Original Message-----
> >>>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
> >>>>>> Sent: 08 June 2026 11:22
> >>>>>> Subject: Re: [PATCH] dt-bindings: mfd: syscon: Make ranges
> >>>>>> required for renesas,r9a08g046-lvds-cmn
> >>>>>>
> >>>>>> On 08/06/2026 12:20, Krzysztof Kozlowski wrote:
> >>>>>>> On Tue, Jun 02, 2026 at 02:13:29PM +0100, Biju wrote:
> >>>>>>>> From: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>>>>>
> >>>>>>>> Add a conditional schema rule to the syscon bindings that
> >>>>>>>> requires the ranges property when the compatible string
> >>>>>>>> contains renesas,r9a08g046-lvds-cmn. This ensures the LVDS
> >>>>>>>> common control block on the RZ/G3L SoC correctly declares its
> >>>>>>>> address translation, as the device has child nodes that need a
> >>>>>>>> valid ranges mapping to be described in the device tree.
> >>>>>>>>
> >>>>>>>> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> >>>>>>>> ---
> >>>>>>>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 14
> >>>>>>>> ++++++++++++++
> >>>>>>>>  1 file changed, 14 insertions(+)
> >>>>>>>>
> >>>>>>>> diff --git a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>>>> b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>>>> index 9c81010d5a74..cbf83a06ae25 100644
> >>>>>>>> --- a/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>>>> +++ b/Documentation/devicetree/bindings/mfd/syscon.yaml
> >>>>>>>> @@ -269,6 +269,8 @@ properties:
> >>>>>>>>    resets:
> >>>>>>>>      maxItems: 1
> >>>>>>>>
> >>>>>>>> +  ranges: true
> >>>>>>>
> >>>>>>> There are no children allowed, so ranges property is wrong.
> >>>>>>>
> >>>>>>> You are changing binding which DOES NOT allow simple-mfd or any
> >>>>>>> other children. Ranges is not a problem here.
> >>>>>>
> >>>>>>
> >>>>>> And if you tested it on your DTS, you would see this does not work...
> >>>>>
> >>>>> I don't see any warnings or error. I have done this change based
> >>>>> on Rob's comment based on sashiko review [1].
> >>>>>
> >>>>> If you agree, I can drop this patch.
> >>>>>
> >>>>> [1]
> >>>>> https://lore.kernel.org/all/20260601022619.GA3961324-robh@kernel.o
> >>>>> rg
> >>>>> /
> >>>>
> >>>> Look:
> >>>> https://lore.kernel.org/all/20260524194457.479681-2-biju.das.jz@bp.
> >>>> re
> >>>> nesas.com/
> >>>> What compatibles are here?
> >>>>
> >>>> Now open the binding - what compatibles are allowed for renesas,r9a08g046-lvds-cmn ?
> >>>
> >>> OK, I am missing the fallbacks "simple-mfd", "syscon"; in the
> >>> compatibles allowed for renesas,r9a08g046-lvds-cmn.
> >>>
> >>> OK, I will add those.
> >>
> >> No, maybe, dunno... How anything here could have been tested?
> >> dtbs_check clearly points errors on your DTS.
> >
> > I ran the below commands and none of then triggered the error/warning you are suspecting.
> > Am I missing anything here?
> >
> > make ARCH=arm64 DT_CHECKER_FLAGS=-m DT_SCHEMA_FILES=${1}
> > CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu-
> > dt_binding_check -j32 make ARCH=arm64 -s dtbs_check -j32 make
> > ARCH=arm64 DT_SCHEMA_FILES=${1}
> > CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- -s
> > dtbs_check -j32 make ARCH=arm64
> > CROSS_COMPILE=~/${TOOL_CHAIN}/bin/aarch64-none-linux-gnu- W=1 dtbs
> > -j32 2>&1 | tee -a arm64-dtbs.log
> 
> No, you must validate all schemas, not one file. And without DTS obviously this will not point any
> error on dtbs_check.
> 
> I am reverting your commit.

What made you think that I am not testing with DTS? Please don't assume things.

lvds: lvds-cmn@108a0000 {
			compatible = "renesas,r9a08g046-lvds-cmn",
				     "simple-mfd", "syscon";
			reg = <0 0x108a0000 0 0x10000>;
			#address-cells = <2>;
			#size-cells = <2>;
			ranges;

			lvds0: lvds@10 {
				compatible = "renesas,r9a08g046-lvds";
				reg = <0 0x10 0 0x8>;
				clocks = <&cpg CPG_MOD R9A08G046_MIPI_DSI_PCLK>,
					 <&cpg CPG_MOD R9A08G046_LVDS_PLLCLK>,
					 <&cpg CPG_MOD R9A08G046_LVDS_CLK_DOT0>;
				clock-names = "pclk", "phyclk", "dotclk";
				resets = <&cpg R9A08G046_LVDS_RESET_N>,
				 	 <&cpg R9A08G046_MIPI_DSI_PRESET_N>,
				 	 <&cpg R9A08G046_MIPI_DSI_CMN_RSTB>,
				 	 <&cpg R9A08G046_MIPI_DSI_ARESET_N>;
				reset-names = "lvdrst", "prst", "rst", "arst";
				power-domains = <&cpg>;
				status = "disabled";

				ports {
					#address-cells = <1>;
					#size-cells = <0>;

					port@0 {
						reg = <0>;
						lvds0_in: endpoint {
							remote-endpoint = <&du_out_lvds0>;
						};
					};

					port@1 {
						reg = <1>;
						lvds_ch0: endpoint {
						};
					};
				};
			};
		};


Cheers,
Biju