[PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G

[PATCH 0/4] arm64: dts: qcom: add the Xiaomi Mi Pad 5 Pro 5G

[Dawid Wróbel via B4 Relay]

The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
Mi Pad 5 Pro (elish). The two boards share a design, so this describes
enuma as sm8250-xiaomi-elish-common.dtsi plus the three things that
differ: the board ID the bootloader matches on, the panel compatible and
the WiFi board data variant.

Unlike elish, enuma shipped with a single display variant, so there is
one device tree rather than a per-panel pair. The vendor device trees key
the touch configuration to a display maker, and enuma declares a single
entry against elish's three:

  https://github.com/MiCode/kernel_devicetree/blob/elish-r-oss/qcom/enuma-sm8250.dtsi#L309
  https://github.com/MiCode/kernel_devicetree/blob/elish-r-oss/qcom/elish-sm8250.dtsi#L294

The panel itself is the same part elish uses: both trees pull in the
same dsi-panel-k81-42-02-0a-video.dtsi, so the new
xiaomi,enuma-csot-nt36523 compatible falls back to
xiaomi,elish-csot-nt36523, leaving room to handle any difference that
turns up later without requiring a device tree change.

The WiFi board data is already upstream in ath11k-firmware as
bus=pci,qmi-chip-id=0,qmi-board-id=255,variant=Xiaomi_Pad_5Pro_5G
(QCA6390 hw2.0 board-2.bin, commit 235d09a5e111).

Tested on the device: the panel and WiFi come up and perform as expected
under postmarketOS.

The fingerprint sensor, PCIe2/modem and touchscreen this board also
provides are left out here; they depend on bindings that are not upstream
yet and will follow separately.

Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
Dawid Wróbel (4):
      dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel
      dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G
      arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node
      arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

 Documentation/devicetree/bindings/arm/qcom.yaml    |  5 +++++
 .../bindings/display/panel/novatek,nt36523.yaml    |  4 ++++
 arch/arm64/boot/dts/qcom/Makefile                  |  1 +
 .../boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi  |  2 +-
 arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts   | 26 ++++++++++++++++++++++
 5 files changed, 37 insertions(+), 1 deletion(-)
---
base-commit: bd94276d96726a82700d85ad3b32892f45809d3a
change-id: 20260730-sm8250-xiaomi-enuma-e878f2c08413

Best regards,
-- 
Dawid Wróbel <me@dawidwrobel.com>

[PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel

[Dawid Wróbel via B4 Relay]

From: Dawid Wróbel <me@dawidwrobel.com>

The Xiaomi Mi Pad 5 Pro 5G (enuma) ships the same CSOT panel as the Mi
Pad 5 Pro (elish), so it falls back to the elish compatible. Give it a
device-specific one in front, so a later difference does not need a
device tree change.

Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
 Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
index b9300a1f2646..2f3f34d08f29 100644
--- a/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
+++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml
@@ -22,6 +22,10 @@ properties:
               - xiaomi,elish-boe-nt36523
               - xiaomi,elish-csot-nt36523
           - const: novatek,nt36523
+      - items:
+          - const: xiaomi,enuma-csot-nt36523
+          - const: xiaomi,elish-csot-nt36523
+          - const: novatek,nt36523
       - items:
           - enum:
               - lenovo,j606f-boe-nt36523w

-- 
2.55.0

Re: [PATCH 1/4] dt-bindings: display: panel: novatek,nt36523: add the Mi Pad 5 Pro 5G panel

[Krzysztof Kozlowski]

On Thu, Jul 30, 2026 at 11:52:00PM +0200, Dawid Wróbel wrote:
> The Xiaomi Mi Pad 5 Pro 5G (enuma) ships the same CSOT panel as the Mi
> Pad 5 Pro (elish), so it falls back to the elish compatible. Give it a
> device-specific one in front, so a later difference does not need a
> device tree change.
> 
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
>  Documentation/devicetree/bindings/display/panel/novatek,nt36523.yaml | 4 ++++
>  1 file changed, 4 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G

[Dawid Wróbel via B4 Relay]

From: Dawid Wróbel <me@dawidwrobel.com>

The Mi Pad 5 Pro 5G (enuma) is the modem-equipped variant of the Mi Pad
5 Pro (elish) and shares its board design, so it falls back to the elish
compatible.

Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index f8c37096df46..a19d0146ae4b 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -1110,6 +1110,11 @@ properties:
               - xiaomi,pipa
           - const: qcom,sm8250
 
+      - items:
+          - const: xiaomi,enuma
+          - const: xiaomi,elish
+          - const: qcom,sm8250
+
       - items:
           - enum:
               - microsoft,surface-duo2

-- 
2.55.0

Re: [PATCH 2/4] dt-bindings: arm: qcom: add the Xiaomi Mi Pad 5 Pro 5G

[Krzysztof Kozlowski]

On Thu, Jul 30, 2026 at 11:52:01PM +0200, Dawid Wróbel wrote:
> The Mi Pad 5 Pro 5G (enuma) is the modem-equipped variant of the Mi Pad
> 5 Pro (elish) and shares its board design, so it falls back to the elish
> compatible.
> 
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
>  Documentation/devicetree/bindings/arm/qcom.yaml | 5 +++++
>  1 file changed, 5 insertions(+)

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>

Best regards,
Krzysztof

[PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node

[Dawid Wróbel via B4 Relay]

From: Dawid Wróbel <me@dawidwrobel.com>

The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
variant, so give the node a label to allow overriding the property.

Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
 arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
index 19aff83ecf7b..12a2ba48340f 100644
--- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
@@ -817,7 +817,7 @@ &pcie0_phy {
 };
 
 &pcieport0 {
-	wifi@0 {
+	wifi_0: wifi@0 {
 		compatible = "pci17cb,1101";
 		reg = <0x10000 0x0 0x0 0x0 0x0>;
 

-- 
2.55.0

Re: [PATCH 3/4] arm64: dts: qcom: sm8250-xiaomi-elish: label the WiFi node

[Krzysztof Kozlowski]

On Thu, Jul 30, 2026 at 11:52:02PM +0200, Dawid Wróbel wrote:
> The Mi Pad 5 Pro 5G shares this device tree but needs its own board data
> variant, so give the node a label to allow overriding the property.
> 
> Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
> ---
>  arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> index 19aff83ecf7b..12a2ba48340f 100644
> --- a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-elish-common.dtsi
> @@ -817,7 +817,7 @@ &pcie0_phy {
>  };
>  
>  &pcieport0 {
> -	wifi@0 {
> +	wifi_0: wifi@0 {

This is pointless on its own. Label does not end up in DTB, so your
patch has zero effect.

You miss the user of the label here.

Best regards,
Krzysztof

[PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

[Dawid Wróbel via B4 Relay]

From: Dawid Wróbel <me@dawidwrobel.com>

The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
Mi Pad 5 Pro. The board is otherwise the elish design, so describe it as
the common device tree plus its own board ID, panel compatible and WiFi
board data variant.

Unlike elish, this model shipped with a single display variant, so there
is one device tree rather than a per-panel pair.

Signed-off-by: Dawid Wróbel <me@dawidwrobel.com>
---
 arch/arm64/boot/dts/qcom/Makefile                |  1 +
 arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts | 26 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile
index e05414290d8e..529e29ffb25a 100644
--- a/arch/arm64/boot/dts/qcom/Makefile
+++ b/arch/arm64/boot/dts/qcom/Makefile
@@ -369,6 +369,7 @@ dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx203.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-sony-xperia-edo-pdx206.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish-boe.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-elish-csot.dtb
+dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-enuma.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8250-xiaomi-pipa.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-hdk.dtb
 dtb-$(CONFIG_ARCH_QCOM)	+= sm8350-microsoft-surface-duo2.dtb
diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
new file mode 100644
index 000000000000..7cc9ed7d12b2
--- /dev/null
+++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: BSD-3-Clause
+/*
+ * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
+ */
+
+/dts-v1/;
+
+#include "sm8250-xiaomi-elish-common.dtsi"
+
+/ {
+	model = "Xiaomi Mi Pad 5 Pro 5G";
+	compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
+
+	/* Platform type differs from elish; msm-id is inherited unchanged. */
+	qcom,board-id = <0x2e 0>;
+};
+
+&display_panel {
+	compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
+		     "novatek,nt36523";
+	status = "okay";
+};
+
+&wifi_0 {
+	qcom,calibration-variant = "Xiaomi_Pad_5Pro_5G";
+};

-- 
2.55.0

Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 3 potential issue(s) to consider:
- [Low] The newly added device tree source `sm8250-xiaomi-enuma.dts` fails to compile because it references an undefined label `&wifi_0`.
- [Low] The root `compatible` string violates the `qcom.yaml` schema expectations and will fail `make dtbs_check`.
- [Low] The display panel `compatible` string violates the `novatek,nt36523.yaml` schema expectations and will fail `make dtbs_check`.
--

--- Patch [4]: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G ---
commit 3ad8e67e479446954f8eea3da616a9b04bf046b8
Author: Dawid Wróbel <me@dawidwrobel.com>

arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

This patch adds a new device tree for the Xiaomi Mi Pad 5 Pro 5G (enuma),
which is the modem-equipped variant of the Mi Pad 5 Pro. It describes the
board using the common device tree along with its own board ID, panel
compatible, and WiFi board data variant.

> diff --git a/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> new file mode 100644
> index 0000000000000..7cc9ed7d12b28
> --- /dev/null
> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> @@ -0,0 +1,26 @@
[ ... ]
> +/ {
> +	model = "Xiaomi Mi Pad 5 Pro 5G";
> +	compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";

[Severity: Low]
Does this root compatible string violate the qcom.yaml schema expectations?
It looks like it contains 3 items instead of the strictly expected 2, and
"xiaomi,enuma" is not documented in the schema, which could cause
make dtbs_check to fail.

> +
> +	/* Platform type differs from elish; msm-id is inherited unchanged. */
> +	qcom,board-id = <0x2e 0>;
> +};
> +
> +&display_panel {
> +	compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
> +		     "novatek,nt36523";

[Severity: Low]
Does this display panel compatible string violate the novatek,nt36523.yaml
schema expectations? It appears to contain 3 items instead of 2, and
"xiaomi,enuma-csot-nt36523" is not listed in the schema, which could cause
a make dtbs_check failure.

> +	status = "okay";
> +};
> +
> +&wifi_0 {

[Severity: Low]
Is wifi_0 defined in any of the included files? It looks like this block
references an undefined label &wifi_0, which triggers a fatal dtc compile
error during make dtbs.

> +	qcom,calibration-variant = "Xiaomi_Pad_5Pro_5G";
> +};

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260730-sm8250-xiaomi-enuma-v1-0-ed6d8fb99668@dawidwrobel.com?part=4

Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

[Konrad Dybcio]

On 7/30/26 11:52 PM, Dawid Wróbel via B4 Relay wrote:
> From: Dawid Wróbel <me@dawidwrobel.com>
> 
> The Mi Pad 5 Pro 5G (enuma, 2021) is the modem-equipped variant of the
> Mi Pad 5 Pro. The board is otherwise the elish design, so describe it as
> the common device tree plus its own board ID, panel compatible and WiFi
> board data variant.

[...]

> +++ b/arch/arm64/boot/dts/qcom/sm8250-xiaomi-enuma.dts
> @@ -0,0 +1,26 @@
> +// SPDX-License-Identifier: BSD-3-Clause
> +/*
> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>

Happy new year!

> + */
> +
> +/dts-v1/;
> +
> +#include "sm8250-xiaomi-elish-common.dtsi"
> +
> +/ {
> +	model = "Xiaomi Mi Pad 5 Pro 5G";
> +	compatible = "xiaomi,enuma", "xiaomi,elish", "qcom,sm8250";
> +
> +	/* Platform type differs from elish; msm-id is inherited unchanged. */
> +	qcom,board-id = <0x2e 0>;
> +};
> +
> +&display_panel {
> +	compatible = "xiaomi,enuma-csot-nt36523", "xiaomi,elish-csot-nt36523",
> +		     "novatek,nt36523";
> +	status = "okay";

ultra nit: \n before status is preferred

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad

Re: [PATCH 4/4] arm64: dts: qcom: sm8250: add device tree for the Xiaomi Mi Pad 5 Pro 5G

[Dawid Wrobel]

On 18.08.2026 12:48, Konrad Dybcio wrote:

>> + * Copyright (c) 2025 Dawid Wróbel <me@dawidwrobel.com>
> 
> Happy new year!

Hah, indeed!
>> +	status = "okay";
> 
> ultra nit: \n before status is preferred

Thank you for the review. Both fixed in v3, which I just sent out:
https://lore.kernel.org/r/20260908-sm8250-xiaomi-enuma-v3-0-0198c3bf954a@dawidwrobel.com

Note that v2 had been on the list for two weeks when you reviewed this
one, so it may have slipped past you. It folds the WiFi-label patch into
this one per Krzysztof's feedback. I *did* carry your Reviewed-by onto
the v3 patch, though — let me know if you'd rather take another look on
that fold.

-- 
With Kind Regards,
Dawid Wrobel