* [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210
@ 2026-10-08 9:14 Varadarajan Narayanan
2026-10-08 9:14 ` [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan
` (10 more replies)
0 siblings, 11 replies; 18+ messages in thread
From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Abel Vesa
Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan,
Konrad Dybcio
This couple of patches enable mutliple peripherals like USB, PCIe etc.
Additionally, it enables CPUfreq and thermal tripping points.
Please refer to [1] for initial review comments on the PCIe related DT
changes.
1 - https://lore.kernel.org/linux-arm-msm/20260514-pci-ipq5210-v1-0-a09436200b35@oss.qualcomm.com/
Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
---
Changes in v6:
- Didn't touch the existing patch as it has R-b
- Add DT changes to enable more devices. Not sure if these can be squashed
into a single patch. Please let me know, will squash if that is
preferrable. Following were added
Random number generator
SPI node definitions
I2C definitions
PWM block
Download mode support
ICE support for sdhci
C3 CPU idle state
Support for WPS button
- New compatibles used are documented in
https://lore.kernel.org/linux-arm-msm/20261008-rng-v1-1-785580a8b48f@oss.qualcomm.com/
https://lore.kernel.org/linux-arm-msm/20261008-pwm-v1-1-0b8776398632@oss.qualcomm.com/
- Link to v5: https://lore.kernel.org/r/20260907-08-dts-v5-0-584e5ab50b40@oss.qualcomm.com
Changes in v5:
- Pick one R-b Konrad
- Do not remove ipq5210-rdp504.dtb from arch/arm64/boot/dts/qcom/Makefile
and add it in a subsequent patch. Instead, move the ipq5210-rdp504.dts
nodes to ipq5210-rdp504.dtb-common.dtsi and include common dtsi in rdp504
dts file and introduce rdp504-nand dts in the 3rd patch
- No code changes
- Link to v4: https://lore.kernel.org/r/20260724-08-dts-v4-0-65e61a1061f0@oss.qualcomm.com
Changes in v4:
- Fix following sashiko comments
- Add #include <dt-bindings/thermal/thermal.h> to dtsi file for
THERMAL_NO_LIMIT definition
- Change tsens interrupt from edge to level
- Remove ipq5210-rdp504.dtb from Makefile in the second patch to
avoid build break and add it back in the 3rd patch
- Dependency related sashiko comments ignored as they are addressed in the
prerequisite patch information
- Link to v3: https://lore.kernel.org/r/20260723-08-dts-v3-0-074eb131f382@oss.qualcomm.com
Changes in v3:
- Address v2 comments
- Introduce RDP504 common dtsi and two board specific dts files one
for NAND and one for eMMC
- Move 'dr_mode' to board file instead of SoC file
- Dropped 'polling-delay-passive = 0' and 'polling-delay = 0'
- Use THERMAL_NO_LIMIT in 'cooling-device'
- '\n' before status = okay
- Removed 'num-lanes' from pcie0 & pcie1 nodes
- Link to v2: https://lore.kernel.org/r/20260715-08-dts-v2-0-b060b68e0256@oss.qualcomm.com
Changes in v2:
- Change usb3@8a00000 -> usb@8a00000
- Ignore other comments as they are covered in the following prerequisite
prerequisite-message-id: <20260514-icc-ipq5210-v1-0-b5070dfbe460@oss.qualcomm.com>
- Link to v1: https://lore.kernel.org/r/20260707-08-dts-v1-0-fce82e14cd1d@oss.qualcomm.com
---
Varadarajan Narayanan (11):
arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals
arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file
arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file
arm64: dts: qcom: ipq5210: Add support for WPS button
arm64: dts: qcom: ipq5210: Add C3 CPU idle state
arm64: dts: qcom: ipq5210: Add ICE support to SDHCI
arm64: dts: qcom: ipq5210: Enable download mode support
arm64: dts: qcom: ipq5210: Enable the PWM block
arm64: dts: qcom: ipq5210: Add I2C nodes
arm64: dts: qcom: ipq5210: Add SPI node definitions
arm64: dts: qcom: ipq5210: Add random number generator node
arch/arm64/boot/dts/qcom/Makefile | 2 +-
.../arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 267 ++++++++
arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts | 29 +
arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts | 66 +-
arch/arm64/boot/dts/qcom/ipq5210.dtsi | 725 ++++++++++++++++++++-
5 files changed, 1014 insertions(+), 75 deletions(-)
---
base-commit: cf4a8255a424f691f95dfa378e88336f33aa8ae4
change-id: 20260706-08-dts-e830bb27c72b
prerequisite-message-id: <20260514-icc-ipq5210-v1-0-b5070dfbe460@oss.qualcomm.com>
prerequisite-patch-id: 0b6145b6635b18fe79fbbff5815041b43778c5ed
prerequisite-patch-id: 924c6ff7baf4283ac7991ee94c803a00fc5cece4
prerequisite-patch-id: c2fe1800fe769dccd37f94c19860a07f979e3c4c
prerequisite-message-id: <20260615085218.1421347-1-varadarajan.narayanan@oss.qualcomm.com>
prerequisite-patch-id: 66aa95814074faffb61393faa30396c42af41126
prerequisite-patch-id: 0a03dc1c91a2f0c03af823aa43f59a9005eb8607
prerequisite-message-id: <20261008-pwm-v1-1-0b8776398632@oss.qualcomm.com>
prerequisite-patch-id: 5d4c92815c73188205f1b05d0f42b02224e9f51e
prerequisite-message-id: <20261008-rng-v1-1-785580a8b48f@oss.qualcomm.com>
prerequisite-patch-id: 08aa18faecd4f3588cfd01f3330eadb1a76dcd13
prerequisite-patch-id: 35e083bb85434a34d86467e53b9eae14f78da125
Best regards,
--
Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
^ permalink raw reply [flat|nested] 18+ messages in thread* [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:31 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan ` (9 subsequent siblings) 10 siblings, 1 reply; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan, Konrad Dybcio Describe common IPQ5210 SoC peripherals in the base DTSI so board DTS files can enable the hardware they use. Add nodes for USB, PCIe, QPIC NAND/BAM, QFPROM, TSENS and thermal zones. Also describe the CPU OPP table and CPU cooling cells needed for CPU frequency scaling and thermal throttling. Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 605 +++++++++++++++++++++++++++++++++- 1 file changed, 599 insertions(+), 6 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 20e8b240642c..161b5bb5a7f7 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -4,8 +4,11 @@ */ #include <dt-bindings/interrupt-controller/arm-gic.h> +#include <dt-bindings/clock/qcom,apss-ipq.h> #include <dt-bindings/clock/qcom,ipq5210-gcc.h> +#include <dt-bindings/interconnect/qcom,ipq5210.h> #include <dt-bindings/reset/qcom,ipq5210-gcc.h> +#include <dt-bindings/thermal/thermal.h> / { #address-cells = <2>; @@ -28,36 +31,48 @@ cpus { #address-cells = <1>; #size-cells = <0>; - cpu@0 { + cpu0: cpu@0 { device_type = "cpu"; compatible = "arm,cortex-a53"; reg = <0x0>; enable-method = "psci"; next-level-cache = <&l2_0>; + #cooling-cells = <2>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; - cpu@1 { + cpu1: cpu@1 { device_type = "cpu"; compatible = "arm,cortex-a53"; reg = <0x1>; enable-method = "psci"; next-level-cache = <&l2_0>; + #cooling-cells = <2>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; - cpu@2 { + cpu2: cpu@2 { device_type = "cpu"; compatible = "arm,cortex-a53"; reg = <0x2>; enable-method = "psci"; next-level-cache = <&l2_0>; + #cooling-cells = <2>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; - cpu@3 { + cpu3: cpu@3 { device_type = "cpu"; compatible = "arm,cortex-a53"; reg = <0x3>; enable-method = "psci"; next-level-cache = <&l2_0>; + #cooling-cells = <2>; + clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; + operating-points-v2 = <&cpu_opp_table>; }; l2_0: l2-cache { @@ -84,6 +99,40 @@ memory@80000000 { reg = <0x0 0x80000000 0x0 0x0>; }; + cpu_opp_table: opp-table-cpu { + compatible = "operating-points-v2-kryo-cpu"; + opp-shared; + nvmem-cells = <&cpu_speed_bin>; + + opp-816000000 { + opp-hz = /bits/ 64 <816000000>; + opp-supported-hw = <0x3>; + opp-microvolt = <850000>; + clock-latency-ns = <200000>; + }; + + opp-1008000000 { + opp-hz = /bits/ 64 <1008000000>; + opp-supported-hw = <0x3>; + opp-microvolt = <850000>; + clock-latency-ns = <200000>; + }; + + opp-1200000000 { + opp-hz = /bits/ 64 <1200000000>; + opp-supported-hw = <0x3>; + opp-microvolt = <850000>; + clock-latency-ns = <200000>; + }; + + opp-1416000000 { + opp-hz = /bits/ 64 <1416000000>; + opp-supported-hw = <0x1>; + opp-microvolt = <1000000>; + clock-latency-ns = <200000>; + }; + }; + pmu { compatible = "arm,cortex-a53-pmu"; interrupts = <GIC_PPI 7 (GIC_CPU_MASK_SIMPLE(4) | IRQ_TYPE_LEVEL_HIGH)>; @@ -130,6 +179,170 @@ soc@0 { dma-ranges = <0 0 0 0 0x10 0>; ranges = <0 0 0 0 0x10 0>; + qusb_phy_0: phy@7b000 { + compatible = "qcom,ipq5210-qusb2-phy", "qcom,ipq6018-qusb2-phy"; + reg = <0x0 0x0007b000 0x0 0x180>; + #phy-cells = <0>; + + clocks = <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, + <&xo_board>; + clock-names = "cfg_ahb", + "ref"; + + resets = <&gcc GCC_QUSB2_0_PHY_BCR>; + status = "disabled"; + }; + + ssphy_0: phy@7d000 { + compatible = "qcom,ipq5210-qmp-usb3-phy", "qcom,ipq9574-qmp-usb3-phy"; + reg = <0x0 0x0007d000 0x0 0xa00>; + #phy-cells = <0>; + + clocks = <&gcc GCC_USB0_AUX_CLK>, + <&xo_board>, + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, + <&gcc GCC_USB0_PIPE_CLK>; + clock-names = "aux", + "ref", + "cfg_ahb", + "pipe"; + + resets = <&gcc GCC_USB0_PHY_BCR>, + <&gcc GCC_USB3PHY_0_PHY_BCR>; + reset-names = "phy", + "phy_phy"; + + #clock-cells = <0>; + clock-output-names = "usb0_pipe_clk"; + + status = "disabled"; + }; + + pcie0_phy: phy@84000 { + compatible = "qcom,ipq5210-qmp-gen3x1-pcie-phy"; + reg = <0x0 0x00084000 0x0 0x1000>; + + clocks = <&gcc GCC_PCIE0_AUX_CLK>, + <&gcc GCC_PCIE0_AHB_CLK>, + <&gcc GCC_PCIE0_PIPE_CLK>; + clock-names = "aux", "cfg_ahb", "pipe"; + + assigned-clocks = <&gcc GCC_PCIE0_AUX_CLK>; + assigned-clock-rates = <20000000>; + + resets = <&gcc GCC_PCIE0_PHY_BCR>, + <&gcc GCC_PCIE0PHY_PHY_BCR>; + reset-names = "phy", "common"; + + #clock-cells = <0>; + clock-output-names = "pcie0_pipe_clk"; + + #phy-cells = <0>; + status = "disabled"; + }; + + pcie1_phy: phy@f4000 { + compatible = "qcom,ipq5210-qmp-gen3x2-pcie-phy", + "qcom,ipq9574-qmp-gen3x2-pcie-phy"; + reg = <0x0 0x000f4000 0x0 0x2000>; + + clocks = <&gcc GCC_PCIE1_AUX_CLK>, + <&gcc GCC_PCIE1_AHB_CLK>, + <&gcc GCC_PCIE1_PIPE_CLK>; + clock-names = "aux", "cfg_ahb", "pipe"; + + assigned-clocks = <&gcc GCC_PCIE1_AUX_CLK>; + assigned-clock-rates = <20000000>; + + resets = <&gcc GCC_PCIE1_PHY_BCR>, + <&gcc GCC_PCIE1PHY_PHY_BCR>; + reset-names = "phy", "common"; + + #clock-cells = <0>; + clock-output-names = "pcie1_pipe_clk"; + + #phy-cells = <0>; + status = "disabled"; + }; + + efuse@a4000 { + compatible = "qcom,ipq5210-qfprom", "qcom,qfprom"; + reg = <0x0 0x000a4000 0x0 0x741>; + #address-cells = <1>; + #size-cells = <1>; + + cpu_speed_bin: cpu-speed-bin@28 { + reg = <0x28 0x1>; + bits = <0 8>; + }; + + tsens_sens11_off: s11@3dd { + reg = <0x3dd 0x1>; + bits = <4 4>; + }; + + tsens_sens12_off: s12@3de { + reg = <0x3de 0x1>; + bits = <0 4>; + }; + + tsens_sens13_off: s13@3de { + reg = <0x3de 0x1>; + bits = <4 4>; + }; + + tsens_sens14_off: s14@3e5 { + reg = <0x3e5 0x2>; + bits = <7 4>; + }; + + tsens_sens15_off: s15@3e6 { + reg = <0x3e6 0x1>; + bits = <3 4>; + }; + + tsens_mode: mode@419 { + reg = <0x419 0x1>; + bits = <0 3>; + }; + + tsens_base0: base0@419 { + reg = <0x419 0x2>; + bits = <3 10>; + }; + + tsens_base1: base1@41a { + reg = <0x41a 0x2>; + bits = <5 10>; + }; + }; + + tsens: thermal-sensor@4a9000 { + compatible = "qcom,ipq5210-tsens", "qcom,ipq5332-tsens"; + reg = <0x0 0x004a9000 0x0 0x1000>, + <0x0 0x004a8000 0x0 0x1000>; + nvmem-cells = <&tsens_mode>, + <&tsens_base0>, + <&tsens_base1>, + <&tsens_sens11_off>, + <&tsens_sens12_off>, + <&tsens_sens13_off>, + <&tsens_sens14_off>, + <&tsens_sens15_off>; + nvmem-cell-names = "mode", + "base0", + "base1", + "tsens_sens11_off", + "tsens_sens12_off", + "tsens_sens13_off", + "tsens_sens14_off", + "tsens_sens15_off"; + interrupts = <GIC_SPI 52 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "combined"; + #thermal-sensor-cells = <1>; + #qcom,sensors = <5>; + }; + tlmm: pinctrl@1000000 { compatible = "qcom,ipq5210-tlmm"; reg = <0x0 0x01000000 0x0 0x300000>; @@ -146,8 +359,8 @@ gcc: clock-controller@1800000 { reg = <0x0 0x01800000 0x0 0x40000>; clocks = <&xo_board>, <&sleep_clk>, - <0>, - <0>, + <&pcie0_phy>, + <&pcie1_phy>, <0>, <0>; #clock-cells = <1>; @@ -205,6 +418,87 @@ sdhc: mmc@7804000 { status = "disabled"; }; + qpic_bam: dma-controller@7984000 { + compatible = "qcom,bam-v1.7.0"; + reg = <0x0 0x07984000 0x0 0x1c000>; + interrupts = <GIC_SPI 56 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&gcc GCC_QPIC_AHB_CLK>; + clock-names = "bam_clk"; + #dma-cells = <1>; + qcom,ee = <0>; + status = "disabled"; + }; + + qpic_nand: spi@79b0000 { + compatible = "qcom,ipq5210-snand", "qcom,ipq9574-snand"; + reg = <0x0 0x079b0000 0x0 0x10000>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&gcc GCC_QPIC_CLK>, + <&gcc GCC_QPIC_AHB_CLK>, + <&gcc GCC_QPIC_IO_MACRO_CLK>; + clock-names = "core", + "aon", + "iom"; + + dmas = <&qpic_bam 0>, + <&qpic_bam 1>, + <&qpic_bam 2>; + dma-names = "tx", + "rx", + "cmd"; + + status = "disabled"; + }; + + usb3: usb@8a00000 { + compatible = "qcom,ipq5210-dwc3", "qcom,snps-dwc3"; + reg = <0x0 0x08a00000 0x0 0x200000>; + + clocks = <&gcc GCC_CNOC_USB_CLK>, + <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_PHY_CFG_AHB_CLK>, + <&gcc GCC_USB0_SLEEP_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; + + clock-names = "cfg_noc", + "core", + "iface", + "sleep", + "mock_utmi"; + + assigned-clocks = <&gcc GCC_USB0_MASTER_CLK>, + <&gcc GCC_USB0_MOCK_UTMI_CLK>; + assigned-clock-rates = <200000000>, + <24000000>; + + interrupts-extended = <&intc GIC_SPI 161 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 163 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 165 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 174 IRQ_TYPE_LEVEL_HIGH>, + <&intc GIC_SPI 175 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "dwc_usb3", + "pwr_event", + "qusb2_phy", + "dp_hs_phy_irq", + "dm_hs_phy_irq"; + + phys = <&qusb_phy_0>, + <&ssphy_0>; + phy-names = "usb2-phy", + "usb3-phy"; + + resets = <&gcc GCC_USB_BCR>; + + tx-fifo-resize; + snps,is-utmi-l1-suspend; + snps,hird-threshold = /bits/ 8 <0x0>; + snps,dis_u2_susphy_quirk; + snps,dis_u3_susphy_quirk; + + status = "disabled"; + }; + intc: interrupt-controller@b000000 { compatible = "qcom,msm-qgic2"; interrupt-controller; @@ -244,6 +538,24 @@ watchdog@b017000 { clocks = <&sleep_clk>; }; + apcs_glb: mailbox@b111000 { + compatible = "qcom,ipq5210-apcs-apps-global", + "qcom,ipq6018-apcs-apps-global"; + reg = <0x0 0x0b111000 0x0 0x1000>; + #clock-cells = <1>; + clocks = <&a53pll>, <&xo_board>, <&gcc GPLL0>; + clock-names = "pll", "xo", "gpll0"; + #mbox-cells = <1>; + }; + + a53pll: clock@b116000 { + compatible = "qcom,ipq5210-a53pll"; + reg = <0x0 0x0b116000 0x0 0x1000>; + #clock-cells = <0>; + clocks = <&xo_board>; + clock-names = "xo"; + }; + timer@b120000 { compatible = "arm,armv7-timer-mem"; reg = <0x0 0x0b120000 0x0 0x1000>; @@ -307,6 +619,287 @@ frame@b128000 { status = "disabled"; }; }; + + pcie1: pcie@50000000 { + compatible = "qcom,pcie-ipq5210", "qcom,pcie-ipq9574"; + reg = <0x0 0x50000000 0x0 0xf1c>, + <0x0 0x50000f20 0x0 0xa8>, + <0x0 0x50001000 0x0 0x1000>, + <0x0 0x000f0000 0x0 0x3000>, + <0x0 0x50100000 0x0 0x1000>, + <0x0 0x000f6000 0x0 0x1000>; + reg-names = "dbi", + "elbi", + "atu", + "parf", + "config", + "mhi"; + device_type = "pci"; + linux,pci-domain = <1>; + bus-range = <0x00 0xff>; + #address-cells = <3>; + #size-cells = <2>; + + ranges = <0x01000000 0x0 0x0 0x0 0x50200000 0x0 0x00100000>, + <0x02000000 0x0 0x0 0x0 0x50300000 0x0 0x0fd00000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0x7>; + interrupt-map = <0 0 0 1 &intc 0 0 GIC_SPI 200 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 2 &intc 0 0 GIC_SPI 201 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 3 &intc 0 0 GIC_SPI 202 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 4 &intc 0 0 GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>; + + interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 192 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 193 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 194 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 195 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 196 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 197 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 198 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 199 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi0", + "msi1", + "msi2", + "msi3", + "msi4", + "msi5", + "msi6", + "msi7", + "global"; + + clocks = <&gcc GCC_PCIE1_AXI_M_CLK>, + <&gcc GCC_PCIE1_AXI_S_CLK>, + <&gcc GCC_PCIE1_AXI_S_BRIDGE_CLK>, + <&gcc GCC_PCIE1_RCHNG_CLK>, + <&gcc GCC_PCIE1_AHB_CLK>, + <&gcc GCC_PCIE1_AUX_CLK>; + clock-names = "axi_m", + "axi_s", + "axi_bridge", + "rchng", + "ahb", + "aux"; + + resets = <&gcc GCC_PCIE1_PIPE_ARES>, + <&gcc GCC_PCIE1_CORE_STICKY_RESET>, + <&gcc GCC_PCIE1_AXI_S_STICKY_RESET>, + <&gcc GCC_PCIE1_AXI_S_ARES>, + <&gcc GCC_PCIE1_AXI_M_STICKY_RESET>, + <&gcc GCC_PCIE1_AXI_M_ARES>, + <&gcc GCC_PCIE1_AUX_ARES>, + <&gcc GCC_PCIE1_AHB_ARES>; + reset-names = "pipe", + "sticky", + "axi_s_sticky", + "axi_s", + "axi_m_sticky", + "axi_m", + "aux", + "ahb"; + + interconnects = <&gcc MASTER_CNOC_PCIE1 &gcc SLAVE_CNOC_PCIE1>, + <&gcc MASTER_SNOC_PCIE1 &gcc SLAVE_SNOC_PCIE1>; + interconnect-names = "pcie-mem", "cpu-pcie"; + + status = "disabled"; + + pcie1_port0: pcie@0 { + device_type = "pci"; + reg = <0x0 0x0 0x0 0x0 0x0>; + bus-range = <0x01 0xff>; + + phys = <&pcie1_phy>; + + #address-cells = <3>; + #size-cells = <2>; + ranges; + }; + }; + + pcie0: pcie@70000000 { + compatible = "qcom,pcie-ipq5210", "qcom,pcie-ipq9574"; + reg = <0x0 0x70000000 0x0 0xf1c>, + <0x0 0x70000f20 0x0 0xa8>, + <0x0 0x70001000 0x0 0x1000>, + <0x0 0x00080000 0x0 0x3000>, + <0x0 0x70100000 0x0 0x1000>, + <0x0 0x00086000 0x0 0x1000>; + reg-names = "dbi", + "elbi", + "atu", + "parf", + "config", + "mhi"; + device_type = "pci"; + linux,pci-domain = <0>; + bus-range = <0x00 0xff>; + #address-cells = <3>; + #size-cells = <2>; + + ranges = <0x01000000 0x0 0x0 0x0 0x70200000 0x0 0x00100000>, + <0x02000000 0x0 0x0 0x0 0x70300000 0x0 0x0fd00000>; + + #interrupt-cells = <1>; + interrupt-map-mask = <0 0 0 0x7>; + interrupt-map = <0 0 0 1 &intc 0 0 GIC_SPI 185 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 2 &intc 0 0 GIC_SPI 186 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 3 &intc 0 0 GIC_SPI 187 IRQ_TYPE_LEVEL_HIGH>, + <0 0 0 4 &intc 0 0 GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>; + + interrupts = <GIC_SPI 176 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 178 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 179 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 180 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 181 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 182 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>, + <GIC_SPI 184 IRQ_TYPE_LEVEL_HIGH>; + interrupt-names = "msi0", + "msi1", + "msi2", + "msi3", + "msi4", + "msi5", + "msi6", + "msi7", + "global"; + + clocks = <&gcc GCC_PCIE0_AXI_M_CLK>, + <&gcc GCC_PCIE0_AXI_S_CLK>, + <&gcc GCC_PCIE0_AXI_S_BRIDGE_CLK>, + <&gcc GCC_PCIE0_RCHNG_CLK>, + <&gcc GCC_PCIE0_AHB_CLK>, + <&gcc GCC_PCIE0_AUX_CLK>; + clock-names = "axi_m", + "axi_s", + "axi_bridge", + "rchng", + "ahb", + "aux"; + + resets = <&gcc GCC_PCIE0_PIPE_ARES>, + <&gcc GCC_PCIE0_CORE_STICKY_RESET>, + <&gcc GCC_PCIE0_AXI_S_STICKY_RESET>, + <&gcc GCC_PCIE0_AXI_S_ARES>, + <&gcc GCC_PCIE0_AXI_M_STICKY_RESET>, + <&gcc GCC_PCIE0_AXI_M_ARES>, + <&gcc GCC_PCIE0_AUX_ARES>, + <&gcc GCC_PCIE0_AHB_ARES>; + reset-names = "pipe", + "sticky", + "axi_s_sticky", + "axi_s", + "axi_m_sticky", + "axi_m", + "aux", + "ahb"; + + interconnects = <&gcc MASTER_CNOC_PCIE0 &gcc SLAVE_CNOC_PCIE0>, + <&gcc MASTER_SNOC_PCIE0 &gcc SLAVE_SNOC_PCIE0>; + interconnect-names = "pcie-mem", "cpu-pcie"; + + status = "disabled"; + + pcie0_port0: pcie@0 { + device_type = "pci"; + reg = <0x0 0x0 0x0 0x0 0x0>; + bus-range = <0x01 0xff>; + + phys = <&pcie0_phy>; + + #address-cells = <3>; + #size-cells = <2>; + ranges; + }; + }; + }; + + thermal_zones: thermal-zones { + ethphy-thermal { + thermal-sensors = <&tsens 11>; + + trips { + ethphy-critical { + temperature = <125000>; + hysteresis = <9000>; + type = "critical"; + }; + }; + }; + + pon-uniphy-thermal { + thermal-sensors = <&tsens 12>; + + trips { + pon-uniphy-critical { + temperature = <125000>; + hysteresis = <9000>; + type = "critical"; + }; + }; + }; + + nss-top-thermal { + thermal-sensors = <&tsens 13>; + + trips { + nss-top-critical { + temperature = <125000>; + hysteresis = <9000>; + type = "critical"; + }; + }; + }; + + cpu0-thermal { + thermal-sensors = <&tsens 14>; + + trips { + cpu-critical { + temperature = <120000>; + hysteresis = <9000>; + type = "critical"; + }; + + cpu0_thermal_alert: cpu-passive { + temperature = <110000>; + hysteresis = <9000>; + type = "passive"; + }; + }; + + cooling-maps { + map0 { + trip = <&cpu0_thermal_alert>; + /* Set maximum frequency as 816 MHz */ + cooling-device = <&cpu0 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu1 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu2 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>, + <&cpu3 THERMAL_NO_LIMIT THERMAL_NO_LIMIT>; + }; + }; + }; + + cpu1-thermal { + thermal-sensors = <&tsens 15>; + + trips { + cpu-critical { + temperature = <120000>; + hysteresis = <9000>; + type = "critical"; + }; + + cpu-passive { + temperature = <110000>; + hysteresis = <9000>; + type = "passive"; + }; + }; + }; }; timer { -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals 2026-10-08 9:14 ` [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan @ 2026-10-08 9:31 ` sashiko-bot 0 siblings, 0 replies; 18+ messages in thread From: sashiko-bot @ 2026-10-08 9:31 UTC (permalink / raw) To: Varadarajan Narayanan; +Cc: robh, conor+dt, devicetree Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] arm64: dts: qcom: Inverted PCIe interconnect mapping - [Medium] dts: pcie memory ranges mapped to child address 0x0 breaks identity mapping -- commit 5d6163228edf9eef2412de146956df64b5bb5d49 Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Describe common IPQ5210 SoC peripherals in the base DTSI so board DTS files can enable the hardware they use. > diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > index 20e8b240642c6..161b5bb5a7f74 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi [ ... ] > @@ -307,6 +619,287 @@ frame@b128000 { > status = "disabled"; > }; > }; > + > + pcie1: pcie@50000000 { > + compatible = "qcom,pcie-ipq5210", "qcom,pcie-ipq9574"; [ ... ] > + ranges = <0x01000000 0x0 0x0 0x0 0x50200000 0x0 0x00100000>, > + <0x02000000 0x0 0x0 0x0 0x50300000 0x0 0x0fd00000>; [Severity: Medium] Does mapping the PCI outbound memory space (0x02000000) to a child address of 0x0 break identity mapping here? This allows the Linux PCI core to allocate memory BARs starting at PCI address 0x0 (since PCIBIOS_MIN_MEM is 0 on arm64). Many drivers evaluate a BAR address of 0x0 as unassigned (!pci_resource_start(...)), which can lead to failed driver probes. Furthermore, breaking identity mapping often conflicts with bootloader expectations and endpoints that assume the PCI bus address matches the CPU physical address. Could the child address be set to match the parent CPU physical address (e.g., 0x0 0x50300000) to enforce a 1:1 mapping, as is standard practice for other Qualcomm IPQ SoCs? [ ... ] > + interconnects = <&gcc MASTER_CNOC_PCIE1 &gcc SLAVE_CNOC_PCIE1>, > + <&gcc MASTER_SNOC_PCIE1 &gcc SLAVE_SNOC_PCIE1>; > + interconnect-names = "pcie-mem", "cpu-pcie"; [Severity: Medium] Are the interconnect-names inverted relative to the interconnects array? The pcie-mem name is listed first, which binds it to the MASTER_CNOC_PCIE1 interconnect, while cpu-pcie binds to the MASTER_SNOC_PCIE1 interconnect. CNOC typically governs CPU configuration accesses, while SNOC governs high bandwidth DMA. This mismatch might cause interconnect bandwidth scaling and power domain voting to apply to the wrong NoC paths during DMA or register accesses. [ ... ] > + pcie0: pcie@70000000 { > + compatible = "qcom,pcie-ipq5210", "qcom,pcie-ipq9574"; [ ... ] > + ranges = <0x01000000 0x0 0x0 0x0 0x70200000 0x0 0x00100000>, > + <0x02000000 0x0 0x0 0x0 0x70300000 0x0 0x0fd00000>; [Severity: Medium] Does mapping the PCI outbound memory space (0x02000000) to a child address of 0x0 break identity mapping here as well? Similar to pcie1, mapping this to 0x0 allows the Linux PCI core to allocate memory BARs starting at PCI address 0x0, which causes issues for drivers checking for an unassigned BAR. Could the child address be identical to the parent CPU physical address (e.g., 0x0 0x70300000) to enforce a 1:1 mapping? [ ... ] > + interconnects = <&gcc MASTER_CNOC_PCIE0 &gcc SLAVE_CNOC_PCIE0>, > + <&gcc MASTER_SNOC_PCIE0 &gcc SLAVE_SNOC_PCIE0>; > + interconnect-names = "pcie-mem", "cpu-pcie"; [Severity: Medium] Are the interconnect-names inverted relative to the interconnects array here too? The pcie-mem name is bound to CNOC and cpu-pcie is bound to SNOC, which appears backwards and could lead to performance degradation or QoS failures when NoC bandwidth scaling applies to the wrong paths. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=1 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:21 ` sashiko-bot 2026-10-08 10:48 ` Dmitry Baryshkov 2026-10-08 9:14 ` [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant " Varadarajan Narayanan ` (8 subsequent siblings) 10 siblings, 2 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND share the GPIOs. The board has to be reworked to change from EMMC to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi and include it in variant specific DTS file. Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash and required pinctrl states. Enable QPIC BAM, USB and PCIe for the board. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- .../arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 209 +++++++++++++++++++++ arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts | 66 +------ arch/arm64/boot/dts/qcom/ipq5210.dtsi | 14 +- 3 files changed, 218 insertions(+), 71 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi new file mode 100644 index 000000000000..30c8560822b5 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi @@ -0,0 +1,209 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +/dts-v1/; + +#include <dt-bindings/gpio/gpio.h> +#include "ipq5210.dtsi" + +/ { + aliases { + serial0 = &uart1; + }; + + chosen { + stdout-path = "serial0"; + }; + + vreg_misc_3p3: regulator-usb-3p3 { + compatible = "regulator-fixed"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-boot-on; + regulator-always-on; + regulator-name = "usb_hs_vdda_3p3"; + }; + + vreg_misc_1p8: regulator-usb-1p8 { + compatible = "regulator-fixed"; + regulator-min-microvolt = <1800000>; + regulator-max-microvolt = <1800000>; + regulator-boot-on; + regulator-always-on; + regulator-name = "vdda_1p8_usb"; + }; + + vreg_misc_0p925: regulator-usb-0p925 { + compatible = "regulator-fixed"; + regulator-min-microvolt = <925000>; + regulator-max-microvolt = <925000>; + regulator-boot-on; + regulator-always-on; + regulator-name = "vdd_core_usb"; + }; +}; + +&pcie0 { + pinctrl-0 = <&pcie0_default_state>; + pinctrl-names = "default"; + + status = "okay"; +}; + +&pcie0_phy { + status = "okay"; +}; + +&pcie0_port0 { + reset-gpios = <&tlmm 32 GPIO_ACTIVE_LOW>; +}; + +&pcie1 { + pinctrl-0 = <&pcie1_default_state>; + pinctrl-names = "default"; + + status = "okay"; +}; + +&pcie1_phy { + status = "okay"; +}; + +&pcie1_port0 { + reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>; +}; + +&qpic_bam { + status = "okay"; +}; + +&qpic_nand { + pinctrl-0 = <&qpic_snand_default_state>; + pinctrl-names = "default"; + + flash@0 { + compatible = "spi-nand"; + reg = <0>; + #address-cells = <1>; + #size-cells = <1>; + nand-ecc-engine = <&qpic_nand>; + nand-ecc-strength = <4>; + nand-ecc-step-size = <512>; + }; +}; + +&qusb_phy_0 { + vdd-supply = <&vreg_misc_0p925>; + vdda-pll-supply = <&vreg_misc_1p8>; + vdda-phy-dpdm-supply = <&vreg_misc_3p3>; + + status = "okay"; +}; + +&sdhc { + max-frequency = <192000000>; + bus-width = <4>; + mmc-ddr-1_8v; + mmc-hs200-1_8v; + pinctrl-0 = <&sdhc_default_state>; + pinctrl-names = "default"; +}; + +&sleep_clk { + clock-frequency = <32000>; +}; + +&ssphy_0 { + vdda-pll-supply = <&vreg_misc_1p8>; + vdda-phy-supply = <&vreg_misc_0p925>; + + status = "okay"; +}; + +&tlmm { + pcie1_default_state: pcie1-default-state { + pins = "gpio29"; + function = "gpio"; + drive-strength = <6>; + bias-pull-down; + }; + + pcie0_default_state: pcie0-default-state { + pins = "gpio32"; + function = "gpio"; + drive-strength = <6>; + bias-pull-down; + }; + + qpic_snand_default_state: qpic-snand-default-state { + data-pins { + pins = "gpio0", "gpio1", "gpio2", "gpio3"; + function = "qspi_data"; + drive-strength = <8>; + bias-disable; + }; + + cs-pins { + pins = "gpio4"; + function = "qspi_cs_n"; + drive-strength = <8>; + bias-disable; + }; + + clock-pins { + pins = "gpio5"; + function = "qspi_clk"; + drive-strength = <8>; + bias-disable; + }; + }; + + qup_uart1_default_state: qup-uart1-default-state { + pins = "gpio38", "gpio39"; + function = "qup_se1"; + drive-strength = <6>; + bias-pull-down; + }; + + sdhc_default_state: sdhc-default-state { + data-pins { + pins = "gpio0", "gpio1", "gpio2", "gpio3"; + function = "sdc_data"; + drive-strength = <8>; + bias-pull-up; + }; + + cmd-pins { + pins = "gpio4"; + function = "sdc_cmd"; + drive-strength = <8>; + bias-pull-up; + }; + + clk-pins { + pins = "gpio5"; + function = "sdc_clk"; + drive-strength = <8>; + bias-disable; + }; + }; +}; + +&uart1 { + pinctrl-0 = <&qup_uart1_default_state>; + pinctrl-names = "default"; + + status = "okay"; +}; + +&usb3 { + dr_mode = "host"; + + status = "okay"; +}; + +&xo_board { + clock-frequency = <24000000>; +}; diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts index 941f866ecfe9..e5f2f9217f3b 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts @@ -5,75 +5,13 @@ /dts-v1/; -#include "ipq5210.dtsi" +#include "ipq5210-rdp504-common.dtsi" / { - model = "Qualcomm Technologies, Inc. IPQ5210 RDP504"; + model = "Qualcomm Technologies, Inc. IPQ5210 RDP504 (eMMC)"; compatible = "qcom,ipq5210-rdp504", "qcom,ipq5210"; - - aliases { - serial0 = &uart1; - }; - - chosen { - stdout-path = "serial0"; - }; }; &sdhc { - max-frequency = <192000000>; - bus-width = <4>; - mmc-ddr-1_8v; - mmc-hs200-1_8v; - pinctrl-0 = <&sdhc_default_state>; - pinctrl-names = "default"; - status = "okay"; }; - -&sleep_clk { - clock-frequency = <32000>; -}; - -&tlmm { - qup_uart1_default_state: qup-uart1-default-state { - pins = "gpio38", "gpio39"; - function = "qup_se1"; - drive-strength = <6>; - bias-pull-down; - }; - - sdhc_default_state: sdhc-default-state { - clk-pins { - pins = "gpio5"; - function = "sdc_clk"; - drive-strength = <8>; - bias-disable; - }; - - cmd-pins { - pins = "gpio4"; - function = "sdc_cmd"; - drive-strength = <8>; - bias-pull-up; - }; - - data-pins { - pins = "gpio0", "gpio1", "gpio2", "gpio3"; - function = "sdc_data"; - drive-strength = <8>; - bias-pull-up; - }; - }; -}; - -&uart1 { - pinctrl-0 = <&qup_uart1_default_state>; - pinctrl-names = "default"; - - status = "okay"; -}; - -&xo_board { - clock-frequency = <24000000>; -}; diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 161b5bb5a7f7..3183182d1cc7 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -823,7 +823,7 @@ ethphy-thermal { trips { ethphy-critical { - temperature = <125000>; + temperature = <120000>; hysteresis = <9000>; type = "critical"; }; @@ -835,7 +835,7 @@ pon-uniphy-thermal { trips { pon-uniphy-critical { - temperature = <125000>; + temperature = <120000>; hysteresis = <9000>; type = "critical"; }; @@ -847,7 +847,7 @@ nss-top-thermal { trips { nss-top-critical { - temperature = <125000>; + temperature = <120000>; hysteresis = <9000>; type = "critical"; }; @@ -859,13 +859,13 @@ cpu0-thermal { trips { cpu-critical { - temperature = <120000>; + temperature = <115000>; hysteresis = <9000>; type = "critical"; }; cpu0_thermal_alert: cpu-passive { - temperature = <110000>; + temperature = <100000>; hysteresis = <9000>; type = "passive"; }; @@ -888,13 +888,13 @@ cpu1-thermal { trips { cpu-critical { - temperature = <120000>; + temperature = <115000>; hysteresis = <9000>; type = "critical"; }; cpu-passive { - temperature = <110000>; + temperature = <100000>; hysteresis = <9000>; type = "passive"; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file 2026-10-08 9:14 ` [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan @ 2026-10-08 9:21 ` sashiko-bot 2026-10-08 10:48 ` Dmitry Baryshkov 1 sibling, 0 replies; 18+ messages in thread From: sashiko-bot @ 2026-10-08 9:21 UTC (permalink / raw) To: Varadarajan Narayanan; +Cc: robh, conor+dt, devicetree Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Medium] arm64: dts: qcom: undocumented SoC-wide thermal limit reduction -- commit 0651d4639f9454796e2f9ce2439efba04746c6c9 Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file This commit refactors the RDP504 board configuration to extract common settings into a new shared file. It enables board-specific peripherals like USB, PCIe, and SPI NAND. > diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > index 161b5bb5a7f74..3183182d1cc71 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > @@ -823,7 +823,7 @@ ethphy-thermal { > > trips { > ethphy-critical { > - temperature = <125000>; > + temperature = <120000>; [Severity: Medium] The commit message solely describes extracting common board configurations for the RDP504 board and enabling board-specific peripherals. Is it intentional that this modifies the base SoC device tree file to lower the critical temperature trip point for ethphy-thermal? This alters the thermal characteristics for all IPQ5210-based boards. Should this undocumented SoC-wide thermal limit reduction be separated into its own commit to avoid unexpected regressions on other boards? [ ... ] > @@ -859,13 +859,13 @@ cpu0-thermal { > > trips { > cpu-critical { > - temperature = <120000>; > + temperature = <115000>; [Severity: Medium] Does this intentionally lower the critical temperature for cpu0-thermal in ipq5210.dtsi? This impacts performance throttling and shutdown limits for all boards using this SoC, rather than just the RDP504 board described in the commit message. -- Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=2 ^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file 2026-10-08 9:14 ` [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan 2026-10-08 9:21 ` sashiko-bot @ 2026-10-08 10:48 ` Dmitry Baryshkov 1 sibling, 0 replies; 18+ messages in thread From: Dmitry Baryshkov @ 2026-10-08 10:48 UTC (permalink / raw) To: Varadarajan Narayanan Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa, linux-arm-msm, devicetree, linux-kernel On Thu, Oct 08, 2026 at 02:44:22PM +0530, Varadarajan Narayanan wrote: > RDP504 has USB, PCIe and SPI NAND devices populated. EMMC and NAND > share the GPIOs. The board has to be reworked to change from EMMC > to NAND variant. Rename ipq5210-rdp504.dts as ipq5210-rdp504-common.dtsi > and include it in variant specific DTS file. > > Describe the fixed USB regulators, PCIe reset GPIOs, QPIC SPI NAND flash > and required pinctrl states. Enable QPIC BAM, USB and PCIe for the board. Please don't mix refactoring and the actual changes in a single patch. Please split this into two patches. > > Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> > --- > .../arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 209 +++++++++++++++++++++ > arch/arm64/boot/dts/qcom/ipq5210-rdp504.dts | 66 +------ > arch/arm64/boot/dts/qcom/ipq5210.dtsi | 14 +- > 3 files changed, 218 insertions(+), 71 deletions(-) > -- With best wishes Dmitry ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:26 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 04/11] arm64: dts: qcom: ipq5210: Add support for WPS button Varadarajan Narayanan ` (7 subsequent siblings) 10 siblings, 1 reply; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add DT file for the NAND variant and include it in the Makefile. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/Makefile | 2 +- arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts | 29 ++++++++++++++++++++++++ 2 files changed, 30 insertions(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/qcom/Makefile b/arch/arm64/boot/dts/qcom/Makefile index 88230c4e00ea..94ab6355176f 100644 --- a/arch/arm64/boot/dts/qcom/Makefile +++ b/arch/arm64/boot/dts/qcom/Makefile @@ -32,7 +32,7 @@ dtb-$(CONFIG_ARCH_QCOM) += hamoa-lenovo-ideacentre-mini-01q8x10.dtb dtb-$(CONFIG_ARCH_QCOM) += hawi-mtp.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5018-rdp432-c2.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5018-tplink-archer-ax55-v1.dtb -dtb-$(CONFIG_ARCH_QCOM) += ipq5210-rdp504.dtb +dtb-$(CONFIG_ARCH_QCOM) += ipq5210-rdp504.dtb ipq5210-rdp504-nand.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp441.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp442.dtb dtb-$(CONFIG_ARCH_QCOM) += ipq5332-rdp468.dtb diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts new file mode 100644 index 000000000000..8b7106cbd7c6 --- /dev/null +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts @@ -0,0 +1,29 @@ +// SPDX-License-Identifier: BSD-3-Clause +/* + * Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. + */ + +/dts-v1/; + +#include "ipq5210-rdp504-common.dtsi" + +/ { + model = "Qualcomm Technologies, Inc. IPQ5210 RDP504 (NAND)"; + compatible = "qcom,ipq5210-rdp504", "qcom,ipq5210"; +}; + +&qpic_nand { + status = "okay"; + + flash@0 { + compatible = "spi-nand"; + reg = <0>; + #address-cells = <1>; + #size-cells = <1>; + nand-ecc-engine = <&qpic_nand>; + nand-ecc-strength = <4>; + nand-ecc-step-size = <512>; + spi-rx-bus-width = <4>; + spi-tx-bus-width = <4>; + }; +}; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file 2026-10-08 9:14 ` [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant " Varadarajan Narayanan @ 2026-10-08 9:26 ` sashiko-bot 0 siblings, 0 replies; 18+ messages in thread From: sashiko-bot @ 2026-10-08 9:26 UTC (permalink / raw) To: Varadarajan Narayanan; +Cc: robh, conor+dt, devicetree Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dts: redundant property duplication in flash@0 node -- commit 730037c043b086f6324dee42a3f417cb7d8c240b Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant DT file This commit adds a new Device Tree file for the NAND variant of the IPQ5210 RDP504 board. It also updates the Makefile to include the new dtb target. > diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts > new file mode 100644 > index 0000000000000..8b7106cbd7c6d > --- /dev/null > +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-nand.dts > @@ -0,0 +1,29 @@ [ ... ] > +&qpic_nand { > + status = "okay"; > + > + flash@0 { > + compatible = "spi-nand"; > + reg = <0>; > + #address-cells = <1>; > + #size-cells = <1>; > + nand-ecc-engine = <&qpic_nand>; > + nand-ecc-strength = <4>; > + nand-ecc-step-size = <512>; [Severity: Low] This isn't a bug, but should these properties be omitted here? They appear to be identical to the ones already present in the included ipq5210-rdp504-common.dtsi. Re-declaring them verbatim in the flash@0 node creates duplicate definitions where future updates in the common .dtsi could be silently overridden. Could this node just contain the new spi-rx-bus-width and spi-tx-bus-width properties instead? > + spi-rx-bus-width = <4>; > + spi-tx-bus-width = <4>; > + }; > +}; -- Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=3 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 04/11] arm64: dts: qcom: ipq5210: Add support for WPS button 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (2 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant " Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 05/11] arm64: dts: qcom: ipq5210: Add C3 CPU idle state Varadarajan Narayanan ` (6 subsequent siblings) 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add GPIO related nodes to enable WPS (Wi-Fi Protected Setup) in IPQ5210 based RDPs. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi index 30c8560822b5..9f493561037c 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi @@ -6,6 +6,7 @@ /dts-v1/; #include <dt-bindings/gpio/gpio.h> +#include <dt-bindings/input/input.h> #include "ipq5210.dtsi" / { @@ -17,6 +18,19 @@ chosen { stdout-path = "serial0"; }; + gpio-keys { + compatible = "gpio-keys"; + pinctrl-0 = <&gpio_keys_default>; + pinctrl-names = "default"; + + button-wps { + label = "wps"; + linux,code = <KEY_WPS_BUTTON>; + gpios = <&tlmm 25 GPIO_ACTIVE_LOW>; + debounce-interval = <60>; + }; + }; + vreg_misc_3p3: regulator-usb-3p3 { compatible = "regulator-fixed"; regulator-min-microvolt = <3300000>; @@ -123,6 +137,13 @@ &ssphy_0 { }; &tlmm { + gpio_keys_default: gpio-keys-default-state { + pins = "gpio25"; + function = "gpio"; + drive-strength = <6>; + bias-pull-up; + }; + pcie1_default_state: pcie1-default-state { pins = "gpio29"; function = "gpio"; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 05/11] arm64: dts: qcom: ipq5210: Add C3 CPU idle state 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (3 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 04/11] arm64: dts: qcom: ipq5210: Add support for WPS button Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI Varadarajan Narayanan ` (5 subsequent siblings) 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add the PSCI-backed C3 idle state for the Cortex-A53 CPUs and wire it to all CPU nodes. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 3183182d1cc7..331589a9c1ff 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -36,6 +36,7 @@ cpu0: cpu@0 { compatible = "arm,cortex-a53"; reg = <0x0>; enable-method = "psci"; + cpu-idle-states = <&cpu_sleep_0>; next-level-cache = <&l2_0>; #cooling-cells = <2>; clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; @@ -47,6 +48,7 @@ cpu1: cpu@1 { compatible = "arm,cortex-a53"; reg = <0x1>; enable-method = "psci"; + cpu-idle-states = <&cpu_sleep_0>; next-level-cache = <&l2_0>; #cooling-cells = <2>; clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; @@ -58,6 +60,7 @@ cpu2: cpu@2 { compatible = "arm,cortex-a53"; reg = <0x2>; enable-method = "psci"; + cpu-idle-states = <&cpu_sleep_0>; next-level-cache = <&l2_0>; #cooling-cells = <2>; clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; @@ -69,6 +72,7 @@ cpu3: cpu@3 { compatible = "arm,cortex-a53"; reg = <0x3>; enable-method = "psci"; + cpu-idle-states = <&cpu_sleep_0>; next-level-cache = <&l2_0>; #cooling-cells = <2>; clocks = <&apcs_glb APCS_ALIAS0_CORE_CLK>; @@ -80,6 +84,20 @@ l2_0: l2-cache { cache-level = <2>; cache-unified; }; + + idle-states { + entry-method = "psci"; + + cpu_sleep_0: cpu-sleep-c3 { /* C3 */ + compatible = "arm,idle-state"; + idle-state-name = "power-down"; + arm,psci-suspend-param = <0x40000003>; + entry-latency-us = <181>; + exit-latency-us = <149>; + min-residency-us = <703>; + local-timer-stop; + }; + }; }; firmware { -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (4 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 05/11] arm64: dts: qcom: ipq5210: Add C3 CPU idle state Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 07/11] arm64: dts: qcom: ipq5210: Enable download mode support Varadarajan Narayanan ` (4 subsequent siblings) 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Describe the SDHCI ICE register region and clock, and enable CQE support for the IPQ5210 SDHCI controller. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 15 +++++++++++---- 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 331589a9c1ff..bc9502328738 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -416,9 +416,11 @@ uart1: serial@1a84000 { sdhc: mmc@7804000 { compatible = "qcom,ipq5210-sdhci", "qcom,sdhci-msm-v5"; reg = <0x0 0x07804000 0x0 0x1000>, - <0x0 0x07805000 0x0 0x1000>; + <0x0 0x07805000 0x0 0x1000>, + <0x0 0x07808000 0x0 0x2000>; reg-names = "hc", - "cqhci"; + "cqhci", + "ice"; interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 66 IRQ_TYPE_LEVEL_HIGH>; @@ -427,11 +429,16 @@ sdhc: mmc@7804000 { clocks = <&gcc GCC_SDCC1_AHB_CLK>, <&gcc GCC_SDCC1_APPS_CLK>, - <&xo_board>; + <&xo_board>, + <&gcc GCC_SDCC1_ICE_CORE_CLK>; clock-names = "iface", "core", - "xo"; + "xo", + "ice"; non-removable; + assigned-clocks = <&gcc GCC_SDCC1_ICE_CORE_CLK>; + assigned-clock-rates = <300000000>; + supports-cqe; status = "disabled"; }; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 07/11] arm64: dts: qcom: ipq5210: Enable download mode support 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (5 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 08/11] arm64: dts: qcom: ipq5210: Enable the PWM block Varadarajan Narayanan ` (3 subsequent siblings) 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Enable the support for download mode to collect the crashdumps if system crashes, to debug crashes extensively. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index bc9502328738..9b6ebc9f59d3 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -108,6 +108,7 @@ optee { scm { compatible = "qcom,scm-ipq5210", "qcom,scm"; + qcom,dload-mode = <&tcsr 0x25100>; }; }; @@ -392,6 +393,11 @@ tcsr_mutex: hwlock@1905000 { #hwlock-cells = <1>; }; + tcsr: syscon@1937000 { + compatible = "qcom,tcsr-ipq5210", "syscon"; + reg = <0x0 0x01937000 0x0 0x2b000>; + }; + qupv3: geniqup@1ac0000 { compatible = "qcom,geni-se-qup"; reg = <0x0 0x01ac0000 0x0 0x2000>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 08/11] arm64: dts: qcom: ipq5210: Enable the PWM block 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (6 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 07/11] arm64: dts: qcom: ipq5210: Enable download mode support Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 09/11] arm64: dts: qcom: ipq5210: Add I2C nodes Varadarajan Narayanan ` (2 subsequent siblings) 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Describe and enable the PWM block on IPQ5210. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 14 ++++++++++++++ arch/arm64/boot/dts/qcom/ipq5210.dtsi | 10 ++++++++++ 2 files changed, 24 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi index 9f493561037c..eceb6e0ca6fe 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi @@ -89,6 +89,13 @@ &pcie1_port0 { reset-gpios = <&tlmm 29 GPIO_ACTIVE_LOW>; }; +&pwm { + pinctrl-0 = <&pwm_default_state>; + pinctrl-names = "default"; + + status = "okay"; +}; + &qpic_bam { status = "okay"; }; @@ -158,6 +165,13 @@ pcie0_default_state: pcie0-default-state { bias-pull-down; }; + pwm_default_state: pwm-default-state { + pins = "gpio11"; + function = "pwm0"; + drive-strength = <6>; + bias-pull-down; + }; + qpic_snand_default_state: qpic-snand-default-state { data-pins { pins = "gpio0", "gpio1", "gpio2", "gpio3"; diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 9b6ebc9f59d3..6440853da8c3 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -398,6 +398,16 @@ tcsr: syscon@1937000 { reg = <0x0 0x01937000 0x0 0x2b000>; }; + pwm: pwm@1941010 { + compatible = "qcom,ipq5210-pwm", "qcom,ipq6018-pwm"; + reg = <0x0 0x01941010 0x0 0x20>; + clocks = <&gcc GCC_ADSS_PWM_CLK>; + assigned-clocks = <&gcc GCC_ADSS_PWM_CLK>; + assigned-clock-rates = <100000000>; + #pwm-cells = <3>; + status = "disabled"; + }; + qupv3: geniqup@1ac0000 { compatible = "qcom,geni-se-qup"; reg = <0x0 0x01ac0000 0x0 0x2000>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 09/11] arm64: dts: qcom: ipq5210: Add I2C nodes 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (7 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 08/11] arm64: dts: qcom: ipq5210: Enable the PWM block Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node Varadarajan Narayanan 10 siblings, 0 replies; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add the QUPv3 I2C controller nodes for IPQ5210 and enable I2C0 with the required pin configuration on RDP504. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- .../arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 23 ++++++++++++ arch/arm64/boot/dts/qcom/ipq5210.dtsi | 42 ++++++++++++++++++++++ 2 files changed, 65 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi index eceb6e0ca6fe..40926d1598e0 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi @@ -59,6 +59,13 @@ vreg_misc_0p925: regulator-usb-0p925 { }; }; +&i2c0 { + pinctrl-0 = <&qup_i2c0_default>; + pinctrl-names = "default"; + + status = "okay"; +}; + &pcie0 { pinctrl-0 = <&pcie0_default_state>; pinctrl-names = "default"; @@ -195,6 +202,22 @@ clock-pins { }; }; + qup_i2c0_default: qup-i2c0-default-state { + qup-i2c0-scl-pins { + pins = "gpio20"; + function = "qup_se2"; + drive-strength = <6>; + bias-pull-up; + }; + + qup-i2c0-sda-pins { + pins = "gpio21"; + function = "qup_se2"; + drive-strength = <6>; + bias-pull-up; + }; + }; + qup_uart1_default_state: qup-uart1-default-state { pins = "gpio38", "gpio39"; function = "qup_se1"; diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 6440853da8c3..50ce79219fe2 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -427,6 +427,48 @@ uart1: serial@1a84000 { status = "disabled"; }; + + i2c0: i2c@1a88000 { + compatible = "qcom,geni-i2c"; + reg = <0x0 0x01a88000 0x0 0x4000>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&gcc GCC_QUPV3_WRAP_SE2_CLK>; + clock-names = "se"; + clock-frequency = <400000>; + interrupts = <GIC_SPI 140 IRQ_TYPE_LEVEL_HIGH>; + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE2_CLK>; + assigned-clock-rates = <32000000>; + status = "disabled"; + }; + + i2c1: i2c@1a8c000 { + compatible = "qcom,geni-i2c"; + reg = <0x0 0x01a8c000 0x0 0x4000>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&gcc GCC_QUPV3_WRAP_SE3_CLK>; + clock-names = "se"; + clock-frequency = <400000>; + interrupts = <GIC_SPI 141 IRQ_TYPE_LEVEL_HIGH>; + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE3_CLK>; + assigned-clock-rates = <32000000>; + status = "disabled"; + }; + + i2c2: i2c@1a94000 { + compatible = "qcom,geni-i2c"; + reg = <0x0 0x01a94000 0x0 0x4000>; + #address-cells = <1>; + #size-cells = <0>; + clocks = <&gcc GCC_QUPV3_WRAP_SE5_CLK>; + clock-names = "se"; + clock-frequency = <400000>; + interrupts = <GIC_SPI 143 IRQ_TYPE_LEVEL_HIGH>; + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE5_CLK>; + assigned-clock-rates = <32000000>; + status = "disabled"; + }; }; sdhc: mmc@7804000 { -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (8 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 09/11] arm64: dts: qcom: ipq5210: Add I2C nodes Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:18 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node Varadarajan Narayanan 10 siblings, 1 reply; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add SPI node definition for the QUP SPI blocks present in IPQ5210. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 50ce79219fe2..23a2e27b70fa 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -418,6 +418,17 @@ qupv3: geniqup@1ac0000 { #address-cells = <2>; #size-cells = <2>; + spi0: spi@1a80000 { + compatible = "qcom,geni-spi"; + reg = <0x1a80000 0x4000>; + clocks = <&gcc GCC_QUPV3_WRAP_SE0_CLK>; + clock-names = "se"; + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE0_CLK>; + assigned-clock-rates = <50000000>; + status = "disabled"; + }; + uart1: serial@1a84000 { compatible = "qcom,geni-debug-uart"; reg = <0x0 0x01a84000 0x0 0x4000>; @@ -456,6 +467,17 @@ i2c1: i2c@1a8c000 { status = "disabled"; }; + spi1: spi@1a90000 { + compatible = "qcom,geni-spi"; + reg = <0x0 0x01a90000 0x0 0x4000>; + clocks = <&gcc GCC_QUPV3_WRAP_SE4_CLK>; + clock-names = "se"; + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>; + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE4_CLK>; + assigned-clock-rates = <50000000>; + status = "disabled"; + }; + i2c2: i2c@1a94000 { compatible = "qcom,geni-i2c"; reg = <0x0 0x01a94000 0x0 0x4000>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions 2026-10-08 9:14 ` [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions Varadarajan Narayanan @ 2026-10-08 9:18 ` sashiko-bot 0 siblings, 0 replies; 18+ messages in thread From: sashiko-bot @ 2026-10-08 9:18 UTC (permalink / raw) To: Varadarajan Narayanan; +Cc: devicetree, conor+dt, robh Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider: - [Medium] dts: incorrect reg cell count for spi0 node in ipq5210 - [Low] dts: missing #address-cells and #size-cells in ipq5210 spi nodes -- commit 98b0e1a28d55f7b85bc8666419066bba608f1097 Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> arm64: dts: qcom: ipq5210: Add SPI node definitions This commit adds SPI node definitions for the QUP SPI blocks present in the IPQ5210 SoC. It introduces spi0 and spi1 nodes with their basic configurations including compatible strings, register addresses, clocks, and interrupts. > diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > index 50ce79219fe23..23a2e27b70fa3 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > @@ -418,6 +418,17 @@ qupv3: geniqup@1ac0000 { > #address-cells = <2>; > #size-cells = <2>; > > + spi0: spi@1a80000 { > + compatible = "qcom,geni-spi"; > + reg = <0x1a80000 0x4000>; [Severity: Medium] Will this reg property cause dtc warnings and runtime probing failures? The parent node qupv3: geniqup@1ac0000 specifies #address-cells = <2>; and #size-cells = <2>;. This requires all child nodes to specify their reg properties with exactly 4 cells (2 for the 64-bit address, 2 for the 64-bit size). The newly added spi0 node only provides 2 cells, whereas the sibling spi1 node correctly uses 4 cells. [Severity: Low] Should #address-cells = <1>; and #size-cells = <0>; be added to this node? SPI controller nodes typically define these properties in the SoC .dtsi so that board files can cleanly instantiate SPI slave devices on the bus without repeating them. Without these properties, when board-level device trees attempt to attach child SPI devices, the device tree compiler will emit warnings about missing #address-cells and #size-cells properties in the parent node. > + clocks = <&gcc GCC_QUPV3_WRAP_SE0_CLK>; > + clock-names = "se"; > + interrupts = <GIC_SPI 138 IRQ_TYPE_LEVEL_HIGH>; > + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE0_CLK>; > + assigned-clock-rates = <50000000>; > + status = "disabled"; > + }; [ ... ] > + spi1: spi@1a90000 { > + compatible = "qcom,geni-spi"; > + reg = <0x0 0x01a90000 0x0 0x4000>; > + clocks = <&gcc GCC_QUPV3_WRAP_SE4_CLK>; [Severity: Low] Similar to the spi0 node above, should this node also include #address-cells = <1>; and #size-cells = <0>; to prevent dtc warnings when board files attach child devices? > + clock-names = "se"; > + interrupts = <GIC_SPI 142 IRQ_TYPE_LEVEL_HIGH>; > + assigned-clocks = <&gcc GCC_QUPV3_WRAP_SE4_CLK>; > + assigned-clock-rates = <50000000>; > + status = "disabled"; > + }; -- Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=10 ^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan ` (9 preceding siblings ...) 2026-10-08 9:14 ` [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions Varadarajan Narayanan @ 2026-10-08 9:14 ` Varadarajan Narayanan 2026-10-08 9:20 ` sashiko-bot 10 siblings, 1 reply; 18+ messages in thread From: Varadarajan Narayanan @ 2026-10-08 9:14 UTC (permalink / raw) To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Abel Vesa Cc: linux-arm-msm, devicetree, linux-kernel, Varadarajan Narayanan Add random generator node for the RNG block present in IPQ5210. Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> --- arch/arm64/boot/dts/qcom/ipq5210.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi index 23a2e27b70fa..4795de0c8baa 100644 --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi @@ -198,6 +198,13 @@ soc@0 { dma-ranges = <0 0 0 0 0x10 0>; ranges = <0 0 0 0 0x10 0>; + rng: rng@4c3000 { + compatible = "qcom,ipq5210-trng", "qcom,trng"; + reg = <0x0 0x004c3000 0x0 0x1000>; + clocks = <&gcc GCC_QRNG_AHB_CLK>; + clock-names = "core"; + }; + qusb_phy_0: phy@7b000 { compatible = "qcom,ipq5210-qusb2-phy", "qcom,ipq6018-qusb2-phy"; reg = <0x0 0x0007b000 0x0 0x180>; -- 2.34.1 ^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node 2026-10-08 9:14 ` [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node Varadarajan Narayanan @ 2026-10-08 9:20 ` sashiko-bot 0 siblings, 0 replies; 18+ messages in thread From: sashiko-bot @ 2026-10-08 9:20 UTC (permalink / raw) To: Varadarajan Narayanan; +Cc: devicetree, conor+dt, robh Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: - [Low] dts: child node inserted out of unit-address order -- commit 2020cb31990e9e26b7fe5e1e8919a503b1184e3a Author: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com> arm64: dts: qcom: ipq5210: Add random number generator node Add random generator node for the RNG block present in IPQ5210. > diff --git a/arch/arm64/boot/dts/qcom/ipq5210.dtsi b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > index 23a2e27b70fa3..4795de0c8baaf 100644 > --- a/arch/arm64/boot/dts/qcom/ipq5210.dtsi > +++ b/arch/arm64/boot/dts/qcom/ipq5210.dtsi > @@ -198,6 +198,13 @@ soc@0 { > dma-ranges = <0 0 0 0 0x10 0>; > ranges = <0 0 0 0 0x10 0>; > > + rng: rng@4c3000 { > + compatible = "qcom,ipq5210-trng", "qcom,trng"; > + reg = <0x0 0x004c3000 0x0 0x1000>; > + clocks = <&gcc GCC_QRNG_AHB_CLK>; > + clock-names = "core"; > + }; > + > qusb_phy_0: phy@7b000 { [Severity: Low] This isn't a bug, but does the placement of rng@4c3000 violate the Device Tree convention for node ordering? Standard DT convention requires child nodes under a common bus to be sorted in ascending numerical order of their unit-address. Since 0x4c3000 is greater than 0x7b000, should the rng@4c3000 node be positioned lower in the soc@0 node list? > compatible = "qcom,ipq5210-qusb2-phy", "qcom,ipq6018-qusb2-phy"; > reg = <0x0 0x0007b000 0x0 0x180>; -- Sashiko AI review · https://sashiko.dev/#/patchset/20261008-08-dts-v6-0-f9c4ec8664d8@oss.qualcomm.com?part=11 ^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2026-10-08 10:48 UTC | newest] Thread overview: 18+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-10-08 9:14 [PATCH v6 00/11] Enable mutliple peripherals in IPQ5210 Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 01/11] arm64: dts: qcom: ipq5210: Add nodes for multiple peripherals Varadarajan Narayanan 2026-10-08 9:31 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 02/11] arm64: dts: qcom: ipq5210: Introduce RDP504 common DT file Varadarajan Narayanan 2026-10-08 9:21 ` sashiko-bot 2026-10-08 10:48 ` Dmitry Baryshkov 2026-10-08 9:14 ` [PATCH v6 03/11] arm64: dts: qcom: ipq5210: Introduce RDP504 NAND variant " Varadarajan Narayanan 2026-10-08 9:26 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 04/11] arm64: dts: qcom: ipq5210: Add support for WPS button Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 05/11] arm64: dts: qcom: ipq5210: Add C3 CPU idle state Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 06/11] arm64: dts: qcom: ipq5210: Add ICE support to SDHCI Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 07/11] arm64: dts: qcom: ipq5210: Enable download mode support Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 08/11] arm64: dts: qcom: ipq5210: Enable the PWM block Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 09/11] arm64: dts: qcom: ipq5210: Add I2C nodes Varadarajan Narayanan 2026-10-08 9:14 ` [PATCH v6 10/11] arm64: dts: qcom: ipq5210: Add SPI node definitions Varadarajan Narayanan 2026-10-08 9:18 ` sashiko-bot 2026-10-08 9:14 ` [PATCH v6 11/11] arm64: dts: qcom: ipq5210: Add random number generator node Varadarajan Narayanan 2026-10-08 9:20 ` sashiko-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox