* [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
` (9 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno,
Krzysztof Kozlowski
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Nord relocates several PHY/QSERDES registers relative to existing
SoCs, so it cannot reuse an existing compatible. Add qcom,nord-dp-phy
to the compatible list. Nord also needs a dedicated ref clock besides
aux and cfg_ahb, so add it to the allOf condition that requires
three clocks (aux, cfg_ahb, ref).
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
index 0bf8bf4f66ac..0ff07ddcb76f 100644
--- a/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
+++ b/Documentation/devicetree/bindings/phy/qcom,edp-phy.yaml
@@ -19,6 +19,7 @@ properties:
oneOf:
- enum:
- qcom,glymur-dp-phy
+ - qcom,nord-dp-phy
- qcom,sa8775p-edp-phy
- qcom,sc7280-edp-phy
- qcom,sc8180x-edp-phy
@@ -74,6 +75,7 @@ allOf:
compatible:
enum:
- qcom,glymur-dp-phy
+ - qcom,nord-dp-phy
- qcom,sa8775p-edp-phy
- qcom,x1e80100-dp-phy
then:
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:31 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
` (8 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Nord's DP controller is compatible with SA8775P in terms of register
layout and clocks. Add qcom,nord-dp to the sa8775p-dp fallback group.
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
Documentation/devicetree/bindings/display/msm/dp-controller.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
index 094a6383bb77..9be0288261e7 100644
--- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
@@ -35,6 +35,7 @@ properties:
- items:
- enum:
- qcom,qcs8300-dp
+ - qcom,nord-dp
- const: qcom,sa8775p-dp
- items:
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
@ 2026-11-16 13:31 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:31 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] dt-bindings: display: msm: dp-controller: qcom,nord-dp not in
alphabetical order
--
commit 0ec7842c5ba3651d6f0a3de03165ad9984fb8e75
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller
This commit adds the qcom,nord-dp compatible string to the qcom,sa8775p-dp
fallback group in the MSM DisplayPort controller binding.
> diff --git a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> index 094a6383bb779..9be0288261e72 100644
> --- a/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> +++ b/Documentation/devicetree/bindings/display/msm/dp-controller.yaml
> @@ -35,6 +35,7 @@ properties:
> - items:
> - enum:
> - qcom,qcs8300-dp
> + - qcom,nord-dp
> - const: qcom,sa8775p-dp
[Severity: Low]
This isn't a bug, but qcom,nord-dp should be placed before qcom,qcs8300-dp
to keep the compatible enum list sorted alphabetically like the rest of
the binding.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=2
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
2026-11-16 13:16 ` [PATCH v3 01/11] dt-bindings: phy: qcom,edp-phy: Add DP PHY compatible for Nord Nabige Aala
2026-11-16 13:16 ` [PATCH v3 02/11] dt-bindings: display: msm: dp-controller: Document Nord DisplayPort Controller Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:38 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
` (7 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Nord has a new MDSS 12.1 revision with DPU 1499A and two independent,
DP-only display interface controllers (no DSI), which no existing
schema describes. Add a dedicated qcom,nord-mdss binding to document.
Assisted-by: LLM
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
.../bindings/display/msm/qcom,nord-mdss.yaml | 396 +++++++++++++++++++++
1 file changed, 396 insertions(+)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
new file mode 100644
index 000000000000..abd80dae4e7f
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
@@ -0,0 +1,396 @@
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/msm/qcom,nord-mdss.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Qualcomm Nord display subsystem (MDSS)
+
+maintainers:
+ - Mahadevan P <mahadevan.p@oss.qualcomm.com>
+
+description:
+ Nord display subsystem consists of MDSS (display controller), DPU 1499A
+ (display processing unit), and display interface controllers (DP only, no DSI).
+ This is MDSS 12.1, DP-only, with 2 independent DP controllers.
+
+$ref: /schemas/display/msm/mdss-common.yaml#
+
+properties:
+ compatible:
+ const: qcom,nord-mdss
+
+ clocks:
+ items:
+ - description: Display AHB
+ - description: Display hf AXI
+ - description: Display core
+
+ clock-names:
+ items:
+ - const: iface
+ - const: bus
+ - const: core
+
+ iommus:
+ maxItems: 1
+
+ interconnects:
+ items:
+ - description: Interconnect path from mdp0 port to the data bus
+ - description: Interconnect path from CPU to the reg bus
+
+ interconnect-names:
+ items:
+ - const: mdp0-mem
+ - const: cpu-cfg
+
+patternProperties:
+ "^display-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ const: qcom,nord-dpu
+
+ "^displayport-controller@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ const: qcom,nord-dp
+
+ "^phy@[0-9a-f]+$":
+ type: object
+ additionalProperties: true
+ properties:
+ compatible:
+ const: qcom,nord-dp-phy
+
+required:
+ - compatible
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/clock/qcom,nord-dispcc.h>
+ #include <dt-bindings/clock/qcom,nord-nwgcc.h>
+ #include <dt-bindings/clock/qcom,nord-tcsrcc.h>
+ #include <dt-bindings/interconnect/qcom,icc.h>
+ #include <dt-bindings/interconnect/qcom,nord-rpmh.h>
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+ #include <dt-bindings/power/qcom,rpmhpd.h>
+
+ display-subsystem@ae00000 {
+ compatible = "qcom,nord-mdss";
+ reg = <0x0ae00000 0x1000>;
+ reg-names = "mdss";
+
+ power-domains = <&dispcc0 MDSS_DISP_CC_MDSS_CORE_GDSC>;
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&nwgcc NW_GCC_DISP_0_HF_AXI_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>;
+ clock-names = "iface", "bus", "core";
+ resets = <&dispcc0 MDSS_DISP_CC_MDSS_CORE_BCR>;
+
+ interconnects = <&mmss_noc MASTER_MDP0 QCOM_ICC_TAG_ALWAYS
+ &mc_virt SLAVE_EBI1 QCOM_ICC_TAG_ALWAYS>,
+ <&hscnoc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY
+ &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>;
+ interconnect-names = "mdp0-mem", "cpu-cfg";
+
+ interrupts = <GIC_SPI 930 IRQ_TYPE_LEVEL_HIGH>;
+ interrupt-controller;
+ #interrupt-cells = <1>;
+
+ iommus = <&apps_smmu_1 0x3e0 0x2>;
+ #address-cells = <1>;
+ #size-cells = <1>;
+ ranges;
+
+ display-controller@ae01000 {
+ compatible = "qcom,nord-dpu";
+ reg = <0x0ae01000 0x8f000>,
+ <0x0aeb0000 0x3000>;
+ reg-names = "mdp", "vbif";
+
+ clocks = <&nwgcc NW_GCC_DISP_0_HF_AXI_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_LUT_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_MDP_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ clock-names = "nrt_bus", "iface", "lut", "core", "vsync";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_VSYNC_CLK>;
+ assigned-clock-rates = <19200000>;
+
+ operating-points-v2 = <&mdp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ dpu_intf0_out: endpoint {
+ remote-endpoint = <&mdss_dp0_in>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ dpu_intf4_out: endpoint {
+ remote-endpoint = <&mdss_dp1_in>;
+ };
+ };
+ };
+
+ mdp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-300000000 {
+ opp-hz = /bits/ 64 <300000000>;
+ required-opps = <&rpmhpd_opp_svs>;
+ };
+
+ opp-417000000 {
+ opp-hz = /bits/ 64 <417000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-532000000 {
+ opp-hz = /bits/ 64 <532000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+
+ opp-650000000 {
+ opp-hz = /bits/ 64 <650000000>;
+ required-opps = <&rpmhpd_opp_turbo>;
+ };
+
+ opp-710000000 {
+ opp-hz = /bits/ 64 <710000000>;
+ required-opps = <&rpmhpd_opp_turbo_l1>;
+ };
+ };
+ };
+
+ displayport-controller@af54000 {
+ compatible = "qcom,nord-dp";
+
+ reg = <0xaf54000 0x200>,
+ <0xaf54200 0x200>,
+ <0xaf55000 0xc00>,
+ <0xaf56000 0x400>,
+ <0xaf57000 0x400>,
+ <0xaf58000 0x400>,
+ <0xaf59000 0x400>,
+ <0xaf5a000 0x600>,
+ <0xaf5b000 0x600>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK>;
+ clock-names = "core_iface", "core_aux",
+ "ctrl_link", "ctrl_link_iface",
+ "stream_pixel", "stream_1_pixel",
+ "stream_2_pixel", "stream_3_pixel";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL0_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL1_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL2_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_PIXEL3_CLK_SRC>;
+ assigned-clock-parents = <&dp0_phy 0>,
+ <&dp0_phy 1>,
+ <&dp0_phy 1>,
+ <&dp0_phy 1>,
+ <&dp0_phy 1>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <12>;
+
+ phys = <&dp0_phy>;
+ phy-names = "dp";
+
+ operating-points-v2 = <&dp_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ mdss_dp0_in: endpoint {
+ remote-endpoint = <&dpu_intf0_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ mdss_dp0_out: endpoint { };
+ };
+ };
+
+ dp_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-162000000 {
+ opp-hz = /bits/ 64 <162000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
+ displayport-controller@af5c000 {
+ compatible = "qcom,nord-dp";
+
+ reg = <0xaf5c000 0x200>,
+ <0xaf5c200 0x200>,
+ <0xaf5d000 0xc00>,
+ <0xaf5e000 0x400>,
+ <0xaf5f000 0x400>,
+ <0xaf60000 0x400>,
+ <0xaf61000 0x400>,
+ <0xaf62000 0x600>,
+ <0xaf63000 0x600>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_INTF_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK>;
+ clock-names = "core_iface", "core_aux",
+ "ctrl_link", "ctrl_link_iface",
+ "stream_pixel", "stream_1_pixel",
+ "stream_2_pixel", "stream_3_pixel";
+
+ assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK_SRC>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK_SRC>;
+ assigned-clock-parents = <&dp1_phy 0>,
+ <&dp1_phy 1>,
+ <&dp1_phy 1>;
+
+ interrupt-parent = <&mdss>;
+ interrupts = <13>;
+
+ phys = <&dp1_phy>;
+ phy-names = "dp";
+
+ operating-points-v2 = <&dp1_opp_table>;
+ power-domains = <&rpmhpd RPMHPD_MMCX>;
+
+ #sound-dai-cells = <0>;
+
+ ports {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ port@0 {
+ reg = <0>;
+ mdss_dp1_in: endpoint {
+ remote-endpoint = <&dpu_intf4_out>;
+ };
+ };
+
+ port@1 {
+ reg = <1>;
+ mdss_dp1_out: endpoint { };
+ };
+ };
+
+ dp1_opp_table: opp-table {
+ compatible = "operating-points-v2";
+
+ opp-162000000 {
+ opp-hz = /bits/ 64 <162000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-270000000 {
+ opp-hz = /bits/ 64 <270000000>;
+ required-opps = <&rpmhpd_opp_low_svs>;
+ };
+
+ opp-540000000 {
+ opp-hz = /bits/ 64 <540000000>;
+ required-opps = <&rpmhpd_opp_svs_l1>;
+ };
+
+ opp-810000000 {
+ opp-hz = /bits/ 64 <810000000>;
+ required-opps = <&rpmhpd_opp_nom>;
+ };
+ };
+ };
+
+ dp0_phy: phy@fc3a00 {
+ compatible = "qcom,nord-dp-phy";
+
+ reg = <0xfc3a00 0x1d0>,
+ <0xfc3200 0x128>,
+ <0xfc3600 0x128>,
+ <0xfc3000 0x200>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX0_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&tcsrcc TCSR_DP_TX_0_CLKREF_EN>;
+ clock-names = "aux", "cfg_ahb", "ref";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ power-domains = <&rpmhpd RPMHPD_MX>;
+ };
+
+ dp1_phy: phy@fc6a00 {
+ compatible = "qcom,nord-dp-phy";
+
+ reg = <0xfc6a00 0x200>,
+ <0xfc6200 0xd0>,
+ <0xfc6600 0xd0>,
+ <0xfc6000 0x1c8>;
+
+ clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
+ <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
+ <&tcsrcc TCSR_DP_TX_1_CLKREF_EN>;
+ clock-names = "aux", "cfg_ahb", "ref";
+
+ #clock-cells = <1>;
+ #phy-cells = <0>;
+
+ power-domains = <&rpmhpd RPMHPD_MX>;
+ };
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
@ 2026-11-16 13:38 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:38 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Medium] dt-bindings: display/msm: qcom,nord-mdss omits
qcom,sa8775p-dp fallback
- [Low] dt-bindings: display/msm: inconsistent DP1 clocks and PHY reg
sizes in example
--
commit 7e933ce5ebfd089e4cac22428484f5b572292bc8
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
dt-bindings: display/msm: Document Nord MDSS
This commit adds the devicetree binding schema for the Qualcomm Nord
display subsystem (MDSS 12.1).
> diff --git a/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
> new file mode 100644
> index 0000000000000..abd80dae4e7f5
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/msm/qcom,nord-mdss.yaml
[ ... ]
> + "^displayport-controller@[0-9a-f]+$":
> + type: object
> + additionalProperties: true
> + properties:
> + compatible:
> + const: qcom,nord-dp
[Severity: Medium]
Should the compatible constraint here allow the "qcom,sa8775p-dp" fallback,
and should both displayport-controller nodes in the example below include
it?
Documentation/devicetree/bindings/display/msm/dp-controller.yaml requires
"qcom,nord-dp" to be followed by "qcom,sa8775p-dp":
Documentation/devicetree/bindings/display/msm/dp-controller.yaml
- items:
- enum:
- qcom,qcs8300-dp
- qcom,nord-dp
- const: qcom,sa8775p-dp
Using "const: qcom,nord-dp" here rejects the required fallback, and
omitting "qcom,sa8775p-dp" from displayport-controller@af54000 and
displayport-controller@af5c000 in the example causes dt_binding_check to
fail against dp-controller.yaml. Using "contains: const: qcom,nord-dp"
(as in qcom,qcs8300-mdss.yaml) and adding "qcom,sa8775p-dp" to the example
nodes would resolve this.
[ ... ]
> + displayport-controller@af5c000 {
> + compatible = "qcom,nord-dp";
> +
> + reg = <0xaf5c000 0x200>,
> + <0xaf5c200 0x200>,
> + <0xaf5d000 0xc00>,
> + <0xaf5e000 0x400>,
> + <0xaf5f000 0x400>,
> + <0xaf60000 0x400>,
> + <0xaf61000 0x400>,
> + <0xaf62000 0x600>,
> + <0xaf63000 0x600>;
> +
> + clocks = <&dispcc0 MDSS_DISP_CC_MDSS_AHB_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_AUX_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_INTF_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK>;
> + clock-names = "core_iface", "core_aux",
> + "ctrl_link", "ctrl_link_iface",
> + "stream_pixel", "stream_1_pixel",
> + "stream_2_pixel", "stream_3_pixel";
> +
> + assigned-clocks = <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_LINK_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL0_CLK_SRC>,
> + <&dispcc0 MDSS_DISP_CC_MDSS_DPTX1_PIXEL1_CLK_SRC>;
> + assigned-clock-parents = <&dp1_phy 0>,
> + <&dp1_phy 1>,
> + <&dp1_phy 1>;
[ ... ]
> + dp1_phy: phy@fc6a00 {
> + compatible = "qcom,nord-dp-phy";
> +
> + reg = <0xfc6a00 0x200>,
> + <0xfc6200 0xd0>,
> + <0xfc6600 0xd0>,
> + <0xfc6000 0x1c8>;
[Severity: Low]
Are the assigned-clocks on displayport-controller@af5c000 and the reg sizes
on dp1_phy in the example intended to differ from the first DP instance?
displayport-controller@af5c000 requests all four stream pixel clocks in
clocks, but assigned-clocks omits MDSS_DISP_CC_MDSS_DPTX1_PIXEL2_CLK_SRC
and MDSS_DISP_CC_MDSS_DPTX1_PIXEL3_CLK_SRC (which are present on
displayport-controller@af54000). In addition, dp1_phy uses SA8775P
register sizes (0x200, 0xd0, 0xd0, 0x1c8) instead of the qcom,nord-dp-phy
sizes used by dp0_phy (0x1d0, 0x128, 0x128, 0x200), leaving the fourth
region smaller than NORD_DP_QSERDES_COM_C_READY_STATUS at offset 0x1f8.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=3
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (2 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 03/11] dt-bindings: display/msm: Document Nord MDSS Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
` (6 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
Add DPU (v12.1) for Qualcomm Nord SoC which has noticeable
differences against SM8750 (v12.0):
- Added DSPP blocks
- Added INTF6-INTF10 and removed INTF1,INTF2 and INF5
- Added one more DP
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
index aa0cf0ec5b93..430fa02d18a7 100644
--- a/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
+++ b/Documentation/devicetree/bindings/display/msm/qcom,sm8650-dpu.yaml
@@ -19,6 +19,7 @@ properties:
- qcom,glymur-dpu
- qcom,kaanapali-dpu
- qcom,milos-dpu
+ - qcom,nord-dpu
- qcom,sa8775p-dpu
- qcom,sm8650-dpu
- qcom,sm8750-dpu
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (3 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 04/11] dt-bindings: display/msm: qcom,sm8650-dpu: Add Qualcomm Nord Soc Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:47 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
` (5 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Add the DPU catalog entry for the Qualcomm Nord SoC (MDSS 12.1, DPU
1499A). Nord is DP-only with no DSI, and provides 8 DSPP blocks, 2
writeback blocks, 8 interfaces and 2 DP controllers.
Assisted-by: LLM
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
.../gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h | 544 +++++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 1 +
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 1 +
drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c | 1 +
4 files changed, 547 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
new file mode 100644
index 000000000000..333eccb5c603
--- /dev/null
+++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
@@ -0,0 +1,544 @@
+/* SPDX-License-Identifier: GPL-2.0-only */
+/*
+ * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#ifndef _DPU_12_1_NORD_H
+#define _DPU_12_1_NORD_H
+
+
+static const struct dpu_caps nord_dpu_caps = {
+ .max_mixer_width = DEFAULT_DPU_OUTPUT_LINE_WIDTH,
+ .max_mixer_blendstages = 0xb,
+ .has_src_split = true,
+ .has_dim_layer = true,
+ .has_idle_pc = true,
+ .has_3d_merge = true,
+ .max_linewidth = 8192,
+ .pixel_ram_size = DEFAULT_PIXEL_RAM_SIZE,
+};
+
+static const struct dpu_mdp_cfg nord_mdp = {
+ .name = "top_0",
+ .base = 0, .len = 0x494,
+ .clk_ctrls = {
+ [DPU_CLK_CTRL_REG_DMA] = { .reg_off = 0x2bc, .bit_off = 20 },
+ },
+};
+
+static const struct dpu_ctl_cfg nord_ctl[] = {
+ {
+ .name = "ctl_0", .id = CTL_0,
+ .base = 0x15000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 9),
+ }, {
+ .name = "ctl_1", .id = CTL_1,
+ .base = 0x16000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 10),
+ }, {
+ .name = "ctl_2", .id = CTL_2,
+ .base = 0x17000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 11),
+ }, {
+ .name = "ctl_3", .id = CTL_3,
+ .base = 0x18000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 12),
+ }, {
+ .name = "ctl_4", .id = CTL_4,
+ .base = 0x19000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 13),
+ }, {
+ .name = "ctl_5", .id = CTL_5,
+ .base = 0x1a000, .len = 0x1000,
+ .intr_start = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 23),
+ },
+};
+
+static const struct dpu_sspp_cfg nord_sspp[] = {
+ {
+ .name = "sspp_0", .id = SSPP_VIG0,
+ .base = 0x4000, .len = 0x344,
+ .features = VIG_SDM845_MASK_SDMA,
+ .sblk = &dpu_vig_sblk_qseed3_3_4,
+ .xin_id = 0,
+ .type = SSPP_TYPE_VIG,
+ }, {
+ .name = "sspp_1", .id = SSPP_VIG1,
+ .base = 0x6000, .len = 0x344,
+ .features = VIG_SDM845_MASK_SDMA,
+ .sblk = &dpu_vig_sblk_qseed3_3_4,
+ .xin_id = 4,
+ .type = SSPP_TYPE_VIG,
+ }, {
+ .name = "sspp_2", .id = SSPP_VIG2,
+ .base = 0x8000, .len = 0x344,
+ .features = VIG_SDM845_MASK_SDMA,
+ .sblk = &dpu_vig_sblk_qseed3_3_4,
+ .xin_id = 8,
+ .type = SSPP_TYPE_VIG,
+ }, {
+ .name = "sspp_3", .id = SSPP_VIG3,
+ .base = 0xa000, .len = 0x344,
+ .features = VIG_SDM845_MASK_SDMA,
+ .sblk = &dpu_vig_sblk_qseed3_3_4,
+ .xin_id = 12,
+ .type = SSPP_TYPE_VIG,
+ }, {
+ .name = "sspp_8", .id = SSPP_DMA0,
+ .base = 0x24000, .len = 0x344,
+ .features = DMA_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 1,
+ .type = SSPP_TYPE_DMA,
+ }, {
+ .name = "sspp_9", .id = SSPP_DMA1,
+ .base = 0x26000, .len = 0x344,
+ .features = DMA_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 5,
+ .type = SSPP_TYPE_DMA,
+ }, {
+ .name = "sspp_10", .id = SSPP_DMA2,
+ .base = 0x28000, .len = 0x344,
+ .features = DMA_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 9,
+ .type = SSPP_TYPE_DMA,
+ }, {
+ .name = "sspp_11", .id = SSPP_DMA3,
+ .base = 0x2a000, .len = 0x344,
+ .features = DMA_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 13,
+ .type = SSPP_TYPE_DMA,
+ }, {
+ .name = "sspp_12", .id = SSPP_DMA4,
+ .base = 0x2c000, .len = 0x344,
+ .features = DMA_CURSOR_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 14,
+ .type = SSPP_TYPE_DMA,
+ }, {
+ .name = "sspp_13", .id = SSPP_DMA5,
+ .base = 0x2e000, .len = 0x344,
+ .features = DMA_CURSOR_SDM845_MASK_SDMA,
+ .sblk = &dpu_dma_sblk,
+ .xin_id = 15,
+ .type = SSPP_TYPE_DMA,
+ },
+};
+
+static const struct dpu_lm_cfg nord_lm[] = {
+ {
+ .name = "lm_0", .id = LM_0,
+ .base = 0x44000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_1,
+ .pingpong = PINGPONG_0,
+ .dspp = DSPP_0,
+ }, {
+ .name = "lm_1", .id = LM_1,
+ .base = 0x45000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_0,
+ .pingpong = PINGPONG_1,
+ .dspp = DSPP_1,
+ }, {
+ .name = "lm_2", .id = LM_2,
+ .base = 0x46000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_3,
+ .pingpong = PINGPONG_2,
+ .dspp = DSPP_2,
+ }, {
+ .name = "lm_3", .id = LM_3,
+ .base = 0x47000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_2,
+ .pingpong = PINGPONG_3,
+ .dspp = DSPP_3,
+ }, {
+ .name = "lm_4", .id = LM_4,
+ .base = 0x48000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_5,
+ .pingpong = PINGPONG_4,
+ .dspp = DSPP_4,
+ }, {
+ .name = "lm_5", .id = LM_5,
+ .base = 0x49000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_4,
+ .pingpong = PINGPONG_5,
+ .dspp = DSPP_5,
+ }, {
+ .name = "lm_6", .id = LM_6,
+ .base = 0x4a000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_7,
+ .pingpong = PINGPONG_6,
+ .dspp = DSPP_6,
+ }, {
+ .name = "lm_7", .id = LM_7,
+ .base = 0x4b000, .len = 0x400,
+ .features = MIXER_MSM8998_MASK,
+ .sblk = &sm8750_lm_sblk,
+ .lm_pair = LM_6,
+ .pingpong = PINGPONG_7,
+ .dspp = DSPP_7,
+ },
+};
+
+static const struct dpu_dspp_cfg nord_dspp[] = {
+ {
+ .name = "dspp_0", .id = DSPP_0,
+ .base = 0x54000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_1", .id = DSPP_1,
+ .base = 0x56000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_2", .id = DSPP_2,
+ .base = 0x58000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_3", .id = DSPP_3,
+ .base = 0x5a000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_4", .id = DSPP_4,
+ .base = 0x5c000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_5", .id = DSPP_5,
+ .base = 0x5e000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_6", .id = DSPP_6,
+ .base = 0x60000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ }, {
+ .name = "dspp_7", .id = DSPP_7,
+ .base = 0x62000, .len = 0x1800,
+ .sblk = &sm8750_dspp_sblk,
+ },
+};
+
+static const struct dpu_pingpong_cfg nord_pp[] = {
+ {
+ .name = "pingpong_0", .id = PINGPONG_0,
+ .base = 0x69000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_0,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 8),
+ }, {
+ .name = "pingpong_1", .id = PINGPONG_1,
+ .base = 0x6a000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_0,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 9),
+ }, {
+ .name = "pingpong_2", .id = PINGPONG_2,
+ .base = 0x6b000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_1,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 10),
+ }, {
+ .name = "pingpong_3", .id = PINGPONG_3,
+ .base = 0x6c000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_1,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 11),
+ }, {
+ .name = "pingpong_4", .id = PINGPONG_4,
+ .base = 0x6d000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_2,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 30),
+ }, {
+ .name = "pingpong_5", .id = PINGPONG_5,
+ .base = 0x6e000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_2,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 31),
+ }, {
+ .name = "pingpong_6", .id = PINGPONG_6,
+ .base = 0x6f000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_3,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 20),
+ }, {
+ .name = "pingpong_7", .id = PINGPONG_7,
+ .base = 0x70000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_3,
+ .intr_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 21),
+ }, {
+ .name = "pingpong_cwb_0", .id = PINGPONG_CWB_0,
+ .base = 0x66000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_4,
+ }, {
+ .name = "pingpong_cwb_1", .id = PINGPONG_CWB_1,
+ .base = 0x66400, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_4,
+ }, {
+ .name = "pingpong_cwb_2", .id = PINGPONG_CWB_2,
+ .base = 0x7e000, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_5,
+ }, {
+ .name = "pingpong_cwb_3", .id = PINGPONG_CWB_3,
+ .base = 0x7e400, .len = 0,
+ .sblk = &sc7280_pp_sblk,
+ .merge_3d = MERGE_3D_5,
+ },
+};
+
+static const struct dpu_merge_3d_cfg nord_merge_3d[] = {
+ {
+ .name = "merge_3d_0", .id = MERGE_3D_0,
+ .base = 0x4e000, .len = 0x1c,
+ }, {
+ .name = "merge_3d_1", .id = MERGE_3D_1,
+ .base = 0x4f000, .len = 0x1c,
+ }, {
+ .name = "merge_3d_2", .id = MERGE_3D_2,
+ .base = 0x50000, .len = 0x1c,
+ }, {
+ .name = "merge_3d_3", .id = MERGE_3D_3,
+ .base = 0x51000, .len = 0x1c,
+ }, {
+ .name = "merge_3d_4", .id = MERGE_3D_4,
+ .base = 0x66700, .len = 0x1c,
+ }, {
+ .name = "merge_3d_5", .id = MERGE_3D_5,
+ .base = 0x7e700, .len = 0x1c,
+ },
+};
+
+static const struct dpu_dsc_cfg nord_dsc[] = {
+ {
+ .name = "dce_0_0", .id = DSC_0,
+ .base = 0x80000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_0,
+ }, {
+ .name = "dce_0_1", .id = DSC_1,
+ .base = 0x80000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_1,
+ }, {
+ .name = "dce_1_0", .id = DSC_2,
+ .base = 0x81000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_0,
+ }, {
+ .name = "dce_1_1", .id = DSC_3,
+ .base = 0x81000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_1,
+ }, {
+ .name = "dce_2_0", .id = DSC_4,
+ .base = 0x82000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_0,
+ }, {
+ .name = "dce_2_1", .id = DSC_5,
+ .base = 0x82000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_1,
+ }, {
+ .name = "dce_3_0", .id = DSC_6,
+ .base = 0x83000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_0,
+ }, {
+ .name = "dce_3_1", .id = DSC_7,
+ .base = 0x83000, .len = 0x8,
+ .features = BIT(DPU_DSC_NATIVE_42x_EN),
+ .sblk = &sm8750_dsc_sblk_1,
+ },
+};
+
+static const struct dpu_wb_cfg nord_wb[] = {
+ {
+ .name = "wb_1", .id = WB_1,
+ .base = 0x64800, .len = 0x2c8,
+ .features = WB_SDM845_MASK,
+ .format_list = wb2_formats_rgb_yuv,
+ .num_formats = ARRAY_SIZE(wb2_formats_rgb_yuv),
+ .xin_id = 7,
+ .maxlinewidth = 4096,
+ .intr_wb_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 3),
+ }, {
+ .name = "wb_2", .id = WB_2,
+ .base = 0x65000, .len = 0x2c8,
+ .features = WB_SDM845_MASK,
+ .format_list = wb2_formats_rgb_yuv,
+ .num_formats = ARRAY_SIZE(wb2_formats_rgb_yuv),
+ .xin_id = 6,
+ .maxlinewidth = 4096,
+ .intr_wb_done = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 4),
+ },
+};
+
+static const struct dpu_cwb_cfg nord_cwb[] = {
+ {
+ .name = "cwb_0", .id = CWB_0,
+ .base = 0x66200, .len = 0x20,
+ },
+ {
+ .name = "cwb_1", .id = CWB_1,
+ .base = 0x66600, .len = 0x20,
+ },
+ {
+ .name = "cwb_2", .id = CWB_2,
+ .base = 0x7e200, .len = 0x20,
+ },
+ {
+ .name = "cwb_3", .id = CWB_3,
+ .base = 0x7e600, .len = 0x20,
+ },
+};
+
+static const struct dpu_intf_cfg nord_intf[] = {
+ {
+ .name = "intf_0", .id = INTF_0,
+ .base = 0x34000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_0,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 24),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 25),
+ }, {
+ .name = "intf_3", .id = INTF_3,
+ .base = 0x37000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_0,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
+ }, {
+ .name = "intf_4", .id = INTF_4,
+ .base = 0x38000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_1,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21),
+ }, {
+ .name = "intf_6", .id = INTF_6,
+ .base = 0x3a000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_0,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23),
+ }, {
+ .name = "intf_7", .id = INTF_7,
+ .base = 0x3b000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_0,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 0),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 1),
+ }, {
+ .name = "intf_8", .id = INTF_8,
+ .base = 0x3c000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_1,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 2),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 3),
+ }, {
+ .name = "intf_9", .id = INTF_9,
+ .base = 0x3d000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_1,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 4),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 5),
+ }, {
+ .name = "intf_10", .id = INTF_10,
+ .base = 0x3e000, .len = 0x4bc,
+ .type = INTF_DP,
+ .controller_id = MSM_DP_CONTROLLER_1,
+ .prog_fetch_lines_worst_case = 24,
+ .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 6),
+ .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 7),
+ },
+};
+
+static const struct dpu_perf_cfg nord_perf_data = {
+ .max_bw_low = 18900000,
+ .max_bw_high = 28500000,
+ .min_core_ib = 2500000,
+ .min_llcc_ib = 0,
+ .min_dram_ib = 800000,
+ .min_prefill_lines = 35,
+ .danger_lut_tbl = {0x3ffff, 0x3ffff, 0x0},
+ .safe_lut_tbl = {0xfe00, 0xfe00, 0xffff},
+ .qos_lut_tbl = {
+ {.nentry = ARRAY_SIZE(sc7180_qos_linear),
+ .entries = sc7180_qos_linear
+ },
+ {.nentry = ARRAY_SIZE(sc7180_qos_macrotile),
+ .entries = sc7180_qos_macrotile
+ },
+ {.nentry = ARRAY_SIZE(sc7180_qos_nrt),
+ .entries = sc7180_qos_nrt
+ },
+ },
+ .cdp_cfg = {
+ {.rd_enable = 1, .wr_enable = 1},
+ {.rd_enable = 1, .wr_enable = 0}
+ },
+ .clk_inefficiency_factor = 105,
+ .bw_inefficiency_factor = 120,
+};
+
+static const struct dpu_mdss_version nord_mdss_ver = {
+ .core_major_ver = 12,
+ .core_minor_ver = 1,
+};
+
+const struct dpu_mdss_cfg dpu_nord_cfg = {
+ .mdss_ver = &nord_mdss_ver,
+ .caps = &nord_dpu_caps,
+ .mdp = &nord_mdp,
+ .cdm = &dpu_cdm_5_x,
+ .ctl_count = ARRAY_SIZE(nord_ctl),
+ .ctl = nord_ctl,
+ .sspp_count = ARRAY_SIZE(nord_sspp),
+ .sspp = nord_sspp,
+ .mixer_count = ARRAY_SIZE(nord_lm),
+ .mixer = nord_lm,
+ .dspp_count = ARRAY_SIZE(nord_dspp),
+ .dspp = nord_dspp,
+ .pingpong_count = ARRAY_SIZE(nord_pp),
+ .pingpong = nord_pp,
+ .dsc_count = ARRAY_SIZE(nord_dsc),
+ .dsc = nord_dsc,
+ .merge_3d_count = ARRAY_SIZE(nord_merge_3d),
+ .merge_3d = nord_merge_3d,
+ .wb_count = ARRAY_SIZE(nord_wb),
+ .wb = nord_wb,
+ .cwb_count = ARRAY_SIZE(nord_cwb),
+ .cwb = nord_cwb,
+ .intf_count = ARRAY_SIZE(nord_intf),
+ .intf = nord_intf,
+ .vbif = &sm8650_vbif,
+ .perf = &nord_perf_data,
+};
+
+#endif
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
index 9a993cdfab85..63f3029d09fa 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c
@@ -796,6 +796,7 @@ static const struct dpu_qos_lut_entry sc7180_qos_nrt[] = {
#include "catalog/dpu_10_2_milos.h"
#include "catalog/dpu_12_0_sm8750.h"
+#include "catalog/dpu_12_1_nord.h"
#include "catalog/dpu_12_2_glymur.h"
#include "catalog/dpu_12_4_eliza.h"
#include "catalog/dpu_13_0_kaanapali.h"
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
index f45faf87333e..bfbc8207ad9a 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h
@@ -772,6 +772,7 @@ extern const struct dpu_mdss_cfg dpu_msm8937_cfg;
extern const struct dpu_mdss_cfg dpu_msm8953_cfg;
extern const struct dpu_mdss_cfg dpu_msm8996_cfg;
extern const struct dpu_mdss_cfg dpu_msm8998_cfg;
+extern const struct dpu_mdss_cfg dpu_nord_cfg;
extern const struct dpu_mdss_cfg dpu_sar2130p_cfg;
extern const struct dpu_mdss_cfg dpu_sdm630_cfg;
extern const struct dpu_mdss_cfg dpu_sdm660_cfg;
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
index da3556eb6ecc..a91d4a1af94e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_kms.c
@@ -1489,6 +1489,7 @@ static const struct of_device_id dpu_dt_match[] = {
{ .compatible = "qcom,msm8953-mdp5", .data = &dpu_msm8953_cfg, },
{ .compatible = "qcom,msm8996-mdp5", .data = &dpu_msm8996_cfg, },
{ .compatible = "qcom,msm8998-dpu", .data = &dpu_msm8998_cfg, },
+ { .compatible = "qcom,nord-dpu", .data = &dpu_nord_cfg, },
{ .compatible = "qcom,qcm2290-dpu", .data = &dpu_qcm2290_cfg, },
{ .compatible = "qcom,sa8775p-dpu", .data = &dpu_sa8775p_cfg, },
{ .compatible = "qcom,sar2130p-dpu", .data = &dpu_sar2130p_cfg, },
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
@ 2026-11-16 13:47 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:47 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] drm/msm/dpu: undeclared INTF_9 and INTF_10 in nord_intf break
build
- [Medium] drm/msm/dpu: wrong interrupt bit assignments for
intf_6..intf_10 on Nord
--
commit 26c8821f9a7d74ed713c34eb7d82f28a0037edd5
Author: Mahadevan P <mahadevan.p@oss.qualcomm.com>
drm/msm/dpu: Add support for DPU 12.1 on Nord
This commit adds the DPU 12.1 hardware catalog configuration and device tree
match entry for the Qualcomm Nord SoC.
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> new file mode 100644
> index 0000000000000..333eccb5c603a
> --- /dev/null
> +++ b/drivers/gpu/drm/msm/disp/dpu1/catalog/dpu_12_1_nord.h
> @@ -0,0 +1,544 @@
[ ... ]
> +static const struct dpu_intf_cfg nord_intf[] = {
> + {
> + .name = "intf_0", .id = INTF_0,
> + .base = 0x34000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 24),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 25),
> + }, {
> + .name = "intf_3", .id = INTF_3,
> + .base = 0x37000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 30),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 31),
> + }, {
> + .name = "intf_4", .id = INTF_4,
> + .base = 0x38000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 20),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 21),
> + }, {
> + .name = "intf_6", .id = INTF_6,
> + .base = 0x3a000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 22),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR, 23),
> + }, {
> + .name = "intf_7", .id = INTF_7,
> + .base = 0x3b000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_0,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 0),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 1),
> + }, {
> + .name = "intf_8", .id = INTF_8,
> + .base = 0x3c000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 2),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 3),
> + }, {
> + .name = "intf_9", .id = INTF_9,
> + .base = 0x3d000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 4),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 5),
> + }, {
> + .name = "intf_10", .id = INTF_10,
> + .base = 0x3e000, .len = 0x4bc,
> + .type = INTF_DP,
> + .controller_id = MSM_DP_CONTROLLER_1,
> + .prog_fetch_lines_worst_case = 24,
> + .intr_underrun = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 6),
> + .intr_vsync = DPU_IRQ_IDX(MDP_SSPP_TOP0_INTR2, 7),
> + },
> +};
[Severity: High]
As reported by Dmitry Baryshkov on v1 [1], does referencing INTF_9 and INTF_10
in nord_intf break the build at this commit?
At this point in the series, enum dpu_intf only defines INTF_0 through INTF_8,
and enum dpu_hw_intr_reg and dpu_intr_set_7xxx lack MDP_INTF9_INTR and
MDP_INTF10_INTR, so MDP_INTFn_INTR(intf->id) in dpu_hw_intr_init() also
aliases MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR. These definitions are
added later in the series by commit "drm/msm/dpu: Fix DSI tear interrupts
broken by adding INTF_9 and INTF_10", which should be ordered before this
patch to keep the series bisectable.
[Severity: Medium]
Are the intr_underrun and intr_vsync bit indices for intf_6 through intf_10 in
nord_intf shifted onto the wrong interrupt bits?
On DPU 12.x (such as glymur_intf in dpu_12_2_glymur.h), MDP_SSPP_TOP0_INTR
bits 22 and 23 belong to INTF_5, while INTF_6 uses bits 16 and 17, INTF_7 uses
bits 18 and 19, and INTF_8 uses bits 12 and 13. Because INTF_5 is omitted on
Nord, intf_6 appears to have been assigned INTF_5's bits (22 and 23) and
intf_7 through intf_10 were sequentially assigned bits 0 through 7 in
MDP_SSPP_TOP0_INTR2, which will cause vblank and underrun interrupts to never
fire and dpu_encoder_phys_vid_wait_for_tx_complete() to time out when any of
these interfaces are used.
[1] https://lore.kernel.org/r/bqoezyuyrjiawudbwxybvjpdun5f3fmhhzukdeg2holuc2mykq@oa5mhoylopz7
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=5
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (4 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 05/11] drm/msm/dpu: Add support for DPU 12.1 on Nord Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:29 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
` (4 subsequent siblings)
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
Nord requires INTF_9 and INTF_10. However, enum dpu_hw_intr_reg relies
on all MDP_INTFn_INTR entries being sequential — MDP_INTFn_INTR() macro
computes the interrupt index as MDP_INTF0_INTR + (intf - INTF_0).
Appending INTF_9 and INTF_10 after the tear entries would break this
assumption, causing DSI tear interrupts on existing platforms to map to
wrong interrupt registers.
Fix this by inserting MDP_INTF9_INTR and MDP_INTF10_INTR before
MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR, keeping the sequential
block intact. Add the corresponding register entries to
dpu_intr_set_7xxx and dpu_intr_set_13xx.
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c | 20 ++++++++++++++++++++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h | 2 ++
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h | 2 ++
3 files changed, 24 insertions(+)
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
index 5b7cd5241f45..c9c297ca080c 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.c
@@ -206,6 +206,16 @@ static const struct dpu_intr_reg dpu_intr_set_7xxx[] = {
MDP_INTF_REV_7xxx_INTR_EN(8),
MDP_INTF_REV_7xxx_INTR_STATUS(8)
},
+ [MDP_INTF9_INTR] = {
+ MDP_INTF_REV_7xxx_INTR_CLEAR(9),
+ MDP_INTF_REV_7xxx_INTR_EN(9),
+ MDP_INTF_REV_7xxx_INTR_STATUS(9)
+ },
+ [MDP_INTF10_INTR] = {
+ MDP_INTF_REV_7xxx_INTR_CLEAR(10),
+ MDP_INTF_REV_7xxx_INTR_EN(10),
+ MDP_INTF_REV_7xxx_INTR_STATUS(10)
+ },
};
/*
@@ -282,6 +292,16 @@ static const struct dpu_intr_reg dpu_intr_set_13xx[] = {
MDP_INTF_REV_13xx_INTR_EN(8),
MDP_INTF_REV_13xx_INTR_STATUS(8)
},
+ [MDP_INTF9_INTR] = {
+ MDP_INTF_REV_13xx_INTR_CLEAR(9),
+ MDP_INTF_REV_13xx_INTR_EN(9),
+ MDP_INTF_REV_13xx_INTR_STATUS(9)
+ },
+ [MDP_INTF10_INTR] = {
+ MDP_INTF_REV_13xx_INTR_CLEAR(10),
+ MDP_INTF_REV_13xx_INTR_EN(10),
+ MDP_INTF_REV_13xx_INTR_STATUS(10)
+ },
};
#define DPU_IRQ_MASK(irq_idx) (BIT(DPU_IRQ_BIT(irq_idx)))
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h
index 142358a105c5..7b8a04f8d209 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h
@@ -27,6 +27,8 @@ enum dpu_hw_intr_reg {
MDP_INTF6_INTR,
MDP_INTF7_INTR,
MDP_INTF8_INTR,
+ MDP_INTF9_INTR,
+ MDP_INTF10_INTR,
MDP_INTF1_TEAR_INTR,
MDP_INTF2_TEAR_INTR,
MDP_AD4_0_INTR,
diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
index 0e65bf5ddc4a..7eccb4d2c65e 100644
--- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
+++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
@@ -226,6 +226,8 @@ enum dpu_intf {
INTF_6,
INTF_7,
INTF_8,
+ INTF_9,
+ INTF_10,
INTF_MAX
};
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
@ 2026-11-16 13:29 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:29 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Medium] drm/msm/dpu: INTF_9 and INTF_10 added after use in Nord
catalog
--
commit c5bdfb09c207793f3155b346b39bc8a0210ff8f2
Author: Nabige Aala <nabige.aala@oss.qualcomm.com>
> drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10
>
> Nord requires INTF_9 and INTF_10. However, enum dpu_hw_intr_reg relies
> on all MDP_INTFn_INTR entries being sequential — MDP_INTFn_INTR() macro
> computes the interrupt index as MDP_INTF0_INTR + (intf - INTF_0).
> Appending INTF_9 and INTF_10 after the tear entries would break this
> assumption, causing DSI tear interrupts on existing platforms to map to
> wrong interrupt registers.
>
> Fix this by inserting MDP_INTF9_INTR and MDP_INTF10_INTR before
> MDP_INTF1_TEAR_INTR and MDP_INTF2_TEAR_INTR, keeping the sequential
> block intact. Add the corresponding register entries to
> dpu_intr_set_7xxx and dpu_intr_set_13xx.
>
> Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
> Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
[ ... ]
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> index 0e65bf5ddc4a6..7eccb4d2c65ef 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_mdss.h
> @@ -226,6 +226,8 @@ enum dpu_intf {
> INTF_6,
> INTF_7,
> INTF_8,
> + INTF_9,
> + INTF_10,
> INTF_MAX
> };
[Severity: Medium]
Should this patch come before commit "drm/msm/dpu: Add support for DPU 12.1
on Nord"?
That earlier commit uses INTF_9 and INTF_10 in nord_intf[] before they are
defined here, which breaks the build and git bisect at that point in the
series.
Also, the commit subject and message describe this change as fixing a prior
addition of INTF_9 and INTF_10, whereas this patch introduces INTF_9,
INTF_10, MDP_INTF9_INTR, and MDP_INTF10_INTR for the first time.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=6
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (5 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 06/11] drm/msm/dpu: Fix DSI tear interrupts broken by adding INTF_9 and INTF_10 Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
` (3 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Add Mobile Display Subsystem (MDSS) support for the Nord
platform.
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
drivers/gpu/drm/msm/msm_mdss.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/msm/msm_mdss.c b/drivers/gpu/drm/msm/msm_mdss.c
index 9087c4b290db..90bcc8c28dc2 100644
--- a/drivers/gpu/drm/msm/msm_mdss.c
+++ b/drivers/gpu/drm/msm/msm_mdss.c
@@ -531,6 +531,7 @@ static const struct of_device_id mdss_dt_match[] = {
{ .compatible = "qcom,kaanapali-mdss", .data = &data_57k },
{ .compatible = "qcom,milos-mdss", .data = &data_14k },
{ .compatible = "qcom,msm8998-mdss", .data = &data_76k8 },
+ { .compatible = "qcom,nord-mdss", .data = &data_57k },
{ .compatible = "qcom,qcm2290-mdss", .data = &data_76k8 },
{ .compatible = "qcom,qcs8300-mdss", .data = &data_74k },
{ .compatible = "qcom,sa8775p-mdss", .data = &data_74k },
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers on Nord
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (6 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 07/11] drm/msm: mdss: Add support for MDSS on Nord Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
` (2 subsequent siblings)
10 siblings, 0 replies; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Nord has two MDSS instances, each with two DP controllers. The IO
start addresses for the first MDSS instance's DP controllers are
already covered by the existing SA8775P descriptor table. Add the
IO start addresses for the second MDSS instance's DP controller.
Signed-off-by: Mahadevan P <mahadevan.p@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
drivers/gpu/drm/msm/dp/dp_display.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c b/drivers/gpu/drm/msm/dp/dp_display.c
index bc646d172abe..8b1b01af11cf 100644
--- a/drivers/gpu/drm/msm/dp/dp_display.c
+++ b/drivers/gpu/drm/msm/dp/dp_display.c
@@ -108,6 +108,8 @@ static const struct msm_dp_desc msm_dp_desc_sa8775p[] = {
{ .io_start = 0x0af5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true },
{ .io_start = 0x22154000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true },
{ .io_start = 0x2215c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true },
+ { .io_start = 0x08d54000, .id = MSM_DP_CONTROLLER_0, .wide_bus_supported = true },
+ { .io_start = 0x08d5c000, .id = MSM_DP_CONTROLLER_1, .wide_bus_supported = true },
{}
};
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (7 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 08/11] drm/msm/dp: Add support for DP controllers " Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
10 siblings, 0 replies; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Add tx_res_config() and set_voltages() callbacks to phy_ver_ops so
SoCs with different register layouts can override TX resistor
calibration and TX drive-level writes independently.
Move the TX_BAND and RES_CODE/TX_EMP writes out of the common
power-on path into qcom_edp_tx_res_config_default(), which is
assigned to all existing SoC ops tables. Likewise, dispatch
set_voltages() through the ops pointer in qcom_edp_set_voltages()
before falling back to the default TXn_TX_DRV_LVL writes.
Add phy_status_reg, tx2_tx3_lane_ctl and bias1_en_2lane fields to
qcom_edp_phy_cfg so the power-on path reads register offsets and
the 2-lane bias value from the per-SoC config rather than using
hardcoded constants. Populate these fields for all existing SoC
configs with the current values, preserving existing behaviour.
No functional change for existing SoCs.
Signed-off-by: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 59 +++++++++++++++++++++++++++++--------
1 file changed, 46 insertions(+), 13 deletions(-)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index a3c893f72908..41bcfffbb357 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -82,6 +82,8 @@ struct phy_ver_ops {
int (*com_configure_pll)(const struct qcom_edp *edp);
int (*com_configure_ssc)(const struct qcom_edp *edp);
int (*com_ldo_config)(const struct qcom_edp *edp);
+ int (*tx_res_config)(const struct qcom_edp *edp);
+ int (*set_voltages)(struct qcom_edp *edp, u8 swing, u8 emph);
};
struct qcom_edp_phy_cfg {
@@ -91,6 +93,9 @@ struct qcom_edp_phy_cfg {
const struct qcom_edp_swing_pre_emph_cfg *dp_swing_pre_emph_cfg;
const struct qcom_edp_swing_pre_emph_cfg *edp_swing_pre_emph_cfg;
const struct phy_ver_ops *ver_ops;
+ u32 phy_status_reg;
+ u8 bias1_en_2lane;
+ u32 tx2_tx3_lane_ctl;
};
struct qcom_edp {
@@ -383,6 +388,9 @@ static int qcom_edp_set_voltages(struct qcom_edp *edp, const struct phy_configur
if (ret)
return ret;
+ if (edp->cfg->ver_ops->set_voltages)
+ return edp->cfg->ver_ops->set_voltages(edp, swing, emph);
+
writel(swing, edp->tx0 + TXn_TX_DRV_LVL);
writel(emph, edp->tx0 + TXn_TX_EMP_POST1_LVL);
@@ -645,6 +653,20 @@ static int qcom_edp_ldo_config_v4(const struct qcom_edp *edp)
return 0;
}
+static int qcom_edp_tx_res_config_default(const struct qcom_edp *edp)
+{
+ writel(0x04, edp->tx0 + TXn_TX_BAND);
+ writel(0x04, edp->tx1 + TXn_TX_BAND);
+ writel(0x11, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX0);
+ writel(0x11, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX1);
+ writel(0x11, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX0);
+ writel(0x11, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX1);
+ writel(0x10, edp->tx0 + TXn_TX_EMP_POST1_LVL);
+ writel(0x10, edp->tx1 + TXn_TX_EMP_POST1_LVL);
+
+ return 0;
+}
+
static const struct phy_ver_ops qcom_edp_phy_ops_v3 = {
.com_power_on = qcom_edp_phy_power_on_v4,
.com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_v4,
@@ -653,6 +675,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v3 = {
.com_configure_pll = qcom_edp_com_configure_pll_v4,
.com_configure_ssc = qcom_edp_com_configure_ssc_v4,
.com_ldo_config = qcom_edp_ldo_config_v3,
+ .tx_res_config = qcom_edp_tx_res_config_default,
};
static const struct phy_ver_ops qcom_edp_phy_ops_v4 = {
@@ -663,6 +686,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v4 = {
.com_configure_pll = qcom_edp_com_configure_pll_v4,
.com_configure_ssc = qcom_edp_com_configure_ssc_v4,
.com_ldo_config = qcom_edp_ldo_config_v4,
+ .tx_res_config = qcom_edp_tx_res_config_default,
};
static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = {
@@ -672,6 +696,8 @@ static const struct qcom_edp_phy_cfg sa8775p_dp_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
.ver_ops = &qcom_edp_phy_ops_v4,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static const struct qcom_edp_phy_cfg sc7280_dp_phy_cfg = {
@@ -680,6 +706,8 @@ static const struct qcom_edp_phy_cfg sc7280_dp_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v3,
.ver_ops = &qcom_edp_phy_ops_v3,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static const struct qcom_edp_phy_cfg sc8180x_dp_phy_cfg = {
@@ -688,6 +716,8 @@ static const struct qcom_edp_phy_cfg sc8180x_dp_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg_v2,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg_v2,
.ver_ops = &qcom_edp_phy_ops_v3,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static const struct qcom_edp_phy_cfg sc8280xp_dp_phy_cfg = {
@@ -696,6 +726,8 @@ static const struct qcom_edp_phy_cfg sc8280xp_dp_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
.ver_ops = &qcom_edp_phy_ops_v4,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static const struct qcom_edp_phy_cfg sc8280xp_edp_phy_cfg = {
@@ -705,6 +737,8 @@ static const struct qcom_edp_phy_cfg sc8280xp_edp_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
.ver_ops = &qcom_edp_phy_ops_v4,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static int qcom_edp_phy_power_on_v6(const struct qcom_edp *edp)
@@ -898,6 +932,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v6 = {
.com_configure_pll = qcom_edp_com_configure_pll_v6,
.com_configure_ssc = qcom_edp_com_configure_ssc_v6,
.com_ldo_config = qcom_edp_ldo_config_v6,
+ .tx_res_config = qcom_edp_tx_res_config_default,
};
static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
@@ -906,6 +941,8 @@ static struct qcom_edp_phy_cfg x1e80100_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
.ver_ops = &qcom_edp_phy_ops_v6,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static int qcom_edp_com_configure_ssc_v8(const struct qcom_edp *edp)
@@ -1031,7 +1068,6 @@ static int qcom_edp_com_configure_pll_v8(const struct qcom_edp *edp)
return 0;
}
-
static int qcom_edp_phy_com_resetsm_cntrl_v8(const struct qcom_edp *edp)
{
u32 val;
@@ -1079,6 +1115,7 @@ static const struct phy_ver_ops qcom_edp_phy_ops_v8 = {
.com_configure_pll = qcom_edp_com_configure_pll_v8,
.com_configure_ssc = qcom_edp_com_configure_ssc_v8,
.com_ldo_config = qcom_edp_ldo_config_v6,
+ .tx_res_config = qcom_edp_tx_res_config_default,
};
static struct qcom_edp_phy_cfg glymur_phy_cfg = {
@@ -1087,6 +1124,8 @@ static struct qcom_edp_phy_cfg glymur_phy_cfg = {
.dp_swing_pre_emph_cfg = &dp_phy_swing_pre_emph_cfg_v8,
.edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
.ver_ops = &qcom_edp_phy_ops_v8,
+ .phy_status_reg = DP_PHY_STATUS,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL,
};
static int qcom_edp_phy_power_on(struct phy *phy)
@@ -1121,21 +1160,19 @@ static int qcom_edp_phy_power_on(struct phy *phy)
/* TX Lane configuration */
writel(0x05, edp->edp + DP_PHY_TX0_TX1_LANE_CTL);
- writel(0x05, edp->edp + DP_PHY_TX2_TX3_LANE_CTL);
+ writel(0x05, edp->edp + edp->cfg->tx2_tx3_lane_ctl);
/* TX-0 register configuration */
writel(0x03, edp->tx0 + TXn_TRANSCEIVER_BIAS_EN);
writel(0x0f, edp->tx0 + TXn_CLKBUF_ENABLE);
writel(0x03, edp->tx0 + TXn_RESET_TSYNC_EN);
writel(0x01, edp->tx0 + TXn_TRAN_DRVR_EMP_EN);
- writel(0x04, edp->tx0 + TXn_TX_BAND);
/* TX-1 register configuration */
writel(0x03, edp->tx1 + TXn_TRANSCEIVER_BIAS_EN);
writel(0x0f, edp->tx1 + TXn_CLKBUF_ENABLE);
writel(0x03, edp->tx1 + TXn_RESET_TSYNC_EN);
writel(0x01, edp->tx1 + TXn_TRAN_DRVR_EMP_EN);
- writel(0x04, edp->tx1 + TXn_TX_BAND);
ret = qcom_edp_set_vco_div(edp, &pixel_freq);
if (ret)
@@ -1159,13 +1196,9 @@ static int qcom_edp_phy_power_on(struct phy *phy)
writel(0x00, edp->tx1 + TXn_TX_POL_INV);
writel(0x10, edp->tx0 + TXn_TX_DRV_LVL_OFFSET);
writel(0x10, edp->tx1 + TXn_TX_DRV_LVL_OFFSET);
- writel(0x11, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX0);
- writel(0x11, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX1);
- writel(0x11, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX0);
- writel(0x11, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX1);
-
- writel(0x10, edp->tx0 + TXn_TX_EMP_POST1_LVL);
- writel(0x10, edp->tx1 + TXn_TX_EMP_POST1_LVL);
+ ret = edp->cfg->ver_ops->tx_res_config(edp);
+ if (ret)
+ return ret;
writel(0x1f, edp->tx0 + TXn_TX_DRV_LVL);
writel(0x1f, edp->tx1 + TXn_TX_DRV_LVL);
@@ -1177,7 +1210,7 @@ static int qcom_edp_phy_power_on(struct phy *phy)
cfg1 = 0x1;
} else if (edp->dp_opts.lanes == 2) {
bias0_en = 0x03;
- bias1_en = 0x00;
+ bias1_en = edp->cfg->bias1_en_2lane;
drvr0_en = 0x04;
drvr1_en = 0x07;
cfg1 = 0x3;
@@ -1200,7 +1233,7 @@ static int qcom_edp_phy_power_on(struct phy *phy)
writel(0x19, edp->edp + DP_PHY_CFG);
- ret = readl_poll_timeout(edp->edp + DP_PHY_STATUS,
+ ret = readl_poll_timeout(edp->edp + edp->cfg->phy_status_reg,
val, val & BIT(1), 500, 10000);
if (ret)
return ret;
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (8 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 09/11] phy: qcom: edp: Generalize power-on path for per-SoC overrides Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:30 ` sashiko-bot
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Nord relocates several QSERDES v8 COM registers relative to existing
SoCs. Rather than adding _NORD-suffixed defines to the shared v8
header (which would leave it ambiguous whether non-suffixed registers
are valid for Nord), introduce a dedicated header
phy-qcom-qmp-qserdes-dp-com-v8-nord.h that lists all QSERDES COM
offsets Nord uses under the NORD_DP_QSERDES_COM_* namespace.
Signed-off-by: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
.../qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h | 51 ++++++++++++++++++++++
1 file changed, 51 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
new file mode 100644
index 000000000000..f38b48dae39e
--- /dev/null
+++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
@@ -0,0 +1,51 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved.
+ */
+
+#ifndef QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
+#define QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
+
+/* Nord DP QMP PHY - QSERDES COM registers (relocated from v8 base offsets) */
+#define NORD_DP_QSERDES_COM_HSCLK_SEL_1 0x03c
+#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x058
+#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x05c
+#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE1_MODE0 0x060
+#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE2_MODE0 0x064
+#define NORD_DP_QSERDES_COM_CP_CTRL_MODE0 0x070
+#define NORD_DP_QSERDES_COM_PLL_RCTRL_MODE0 0x074
+#define NORD_DP_QSERDES_COM_PLL_CCTRL_MODE0 0x078
+#define NORD_DP_QSERDES_COM_CORECLK_DIV_MODE0 0x07c
+#define NORD_DP_QSERDES_COM_LOCK_CMP1_MODE0 0x080
+#define NORD_DP_QSERDES_COM_LOCK_CMP2_MODE0 0x084
+#define NORD_DP_QSERDES_COM_DEC_START_MODE0 0x088
+#define NORD_DP_QSERDES_COM_DIV_FRAC_START1_MODE0 0x090
+#define NORD_DP_QSERDES_COM_DIV_FRAC_START2_MODE0 0x094
+#define NORD_DP_QSERDES_COM_DIV_FRAC_START3_MODE0 0x098
+#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN0_MODE0 0x0a0
+#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN1_MODE0 0x0a4
+#define NORD_DP_QSERDES_COM_VCO_TUNE1_MODE0 0x0a8
+#define NORD_DP_QSERDES_COM_VCO_TUNE2_MODE0 0x0ac
+#define NORD_DP_QSERDES_COM_BG_TIMER 0x0bc
+#define NORD_DP_QSERDES_COM_SSC_EN_CENTER 0x0c0
+#define NORD_DP_QSERDES_COM_SSC_ADJ_PER1 0x0c4
+#define NORD_DP_QSERDES_COM_SSC_PER1 0x0cc
+#define NORD_DP_QSERDES_COM_SSC_PER2 0x0d0
+#define NORD_DP_QSERDES_COM_BIAS_EN_CLKBUFLR_EN 0x0dc
+#define NORD_DP_QSERDES_COM_CLK_ENABLE1 0x0e0
+#define NORD_DP_QSERDES_COM_SYS_CLK_CTRL 0x0e4
+#define NORD_DP_QSERDES_COM_SYSCLK_BUF_ENABLE 0x0e8
+#define NORD_DP_QSERDES_COM_PLL_IVCO 0x0f4
+#define NORD_DP_QSERDES_COM_SYSCLK_EN_SEL 0x110
+#define NORD_DP_QSERDES_COM_RESETSM_CNTRL 0x118
+#define NORD_DP_QSERDES_COM_LOCK_CMP_EN 0x120
+#define NORD_DP_QSERDES_COM_VCO_TUNE_CTRL 0x13c
+#define NORD_DP_QSERDES_COM_VCO_TUNE_MAP 0x140
+#define NORD_DP_QSERDES_COM_CLK_SELECT 0x164
+#define NORD_DP_QSERDES_COM_CORE_CLK_EN 0x170
+#define NORD_DP_QSERDES_COM_CMN_CONFIG_1 0x174
+#define NORD_DP_QSERDES_COM_SVS_MODE_CLK_SEL 0x17c
+#define NORD_DP_QSERDES_COM_CMN_STATUS 0x1d0
+#define NORD_DP_QSERDES_COM_C_READY_STATUS 0x1f8
+
+#endif
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
@ 2026-11-16 13:30 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:30 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 1 potential
issue to consider:
- [Low] phy: qcom: edp: duplicate QSERDES v6 COM register definitions in
v8-nord header
--
commit 6ae0c395ca0665ea9d8f96120d2aff620150f574
Author: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
phy: qcom: edp: Add Nord-specific QSERDES COM register header
This commit adds a header defining the QSERDES COM register offsets for
the Nord DisplayPort QMP PHY.
> diff --git a/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
> new file mode 100644
> index 0000000000000..f38b48dae39e3
> --- /dev/null
> +++ b/drivers/phy/qualcomm/phy-qcom-qmp-qserdes-dp-com-v8-nord.h
> @@ -0,0 +1,51 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (c) 2026 Qualcomm Innovation Center, Inc. All rights reserved.
> + */
> +
> +#ifndef QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
> +#define QCOM_PHY_QMP_QSERDES_DP_COM_V8_NORD_H_
> +
> +/* Nord DP QMP PHY - QSERDES COM registers (relocated from v8 base offsets) */
> +#define NORD_DP_QSERDES_COM_HSCLK_SEL_1 0x03c
> +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE1_MODE0 0x058
> +#define NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE2_MODE0 0x05c
> +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE1_MODE0 0x060
> +#define NORD_DP_QSERDES_COM_SSC_STEP_SIZE2_MODE0 0x064
> +#define NORD_DP_QSERDES_COM_CP_CTRL_MODE0 0x070
> +#define NORD_DP_QSERDES_COM_PLL_RCTRL_MODE0 0x074
> +#define NORD_DP_QSERDES_COM_PLL_CCTRL_MODE0 0x078
> +#define NORD_DP_QSERDES_COM_CORECLK_DIV_MODE0 0x07c
> +#define NORD_DP_QSERDES_COM_LOCK_CMP1_MODE0 0x080
> +#define NORD_DP_QSERDES_COM_LOCK_CMP2_MODE0 0x084
> +#define NORD_DP_QSERDES_COM_DEC_START_MODE0 0x088
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START1_MODE0 0x090
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START2_MODE0 0x094
> +#define NORD_DP_QSERDES_COM_DIV_FRAC_START3_MODE0 0x098
> +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN0_MODE0 0x0a0
> +#define NORD_DP_QSERDES_COM_INTEGLOOP_GAIN1_MODE0 0x0a4
> +#define NORD_DP_QSERDES_COM_VCO_TUNE1_MODE0 0x0a8
> +#define NORD_DP_QSERDES_COM_VCO_TUNE2_MODE0 0x0ac
> +#define NORD_DP_QSERDES_COM_BG_TIMER 0x0bc
> +#define NORD_DP_QSERDES_COM_SSC_EN_CENTER 0x0c0
> +#define NORD_DP_QSERDES_COM_SSC_ADJ_PER1 0x0c4
> +#define NORD_DP_QSERDES_COM_SSC_PER1 0x0cc
> +#define NORD_DP_QSERDES_COM_SSC_PER2 0x0d0
> +#define NORD_DP_QSERDES_COM_BIAS_EN_CLKBUFLR_EN 0x0dc
> +#define NORD_DP_QSERDES_COM_CLK_ENABLE1 0x0e0
> +#define NORD_DP_QSERDES_COM_SYS_CLK_CTRL 0x0e4
> +#define NORD_DP_QSERDES_COM_SYSCLK_BUF_ENABLE 0x0e8
> +#define NORD_DP_QSERDES_COM_PLL_IVCO 0x0f4
> +#define NORD_DP_QSERDES_COM_SYSCLK_EN_SEL 0x110
> +#define NORD_DP_QSERDES_COM_RESETSM_CNTRL 0x118
> +#define NORD_DP_QSERDES_COM_LOCK_CMP_EN 0x120
> +#define NORD_DP_QSERDES_COM_VCO_TUNE_CTRL 0x13c
> +#define NORD_DP_QSERDES_COM_VCO_TUNE_MAP 0x140
> +#define NORD_DP_QSERDES_COM_CLK_SELECT 0x164
> +#define NORD_DP_QSERDES_COM_CORE_CLK_EN 0x170
> +#define NORD_DP_QSERDES_COM_CMN_CONFIG_1 0x174
> +#define NORD_DP_QSERDES_COM_SVS_MODE_CLK_SEL 0x17c
> +#define NORD_DP_QSERDES_COM_CMN_STATUS 0x1d0
> +#define NORD_DP_QSERDES_COM_C_READY_STATUS 0x1f8
[Severity: Low]
Can Nord reuse the existing QSERDES_V6_COM_* definitions from
drivers/phy/qualcomm/phy-qcom-qmp-qserdes-com-v6.h instead of introducing
this SoC-specific header?
All 40 NORD_DP_QSERDES_COM_* register offsets defined here are identical to
the existing QSERDES_V6_COM_* definitions. Moreover,
drivers/phy/qualcomm/phy-qcom-edp.c already includes
phy-qcom-qmp-qserdes-com-v6.h and provides v6 COM helpers (such as
qcom_edp_phy_power_on_v6(), qcom_edp_phy_com_resetsm_cntrl_v6(), and
qcom_edp_com_bias_en_clkbuflr_v6()), and nord_usb3dpphy_cfg in
drivers/phy/qualcomm/phy-qcom-qmp-combo.c already uses qmp_v6_dp_serdes_tbl
with the QSERDES_V6_COM_* definitions.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=10
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support
2026-11-16 13:16 [PATCH v3 00/11] Add Qualcomm Nord display and eDP PHY support Nabige Aala
` (9 preceding siblings ...)
2026-11-16 13:16 ` [PATCH v3 10/11] phy: qcom: edp: Add Nord-specific QSERDES COM register header Nabige Aala
@ 2026-11-16 13:16 ` Nabige Aala
2026-11-16 13:44 ` sashiko-bot
10 siblings, 1 reply; 18+ messages in thread
From: Nabige Aala @ 2026-11-16 13:16 UTC (permalink / raw)
To: Vinod Koul, Neil Armstrong, Manivannan Sadhasivam, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Bjorn Andersson, Rob Clark,
Dmitry Baryshkov, Abhinav Kumar, Jessica Zhang, Sean Paul,
Marijn Suijten, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter, Kuogee Hsieh,
Shawn Guo
Cc: Ritesh Kumar, Mahadevan P, Nabige Aala, linux-arm-msm, linux-phy,
devicetree, linux-kernel, dri-devel, freedreno
From: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Add eDP/DP PHY support for the Qualcomm Nord SoC. Nord uses a
different QSERDES COM register layout from existing v8 SoCs, so
dedicated NORD_DP_QSERDES_COM_* offsets are used throughout.
Key additions:
- SSC and PLL configuration per HPG Tables 2-8 and 2-9
- Power-on and reset-SM callbacks polling the relocated COM status
registers
- Voltage-swing and pre-emphasis tables for RBR/HBR and HBR2/HBR3
- LDO, TX resistor calibration, and set_voltages callbacks
- AUX channel and VCO divider config tables
- 'qcom,nord-dp-phy' OF compatible
Signed-off-by: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
Signed-off-by: Nabige Aala <nabige.aala@oss.qualcomm.com>
---
drivers/phy/qualcomm/phy-qcom-edp.c | 258 ++++++++++++++++++++++++++++++++++++
1 file changed, 258 insertions(+)
diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
index 41bcfffbb357..eb8beda84196 100644
--- a/drivers/phy/qualcomm/phy-qcom-edp.c
+++ b/drivers/phy/qualcomm/phy-qcom-edp.c
@@ -27,6 +27,7 @@
#include "phy-qcom-qmp-qserdes-com-v6.h"
#include "phy-qcom-qmp-qserdes-dp-com-v8.h"
+#include "phy-qcom-qmp-qserdes-dp-com-v8-nord.h"
/* EDP_PHY registers */
#define DP_PHY_CFG 0x0010
@@ -1514,6 +1515,262 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
return PTR_ERR_OR_ZERO(phy_provider);
}
+static const u8 nord_dp_pre_emp_hbr_rbr[4][4] = {
+ { 0x00, 0x0e, 0x15, 0x1a },
+ { 0x00, 0x0e, 0x15, 0xff },
+ { 0x00, 0x0e, 0xff, 0xff },
+ { 0x02, 0xff, 0xff, 0xff },
+};
+
+static const struct qcom_edp_swing_pre_emph_cfg nord_dp_swing_pre_emph_cfg = {
+ .swing_hbr_rbr = &dp_swing_hbr_rbr,
+ .swing_hbr3_hbr2 = &dp_swing_hbr2_hbr3,
+ .pre_emphasis_hbr_rbr = &nord_dp_pre_emp_hbr_rbr,
+ .pre_emphasis_hbr3_hbr2 = &dp_pre_emp_hbr2_hbr3,
+};
+
+/* Nord DP PHY register offsets (relocated from v8 base) */
+#define DP_PHY_TX2_TX3_LANE_CTL_NORD 0x00c0
+#define DP_PHY_STATUS_NORD 0x0110
+#define DP_PHY_LDO_CFG_NORD 0x00f0
+#define DP_PHY_TX_LN0_DRV_LVL_NORD 0x00e4
+#define DP_PHY_TX_LN1_DRV_LVL_NORD 0x00e8
+#define TXn_TX_BAND_NORD 0x0024
+
+static int qcom_edp_com_configure_ssc_nord(const struct qcom_edp *edp)
+{
+ const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
+ u32 step1;
+ u32 step2;
+
+ switch (dp_opts->link_rate) {
+ case 1620:
+ step1 = 0x83;
+ step2 = 0x02;
+ break;
+
+ case 2700:
+ case 5400:
+ step1 = 0x18;
+ step2 = 0x02;
+ break;
+
+ case 8100:
+ step1 = 0x5b;
+ step2 = 0x02;
+ break;
+
+ default:
+ return -EINVAL;
+ }
+
+ writel(0x01, edp->pll + NORD_DP_QSERDES_COM_SSC_EN_CENTER);
+ writel(0x00, edp->pll + NORD_DP_QSERDES_COM_SSC_ADJ_PER1);
+ writel(0x6b, edp->pll + NORD_DP_QSERDES_COM_SSC_PER1);
+ writel(0x02, edp->pll + NORD_DP_QSERDES_COM_SSC_PER2);
+ writel(step1, edp->pll + NORD_DP_QSERDES_COM_SSC_STEP_SIZE1_MODE0);
+ writel(step2, edp->pll + NORD_DP_QSERDES_COM_SSC_STEP_SIZE2_MODE0);
+
+ return 0;
+}
+
+static int qcom_edp_com_configure_pll_nord(const struct qcom_edp *edp)
+{
+ const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
+ u32 div_frac_start2_mode0;
+ u32 div_frac_start3_mode0;
+ u32 dec_start_mode0;
+ u32 lock_cmp1_mode0;
+ u32 lock_cmp2_mode0;
+ u32 lock_cmp_en;
+ u32 hsclk_sel;
+ u32 code1_mode0;
+ u32 code2_mode0;
+ u32 core_clk_div_mode0 = 0x14;
+
+ switch (dp_opts->link_rate) {
+ case 1620:
+ hsclk_sel = 0x0c;
+ dec_start_mode0 = 0x54;
+ div_frac_start2_mode0 = 0x00;
+ div_frac_start3_mode0 = 0x06;
+ lock_cmp1_mode0 = 0x37;
+ lock_cmp2_mode0 = 0x04;
+ lock_cmp_en = 0x04;
+ code1_mode0 = 0x8d;
+ code2_mode0 = 0x27;
+ break;
+
+ case 2700:
+ hsclk_sel = 0x04;
+ dec_start_mode0 = 0x46;
+ div_frac_start2_mode0 = 0x00;
+ div_frac_start3_mode0 = 0x05;
+ lock_cmp1_mode0 = 0x07;
+ lock_cmp2_mode0 = 0x07;
+ lock_cmp_en = 0x08;
+ code1_mode0 = 0xf6;
+ code2_mode0 = 0x20;
+ break;
+
+ case 5400:
+ hsclk_sel = 0x01;
+ dec_start_mode0 = 0x46;
+ div_frac_start2_mode0 = 0x00;
+ div_frac_start3_mode0 = 0x05;
+ lock_cmp1_mode0 = 0x0f;
+ lock_cmp2_mode0 = 0x0e;
+ lock_cmp_en = 0x08;
+ code1_mode0 = 0xf6;
+ code2_mode0 = 0x20;
+ break;
+
+ case 8100:
+ hsclk_sel = 0x03;
+ dec_start_mode0 = 0x4f;
+ div_frac_start2_mode0 = 0xa0;
+ div_frac_start3_mode0 = 0x01;
+ lock_cmp1_mode0 = 0x17;
+ lock_cmp2_mode0 = 0x15;
+ lock_cmp_en = 0x08;
+ code1_mode0 = 0x14;
+ code2_mode0 = 0x25;
+ core_clk_div_mode0 = 0x0a;
+ break;
+
+ default:
+ return -EINVAL;
+ }
+
+ writel(0x01, edp->pll + NORD_DP_QSERDES_COM_SVS_MODE_CLK_SEL);
+ writel(0x0b, edp->pll + NORD_DP_QSERDES_COM_SYSCLK_EN_SEL);
+ writel(0x02, edp->pll + NORD_DP_QSERDES_COM_SYS_CLK_CTRL);
+ writel(0x0c, edp->pll + NORD_DP_QSERDES_COM_CLK_ENABLE1);
+ writel(0x06, edp->pll + NORD_DP_QSERDES_COM_SYSCLK_BUF_ENABLE);
+ writel(0x30, edp->pll + NORD_DP_QSERDES_COM_CLK_SELECT);
+ writel(hsclk_sel, edp->pll + NORD_DP_QSERDES_COM_HSCLK_SEL_1);
+ writel(0x07, edp->pll + NORD_DP_QSERDES_COM_PLL_IVCO);
+ writel(lock_cmp_en, edp->pll + NORD_DP_QSERDES_COM_LOCK_CMP_EN);
+ writel(0x36, edp->pll + NORD_DP_QSERDES_COM_PLL_CCTRL_MODE0);
+ writel(0x16, edp->pll + NORD_DP_QSERDES_COM_PLL_RCTRL_MODE0);
+ writel(0x06, edp->pll + NORD_DP_QSERDES_COM_CP_CTRL_MODE0);
+ writel(dec_start_mode0, edp->pll + NORD_DP_QSERDES_COM_DEC_START_MODE0);
+ writel(0x00, edp->pll + NORD_DP_QSERDES_COM_DIV_FRAC_START1_MODE0);
+ writel(div_frac_start2_mode0, edp->pll + NORD_DP_QSERDES_COM_DIV_FRAC_START2_MODE0);
+ writel(div_frac_start3_mode0, edp->pll + NORD_DP_QSERDES_COM_DIV_FRAC_START3_MODE0);
+ writel(0x12, edp->pll + NORD_DP_QSERDES_COM_CMN_CONFIG_1);
+ writel(0x3f, edp->pll + NORD_DP_QSERDES_COM_INTEGLOOP_GAIN0_MODE0);
+ writel(0x00, edp->pll + NORD_DP_QSERDES_COM_INTEGLOOP_GAIN1_MODE0);
+ writel(0x00, edp->pll + NORD_DP_QSERDES_COM_VCO_TUNE_MAP);
+ writel(lock_cmp1_mode0, edp->pll + NORD_DP_QSERDES_COM_LOCK_CMP1_MODE0);
+ writel(lock_cmp2_mode0, edp->pll + NORD_DP_QSERDES_COM_LOCK_CMP2_MODE0);
+ writel(0x0a, edp->pll + NORD_DP_QSERDES_COM_BG_TIMER);
+ writel(core_clk_div_mode0, edp->pll + NORD_DP_QSERDES_COM_CORECLK_DIV_MODE0);
+ writel(0x00, edp->pll + NORD_DP_QSERDES_COM_VCO_TUNE_CTRL);
+ writel(0x1f, edp->pll + NORD_DP_QSERDES_COM_BIAS_EN_CLKBUFLR_EN);
+ writel(0x0f, edp->pll + NORD_DP_QSERDES_COM_CORE_CLK_EN);
+ writel(0xa0, edp->pll + NORD_DP_QSERDES_COM_VCO_TUNE1_MODE0);
+ writel(0x01, edp->pll + NORD_DP_QSERDES_COM_VCO_TUNE2_MODE0);
+ writel(code1_mode0, edp->pll + NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE1_MODE0);
+ writel(code2_mode0, edp->pll + NORD_DP_QSERDES_COM_BIN_VCOCAL_CMP_CODE2_MODE0);
+
+ return 0;
+}
+
+static const u8 edp_phy_aux_cfg_nord[DP_AUX_CFG_SIZE] = {
+ 0x00, 0x13, 0xa4, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03, 0x02, 0x02, 0x04,
+};
+
+static const u8 edp_phy_vco_div_cfg_nord[4] = {
+ 0x00, 0x00, 0x02, 0x01,
+};
+
+static int qcom_edp_ldo_config_nord(const struct qcom_edp *edp)
+{
+ const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
+
+ writel(0xd0, edp->tx0 + TXn_LDO_CONFIG);
+ writel(dp_opts->lanes > 2 ? 0xd0 : 0x00, edp->tx1 + TXn_LDO_CONFIG);
+ writel(0x03, edp->edp + DP_PHY_LDO_CFG_NORD);
+
+ return 0;
+}
+
+static int qcom_edp_tx_res_config_nord(const struct qcom_edp *edp)
+{
+ writel(0x06, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX0);
+ writel(0x06, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX1);
+ writel(0x06, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX0);
+ writel(0x06, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX1);
+ writel(0x06, edp->tx0 + TXn_TX_EMP_POST1_LVL);
+ writel(0x06, edp->tx1 + TXn_TX_EMP_POST1_LVL);
+ writel(0x05, edp->tx0 + TXn_TX_BAND_NORD);
+ writel(0x05, edp->tx1 + TXn_TX_BAND_NORD);
+ writel(0x12, edp->edp + DP_PHY_TX_LN0_DRV_LVL_NORD);
+ writel(0x12, edp->edp + DP_PHY_TX_LN1_DRV_LVL_NORD);
+
+ return 0;
+}
+
+static int qcom_edp_phy_power_on_nord(const struct qcom_edp *edp)
+{
+ u32 val;
+
+ writel(DP_PHY_PD_CTL_PWRDN | DP_PHY_PD_CTL_AUX_PWRDN |
+ DP_PHY_PD_CTL_LANE_0_1_PWRDN | DP_PHY_PD_CTL_LANE_2_3_PWRDN |
+ DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN,
+ edp->edp + DP_PHY_PD_CTL);
+ writel(0xfc, edp->edp + DP_PHY_MODE);
+
+ return readl_poll_timeout(edp->pll + NORD_DP_QSERDES_COM_CMN_STATUS,
+ val, val & BIT(7), 5, 200);
+}
+
+static int qcom_edp_phy_com_resetsm_cntrl_nord(const struct qcom_edp *edp)
+{
+ u32 val;
+
+ writel(0x20, edp->pll + NORD_DP_QSERDES_COM_RESETSM_CNTRL);
+
+ return readl_poll_timeout(edp->pll + NORD_DP_QSERDES_COM_C_READY_STATUS,
+ val, val & BIT(0), 500, 10000);
+}
+
+static int qcom_edp_set_voltages_nord(struct qcom_edp *edp, u8 swing, u8 emph)
+{
+ writel(swing, edp->edp + DP_PHY_TX_LN0_DRV_LVL_NORD);
+ writel(emph, edp->tx0 + TXn_TX_EMP_POST1_LVL);
+
+ writel(swing, edp->edp + DP_PHY_TX_LN1_DRV_LVL_NORD);
+ writel(emph, edp->tx1 + TXn_TX_EMP_POST1_LVL);
+
+ return 0;
+}
+
+static const struct phy_ver_ops qcom_edp_phy_ops_nord = {
+ .com_power_on = qcom_edp_phy_power_on_nord,
+ .com_resetsm_cntrl = qcom_edp_phy_com_resetsm_cntrl_nord,
+ .com_bias_en_clkbuflr = qcom_edp_com_bias_en_clkbuflr_v8,
+ .com_clk_fwd_cfg = qcom_edp_com_clk_fwd_cfg_v4,
+ .com_configure_pll = qcom_edp_com_configure_pll_nord,
+ .com_configure_ssc = qcom_edp_com_configure_ssc_nord,
+ .com_ldo_config = qcom_edp_ldo_config_nord,
+ .tx_res_config = qcom_edp_tx_res_config_nord,
+ .set_voltages = qcom_edp_set_voltages_nord,
+};
+
+static const struct qcom_edp_phy_cfg nord_edp_phy_cfg = {
+ .is_edp = false,
+ .aux_cfg = edp_phy_aux_cfg_nord,
+ .vco_div_cfg = edp_phy_vco_div_cfg_nord,
+ .dp_swing_pre_emph_cfg = &nord_dp_swing_pre_emph_cfg,
+ .edp_swing_pre_emph_cfg = &edp_phy_swing_pre_emph_cfg,
+ .ver_ops = &qcom_edp_phy_ops_nord,
+ .phy_status_reg = DP_PHY_STATUS_NORD,
+ .bias1_en_2lane = 0x03,
+ .tx2_tx3_lane_ctl = DP_PHY_TX2_TX3_LANE_CTL_NORD,
+};
+
static const struct of_device_id qcom_edp_phy_match_table[] = {
{ .compatible = "qcom,glymur-dp-phy", .data = &glymur_phy_cfg, },
{ .compatible = "qcom,sa8775p-edp-phy", .data = &sa8775p_dp_phy_cfg, },
@@ -1522,6 +1779,7 @@ static const struct of_device_id qcom_edp_phy_match_table[] = {
{ .compatible = "qcom,sc8280xp-dp-phy", .data = &sc8280xp_dp_phy_cfg, },
{ .compatible = "qcom,sc8280xp-edp-phy", .data = &sc8280xp_edp_phy_cfg, },
{ .compatible = "qcom,x1e80100-dp-phy", .data = &x1e80100_phy_cfg, },
+ { .compatible = "qcom,nord-dp-phy", .data = &nord_edp_phy_cfg, },
{ }
};
MODULE_DEVICE_TABLE(of, qcom_edp_phy_match_table);
--
2.34.1
^ permalink raw reply related [flat|nested] 18+ messages in thread* Re: [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support
2026-11-16 13:16 ` [PATCH v3 11/11] phy: qcom: edp: Add Nord eDP/DP PHY support Nabige Aala
@ 2026-11-16 13:44 ` sashiko-bot
0 siblings, 0 replies; 18+ messages in thread
From: sashiko-bot @ 2026-11-16 13:44 UTC (permalink / raw)
To: Nabige Aala
Cc: linux-phy, devicetree, dri-devel, robh, conor+dt, vkoul,
neil.armstrong, olteanv
Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [Low] phy: qcom: edp: duplicated v6/v8 definitions and misplaced Nord
code
- [Low] phy: qcom: edp: asymmetric DRV_LVL writes in
qcom_edp_tx_res_config_nord()
--
commit d8ce2b9ae0271c780b642dc599049c73dd865127
Author: Ritesh Kumar <ritesh.kumar@oss.qualcomm.com>
phy: qcom: edp: Add Nord eDP/DP PHY support
This commit adds eDP/DP PHY support, callbacks, configuration tables, and the
qcom,nord-dp-phy compatible string for the Qualcomm Nord SoC.
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index c61e57cc2aa7b..d5de6d322f023 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -27,6 +27,7 @@
> #include "phy-qcom-qmp-qserdes-com-v6.h"
>
> #include "phy-qcom-qmp-qserdes-dp-com-v8.h"
> +#include "phy-qcom-qmp-qserdes-dp-com-v8-nord.h"
>
> /* EDP_PHY registers */
> #define DP_PHY_CFG 0x0010
> @@ -1514,6 +1515,262 @@ static int qcom_edp_phy_probe(struct platform_device *pdev)
> return PTR_ERR_OR_ZERO(phy_provider);
> }
>
> +static const u8 nord_dp_pre_emp_hbr_rbr[4][4] = {
[ ... ]
> +static const u8 edp_phy_vco_div_cfg_nord[4] = {
> + 0x00, 0x00, 0x02, 0x01,
> +};
> +
> +static int qcom_edp_ldo_config_nord(const struct qcom_edp *edp)
> +{
> + const struct phy_configure_opts_dp *dp_opts = &edp->dp_opts;
> +
> + writel(0xd0, edp->tx0 + TXn_LDO_CONFIG);
> + writel(dp_opts->lanes > 2 ? 0xd0 : 0x00, edp->tx1 + TXn_LDO_CONFIG);
> + writel(0x03, edp->edp + DP_PHY_LDO_CFG_NORD);
> +
> + return 0;
> +}
> +
> +static int qcom_edp_tx_res_config_nord(const struct qcom_edp *edp)
> +{
> + writel(0x06, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX0);
> + writel(0x06, edp->tx0 + TXn_RES_CODE_LANE_OFFSET_TX1);
> + writel(0x06, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX0);
> + writel(0x06, edp->tx1 + TXn_RES_CODE_LANE_OFFSET_TX1);
> + writel(0x06, edp->tx0 + TXn_TX_EMP_POST1_LVL);
> + writel(0x06, edp->tx1 + TXn_TX_EMP_POST1_LVL);
> + writel(0x05, edp->tx0 + TXn_TX_BAND_NORD);
> + writel(0x05, edp->tx1 + TXn_TX_BAND_NORD);
> + writel(0x12, edp->edp + DP_PHY_TX_LN0_DRV_LVL_NORD);
> + writel(0x12, edp->edp + DP_PHY_TX_LN1_DRV_LVL_NORD);
> +
> + return 0;
> +}
[Severity: Low]
As reported by Dmitry Baryshkov on v2 [1], should initial TX drive-level
programming be handled symmetrically between qcom_edp_tx_res_config_nord()
and qcom_edp_tx_res_config_default()?
qcom_edp_tx_res_config_nord() programs DP_PHY_TX_LN0_DRV_LVL_NORD and
DP_PHY_TX_LN1_DRV_LVL_NORD, whereas qcom_edp_tx_res_config_default() omits
TXn_TX_DRV_LVL and leaves those writes hardcoded in qcom_edp_phy_power_on():
drivers/phy/qualcomm/phy-qcom-edp.c:qcom_edp_phy_power_on() {
...
ret = edp->cfg->ver_ops->tx_res_config(edp);
if (ret)
return ret;
writel(0x1f, edp->tx0 + TXn_TX_DRV_LVL);
writel(0x1f, edp->tx1 + TXn_TX_DRV_LVL);
...
}
Because qcom_edp_phy_power_on() unconditionally writes 0x1f to TXn_TX_DRV_LVL
after calling tx_res_config(), Nord still executes the legacy TXn_TX_DRV_LVL
writes even though it relocates drive-level control to
DP_PHY_TX_LN0_DRV_LVL_NORD and DP_PHY_TX_LN1_DRV_LVL_NORD.
> +
> +static int qcom_edp_phy_power_on_nord(const struct qcom_edp *edp)
> +{
> + u32 val;
> +
> + writel(DP_PHY_PD_CTL_PWRDN | DP_PHY_PD_CTL_AUX_PWRDN |
> + DP_PHY_PD_CTL_LANE_0_1_PWRDN | DP_PHY_PD_CTL_LANE_2_3_PWRDN |
> + DP_PHY_PD_CTL_PLL_PWRDN | DP_PHY_PD_CTL_DP_CLAMP_EN,
> + edp->edp + DP_PHY_PD_CTL);
> + writel(0xfc, edp->edp + DP_PHY_MODE);
> +
> + return readl_poll_timeout(edp->pll + NORD_DP_QSERDES_COM_CMN_STATUS,
> + val, val & BIT(7), 5, 200);
> +}
> +
> +static int qcom_edp_phy_com_resetsm_cntrl_nord(const struct qcom_edp *edp)
> +{
> + u32 val;
> +
> + writel(0x20, edp->pll + NORD_DP_QSERDES_COM_RESETSM_CNTRL);
> +
> + return readl_poll_timeout(edp->pll + NORD_DP_QSERDES_COM_C_READY_STATUS,
> + val, val & BIT(0), 500, 10000);
> +}
[ ... ]
> static const struct of_device_id qcom_edp_phy_match_table[] = {
> { .compatible = "qcom,glymur-dp-phy", .data = &glymur_phy_cfg, },
> { .compatible = "qcom,sa8775p-edp-phy", .data = &sa8775p_dp_phy_cfg, },
> @@ -1522,6 +1779,7 @@ static const struct of_device_id qcom_edp_phy_match_table[] = {
> { .compatible = "qcom,sc8280xp-dp-phy", .data = &sc8280xp_dp_phy_cfg, },
> { .compatible = "qcom,sc8280xp-edp-phy", .data = &sc8280xp_edp_phy_cfg, },
> { .compatible = "qcom,x1e80100-dp-phy", .data = &x1e80100_phy_cfg, },
> + { .compatible = "qcom,nord-dp-phy", .data = &nord_edp_phy_cfg, },
> { }
> };
> MODULE_DEVICE_TABLE(of, qcom_edp_phy_match_table);
[Severity: Low]
Can Nord reuse the existing v6 and v8 definitions instead of duplicating
them?
All 40 NORD_DP_QSERDES_COM_* offsets in phy-qcom-qmp-qserdes-dp-com-v8-nord.h
are identical to the QSERDES_V6_COM_* offsets in
phy-qcom-qmp-qserdes-com-v6.h, which is already included in this file.
Consequently, qcom_edp_phy_power_on_nord() and
qcom_edp_phy_com_resetsm_cntrl_nord() are identical to
qcom_edp_phy_power_on_v6() and qcom_edp_phy_com_resetsm_cntrl_v6(), and
edp_phy_vco_div_cfg_nord is identical to edp_phy_vco_div_cfg_v8.
Also, the Nord register macros, configuration tables, and callbacks are
placed after qcom_edp_phy_probe() instead of alongside the other SoC
definitions earlier in the file, and qcom,nord-dp-phy is appended to the end
of the alphabetically sorted qcom_edp_phy_match_table[].
[1] https://lore.kernel.org/r/qqfucmyebsvemdr5px33wabsxxq4owozwmxcqu62sprs5k32bo@kb5pjx2m4ucq
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261116-nord-drv-dt-v3-0-e3d3bf0e2c49@oss.qualcomm.com?part=11
^ permalink raw reply [flat|nested] 18+ messages in thread