Devicetree
 help / color / mirror / Atom feed
From: sashiko-bot@kernel.org
To: rofikkerneldev <rofikcoga@gmail.com>
Cc: devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org,
	linux-input@vger.kernel.org, robh@kernel.org,
	conor+dt@kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH v1 01/11] dt-bindings: arm: qcom: add LG V60 ThinQ 5G (timelm)
Date: Tue, 17 Nov 2026 12:47:24 +0000	[thread overview]
Message-ID: <sashiko-outbox-218789@kernel.org> (raw)
In-Reply-To: <20261117123946.668557-2-rofikcoga@gmail.com>

Thank you for your contribution! Sashiko AI review found 2 potential
issues to consider:
- [High] dt-bindings: arm: qcom: username in Signed-off-by instead of
  real name
- [Low] dt-bindings: arm: qcom: duplicate lge vendor prefix instead of
  lg
--

commit 3057431969983ea736dadadbf8f06be7752765b6
Author: rofikkerneldev <rofikcoga@gmail.com>

> dt-bindings: arm: qcom: add LG V60 ThinQ 5G (timelm)
>
> Document the compatible for the LG V60 ThinQ 5G (timelm), based on
> SM8250, and register the LG Electronics vendor prefix.
>
> Signed-off-by: rofikkerneldev <rofikcoga@gmail.com>

[Severity: High]
The Author header and Signed-off-by trailer use a handle (rofikkerneldev)
instead of a known real human name, which is required by the Developer's
Certificate of Origin in Documentation/process/submitting-patches.rst.

> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 121ca557ce1ef..f8b34109171d0 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -1139,6 +1139,7 @@ properties:
>  
>        - items:
>            - enum:
> +              - lge,timelm
>                - qcom,qrb5165-rb5
>                - qcom,sm8250-hdk
>                - qcom,sm8250-mtp
> diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> index 5471a06f93f10..fa50a81880f0b 100644
> --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml
> +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml
> @@ -971,6 +971,8 @@ patternProperties:
>      description: Lenovo Group Ltd.
>    "^lg,.*":
>      description: LG Corporation
> +  "^lge,.*":
> +    description: LG Electronics
>    "^lgphilips,.*":
>      description: LG Display
>    "^libretech,.*":

[Severity: Low]
Should this use the existing "lg" vendor prefix (lg,timelm) instead of
adding a duplicate "lge" prefix?

Documentation/devicetree/bindings/vendor-prefixes.yaml already defines
"^lg,.*" for LG Corporation, and commit 5e4aac2caf12 ("dt-bindings: arm:
qcom: rename vendor of apq8026-lenok") replaced "lge" with "lg" in
Documentation/devicetree/bindings/arm/qcom.yaml to avoid separate vendor
prefixes for internal divisions of LG.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261117123946.668557-1-rofikcoga@gmail.com?part=1

  reply	other threads:[~2026-11-17 12:47 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-17 12:39 [PATCH v1 00/11] arm64: qcom: Add initial support for LG V60 ThinQ 5G (timelm) rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 01/11] dt-bindings: arm: qcom: add " rofikkerneldev
2026-11-17 12:47   ` sashiko-bot [this message]
2026-11-17 12:39 ` [PATCH v1 02/11] arm64: dts: qcom: add LG V60 ThinQ 5G (timelm) support rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 03/11] arm64: dts: qcom: sm8250-lge-timelm: add reserved memory regions rofikkerneldev
2026-11-17 12:57   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 04/11] dt-bindings: display: panel: add LG SW43103 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 05/11] drm/panel: add LG SW43103 panel driver rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 06/11] dt-bindings: input: touchscreen: add Silicon Works SW42902 rofikkerneldev
2026-11-17 12:51   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 07/11] Input: touchscreen: add Silicon Works SW42902 support rofikkerneldev
2026-11-17 13:01   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 08/11] arm64: dts: qcom: sm8250-lge-timelm: enable SW43103 panel rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 09/11] arm64: dts: qcom: sm8250-lge-timelm: add SW42902 touchscreen rofikkerneldev
2026-11-17 12:56   ` sashiko-bot
2026-11-17 12:39 ` [PATCH v1 10/11] arm64: dts: qcom: sm8250-lge-timelm: enable USB Type-C rofikkerneldev
2026-11-17 12:39 ` [PATCH v1 11/11] arm64: dts: qcom: sm8250-lge-timelm: add QCA6390 Bluetooth rofikkerneldev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=sashiko-outbox-218789@kernel.org \
    --to=sashiko-bot@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-input@vger.kernel.org \
    --cc=robh@kernel.org \
    --cc=rofikcoga@gmail.com \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox